From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pdx-out-015.esa.us-west-2.outbound.mail-perimeter.amazon.com (pdx-out-015.esa.us-west-2.outbound.mail-perimeter.amazon.com [50.112.246.219]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6FFE384236; Thu, 30 Apr 2026 03:26:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=50.112.246.219 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777519587; cv=none; b=u5aibOqx8Th1AMH5w2sNm4F7OTnFALY0AzOlpZ/L08WIhlbIdQnYyjY5P+Brlh4zKULOiBaQa0XOU9Xc4dnrs3ReutXeJlVy/hTeS/S8YJHasNui/+HbySmrRYIijRdS5JQgNJ8CwlD9DU0Tz5Loa0BW4oRrzW5NJk9zc3K63kQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777519587; c=relaxed/simple; bh=3TGtOzPn0RxyO/+/FxJXgX91uECyg93GeYIjrF2UsQs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LZt2HolmeEfmUzi+2/C+xc8gri7UJs76GTG+iodExKTWpsUFLl1SibzPqqeLqdsTYvosJbhvC2TKeaJmofjTYWS+spggDGY+ODTHevxYcG4ZL4MwJ8Txrxs1tNBai5JkIwSEylInEvJmE2y+7xSgSlQu+Emk8zS/1lhu0qx0l5Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com; spf=pass smtp.mailfrom=amazon.com; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b=ADVhxAvA; arc=none smtp.client-ip=50.112.246.219 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b="ADVhxAvA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1777519586; x=1809055586; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=QxX1R+bJTeGdHHpMlgT86lyJMRpGzOjKsh3iX3iumeM=; b=ADVhxAvASkD9FNKLXwh8MrgkFZB1rbCNXPlbBXqPanY3m5znMOUjcxx8 YowWFJa92XG28Rdh3rkBbapeRviN7rfR/7hWHBfQujHmWGqzCUG83iP6w NbqowRLSWrkSgUhMG8Wm4rXsc9EDVv+Vx1vidVIrSjUbRlKOyXOwcySD6 45pClqmB7opNBDiZPBPUBfvVecoyN6IvygZzsKc/zEsiEn3e7B5C8QjMI GvTxz7hq5pTGNwgFDyVED90VjvM3Ss1T68sIW6tbKJ1+yR8fRaKAhiX/Y 8JszTigjaoR7dlePwl0IVZ84W4sXw1DpvJQEuZniONCBi7xs3wUmge4EX A==; X-CSE-ConnectionGUID: yFmCUc1HTY+Eqn4RI3zs+g== X-CSE-MsgGUID: xT9VL42uTw+xyniHY3Lk8Q== X-IronPort-AV: E=Sophos;i="6.23,207,1770595200"; d="scan'208";a="18347843" Received: from ip-10-5-6-203.us-west-2.compute.internal (HELO smtpout.naws.us-west-2.prod.farcaster.email.amazon.dev) ([10.5.6.203]) by internal-pdx-out-015.esa.us-west-2.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2026 03:26:23 +0000 Received: from EX19MTAUWC001.ant.amazon.com [205.251.233.105:26826] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.4.227:2525] with esmtp (Farcaster) id 26dea6bb-e7d0-4d1d-aa44-5e464c24cba3; Thu, 30 Apr 2026 03:26:23 +0000 (UTC) X-Farcaster-Flow-ID: 26dea6bb-e7d0-4d1d-aa44-5e464c24cba3 Received: from EX19D001UWA001.ant.amazon.com (10.13.138.214) by EX19MTAUWC001.ant.amazon.com (10.250.64.174) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.37; Thu, 30 Apr 2026 03:26:23 +0000 Received: from dev-dsk-akiyano-1c-2138b29d.eu-west-1.amazon.com (172.19.83.6) by EX19D001UWA001.ant.amazon.com (10.13.138.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.37; Thu, 30 Apr 2026 03:26:18 +0000 From: Arthur Kiyanovski To: David Miller , Jakub Kicinski , CC: Arthur Kiyanovski , Richard Cochran , Eric Dumazet , Paolo Abeni , David Woodhouse , Thomas Gleixner , Miroslav Lichvar , Andrew Lunn , Wen Gu , Xuan Zhuo , David Woodhouse , "Yonatan Sarna" , Zorik Machulsky , "Alexander Matushevsky" , Saeed Bshara , Matt Wilson , Anthony Liguori , Nafea Bshara , Evgeny Schmeilin , Netanel Belgazal , Ali Saidi , Benjamin Herrenschmidt , Noam Dagan , David Arinzon , Evgeny Ostrovsky , Ofir Tabachnik , Amit Bernstein , , , Subject: [PATCH v2 net-next 8/8] net: ena: Implement gettimexattrs64 callback for PTP attributes Date: Thu, 30 Apr 2026 03:25:05 +0000 Message-ID: <20260430032507.11586-9-akiyano@amazon.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260430032507.11586-1-akiyano@amazon.com> References: <20260430032507.11586-1-akiyano@amazon.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: EX19D040UWB002.ant.amazon.com (10.13.138.89) To EX19D001UWA001.ant.amazon.com (10.13.138.214) Implement the gettimexattrs64 callback in the ENA driver to support the PTP_SYS_OFFSET_EXTENDED_ATTRS ioctl. This enables applications to retrieve PHC timestamps with quality attributes through the standard PTP ioctl interface. The ENA device currently reports only error_bound. clock_status and timescale attributes are set to default values. Signed-off-by: Amit Bernstein Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_phc.c | 59 +++++++++++++++++++---- 1 file changed, 49 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_phc.c b/drivers/net/ethernet/amazon/ena/ena_phc.c index 2bcb5af..2ce5d45 100644 --- a/drivers/net/ethernet/amazon/ena/ena_phc.c +++ b/drivers/net/ethernet/amazon/ena/ena_phc.c @@ -25,6 +25,44 @@ static int ena_phc_feature_enable(struct ptp_clock_info *clock_info, return -EOPNOTSUPP; } +static int ena_phc_gettimexattrs64(struct ptp_clock_info *clock_info, + struct timespec64 *ts, + struct ptp_system_timestamp *sts, + struct ptp_clock_attributes *att) +{ + struct ena_phc_info *phc_info = + container_of(clock_info, struct ena_phc_info, clock_info); + u32 error_bound_nsec; + unsigned long flags; + u64 timestamp_nsec; + int rc; + + spin_lock_irqsave(&phc_info->lock, flags); + + ptp_read_system_prets(sts); + + rc = ena_com_phc_get_timestamp(phc_info->adapter->ena_dev, + ×tamp_nsec, + &error_bound_nsec); + + ptp_read_system_postts(sts); + + spin_unlock_irqrestore(&phc_info->lock, flags); + + if (rc) + return rc; + + *ts = ns_to_timespec64(timestamp_nsec); + + if (att) { + att->error_bound = error_bound_nsec; + att->status = PTP_CLOCK_STATUS_UNKNOWN; + att->timescale = PTP_TIMESCALE_UNKNOWN; + } + + return 0; +} + static int ena_phc_gettimex64(struct ptp_clock_info *clock_info, struct timespec64 *ts, struct ptp_system_timestamp *sts) @@ -62,16 +100,17 @@ static int ena_phc_settime64(struct ptp_clock_info *clock_info, } static struct ptp_clock_info ena_ptp_clock_info = { - .owner = THIS_MODULE, - .n_alarm = 0, - .n_ext_ts = 0, - .n_per_out = 0, - .pps = 0, - .adjtime = ena_phc_adjtime, - .adjfine = ena_phc_adjfine, - .gettimex64 = ena_phc_gettimex64, - .settime64 = ena_phc_settime64, - .enable = ena_phc_feature_enable, + .owner = THIS_MODULE, + .n_alarm = 0, + .n_ext_ts = 0, + .n_per_out = 0, + .pps = 0, + .adjtime = ena_phc_adjtime, + .adjfine = ena_phc_adjfine, + .gettimexattrs64 = ena_phc_gettimexattrs64, + .gettimex64 = ena_phc_gettimex64, + .settime64 = ena_phc_settime64, + .enable = ena_phc_feature_enable, }; /* Enable/Disable PHC by the kernel, affects on the next init flow */ -- 2.47.3