From: Eric Dumazet <edumazet@google.com>
To: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>
Cc: Ido Schimmel <idosch@nvidia.com>,
David Ahern <dsahern@kernel.org>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
Eric Dumazet <edumazet@google.com>
Subject: [PATCH net-next] ip6mr: plug drop_reason to ip6mr_cache_report()
Date: Thu, 30 Apr 2026 07:40:04 +0000 [thread overview]
Message-ID: <20260430074004.4133602-1-edumazet@google.com> (raw)
- Check mrt->mroute_sk earlier in the function.
- Use sock_queue_rcv_skb_reason() instead of sock_queue_rcv_skb().
- Use sk_skb_reason_drop() instead of kfree_skb().
Note that we return -ENOMEM if sock_queue_rcv_skb_reason() failed,
as the precise error is not really needed for callers.
- Remove one net_warn_ratelimited().
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
net/ipv6/ip6mr.c | 22 ++++++++++------------
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c
index 85010ff21c981913e2a5e6096819d55c91f5d714..9d748f4c44e97046fa5acae5042f8bd31e13b66d 100644
--- a/net/ipv6/ip6mr.c
+++ b/net/ipv6/ip6mr.c
@@ -1063,10 +1063,14 @@ static void ip6mr_cache_resolve(struct net *net, struct mr_table *mrt,
static int ip6mr_cache_report(const struct mr_table *mrt, struct sk_buff *pkt,
mifi_t mifi, int assert)
{
+ enum skb_drop_reason reason;
struct sock *mroute6_sk;
struct sk_buff *skb;
struct mrt6msg *msg;
- int ret;
+
+ mroute6_sk = rcu_dereference(mrt->mroute_sk);
+ if (!mroute6_sk)
+ return -EINVAL;
#ifdef CONFIG_IPV6_PIMSM_V2
if (assert == MRT6MSG_WHOLEPKT || assert == MRT6MSG_WRMIFWHOLE)
@@ -1136,23 +1140,17 @@ static int ip6mr_cache_report(const struct mr_table *mrt, struct sk_buff *pkt,
skb->ip_summed = CHECKSUM_UNNECESSARY;
}
- mroute6_sk = rcu_dereference(mrt->mroute_sk);
- if (!mroute6_sk) {
- kfree_skb(skb);
- return -EINVAL;
- }
-
mrt6msg_netlink_event(mrt, skb);
/* Deliver to user space multicast routing algorithms */
- ret = sock_queue_rcv_skb(mroute6_sk, skb);
+ reason = sock_queue_rcv_skb_reason(mroute6_sk, skb);
- if (ret < 0) {
- net_warn_ratelimited("mroute6: pending queue full, dropping entries\n");
- kfree_skb(skb);
+ if (reason) {
+ sk_skb_reason_drop(mroute6_sk, skb, reason);
+ return -ENOMEM;
}
- return ret;
+ return 0;
}
/* Queue a packet for resolution. It gets locked cache entry! */
--
2.54.0.545.g6539524ca2-goog
next reply other threads:[~2026-04-30 7:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 7:40 Eric Dumazet [this message]
2026-04-30 13:37 ` [PATCH net-next] ip6mr: plug drop_reason to ip6mr_cache_report() Ido Schimmel
2026-05-02 0:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260430074004.4133602-1-edumazet@google.com \
--to=edumazet@google.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox