From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9ABA43FE65D; Thu, 30 Apr 2026 09:46:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777542414; cv=none; b=jwtd0xbA8UHdZt/YDvFvTJN3bwkGBPgFCuy71dvcX3I2WyneTXASn5nepkFldYFONNG2SMGjN7YnWZsPjTTlb8tSsrC7TtKprEgcWQc8kjnOIMBUYPkMzrQIrrPLryB+FD2QN7e9+ZnLDVexw9l0KGRofGBwbexFkkmjY4AVgoE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777542414; c=relaxed/simple; bh=/HBM1v6M04Z+Jc0mYsEibM5D9jaupGjKj8gDCUGJ9xY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cvxhTDiPxt5K7psXcjwkLZLDRqy1VEawHhwt9BGrTn0NVe2UPNScLFTnDxQTbeeSM8+auhbsMsfQMoC/6gKe0rrPRN9v+0VCgg1W6aFz95WwSvzQfUJPcjDb+lozVZ5x6m2mXRKuF5Byh3N/vfVz/4J5ozS5tEPXWOxgtb1vu9M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=D/NggZxY; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="D/NggZxY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777542413; x=1809078413; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=/HBM1v6M04Z+Jc0mYsEibM5D9jaupGjKj8gDCUGJ9xY=; b=D/NggZxYybTb8cT3ktSaM93AEBCuHDT+ShglguWKK4+WfhSE2fR+uNKy 08VAgvCH1QG8pTMnQ8rcfiTyqHklpLo5itFdEugpFlFoIHfJqplFI+LLi JpmUbPzhHSACSZTDUY1VWAioGnFM+kG88Y+0iiqneEi/idB1+oXHm/NtN qj+QVHW7ScqLVCekZtinlwhwAZlFAcS6pWcYo9X89UDO5gfMRQ1/1NPby UufH2+Z9NdLkUmfoYpaSJ8LJ0G0WIKpuf83Ie9dwmb4vkBfl6yq8VTpx/ VqwhWJaKCsRMt/WslXCPwxS9oCNrEqajFXf6nuz0tTNPD4eBWHJ2FDR7F g==; X-CSE-ConnectionGUID: f3nB1acRQDKfmNxtMdhuFA== X-CSE-MsgGUID: xtwRB0NETV+kkyOE0EabUA== X-IronPort-AV: E=McAfee;i="6800,10657,11771"; a="82342583" X-IronPort-AV: E=Sophos;i="6.23,207,1770624000"; d="scan'208";a="82342583" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2026 02:46:52 -0700 X-CSE-ConnectionGUID: 59Py9SOzQTWl3mG6rX/Zlg== X-CSE-MsgGUID: N9nGTysXSpSRPoxcZo0z1w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,207,1770624000"; d="scan'208";a="272649754" Received: from gklab-003-001.igk.intel.com ([10.91.173.48]) by orviesa001.jf.intel.com with ESMTP; 30 Apr 2026 02:46:47 -0700 From: Grzegorz Nitka To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, poros@redhat.com, richardcochran@gmail.com, andrew+netdev@lunn.ch, przemyslaw.kitszel@intel.com, anthony.l.nguyen@intel.com, Prathosh.Satish@microchip.com, ivecera@redhat.com, jiri@resnulli.us, arkadiusz.kubalewski@intel.com, vadim.fedorenko@linux.dev, donald.hunter@gmail.com, horms@kernel.org, pabeni@redhat.com, kuba@kernel.org, davem@davemloft.net, edumazet@google.com, Grzegorz Nitka , Jiri Pirko , Aleksandr Loktionov Subject: [PATCH v7 net-next 2/8] dpll: allow registering FW-identified pin with a different DPLL Date: Thu, 30 Apr 2026 11:42:32 +0200 Message-Id: <20260430094238.987976-3-grzegorz.nitka@intel.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20260430094238.987976-1-grzegorz.nitka@intel.com> References: <20260430094238.987976-1-grzegorz.nitka@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Relax the (module, clock_id) equality requirement when registering a pin identified by firmware (pin->fwnode). Some platforms associate a FW-described pin with a DPLL instance that differs from the pin's (module, clock_id) tuple. For such pins, permit registration without requiring the strict match. Non-FW pins still require equality. Reviewed-by: Jiri Pirko Reviewed-by: Arkadiusz Kubalewski Reviewed-by: Aleksandr Loktionov Signed-off-by: Grzegorz Nitka --- drivers/dpll/dpll_core.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/dpll/dpll_core.c b/drivers/dpll/dpll_core.c index cbb635db4321..afe4552bdcd4 100644 --- a/drivers/dpll/dpll_core.c +++ b/drivers/dpll/dpll_core.c @@ -883,11 +883,21 @@ dpll_pin_register(struct dpll_device *dpll, struct dpll_pin *pin, return -EINVAL; mutex_lock(&dpll_lock); - if (WARN_ON(!(dpll->module == pin->module && - dpll->clock_id == pin->clock_id))) + + /* + * For pins identified via firmware (pin->fwnode), allow registration + * even if the pin's (module, clock_id) differs from the target DPLL. + * For non-fwnode pins, require a strict (module, clock_id) match. + */ + if (!pin->fwnode && + WARN_ON_ONCE(dpll->module != pin->module || + dpll->clock_id != pin->clock_id)) { ret = -EINVAL; - else - ret = __dpll_pin_register(dpll, pin, ops, priv, NULL); + goto out_unlock; + } + + ret = __dpll_pin_register(dpll, pin, ops, priv, NULL); +out_unlock: mutex_unlock(&dpll_lock); return ret; -- 2.39.3