From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: linux-phy@lists.infradead.org
Cc: Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-can@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-riscv@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
spacemit@lists.linux.dev, UNGLinuxDriver@microchip.com,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Manivannan Sadhasivam <mani@kernel.org>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Subject: [PATCH v7 phy-next 11/27] scsi: ufs: qcom: include missing <linux/interrupt.h>
Date: Thu, 30 Apr 2026 14:06:36 +0300 [thread overview]
Message-ID: <20260430110652.558622-12-vladimir.oltean@nxp.com> (raw)
In-Reply-To: <20260430110652.558622-1-vladimir.oltean@nxp.com>
This driver uses devm_request_irq() without including <linux/interrupt.h>
by itself, which would lead to build failures if the headers providing
this transitively were to stop providing it.
On aarch64, we can see, using KCFLAGS='-H' make drivers/ufs/host/ufs-qcom.o,
that the inclusion path is:
drivers/ufs/host/ufs-qcom.c
-> include/linux/acpi.h
-> arch/arm64/include/asm/acpi.h
-> include/linux/efi.h
-> include/linux/rtc.h
-> include/linux/interrupt.h
Whereas on armv7, the situation is quite different. This architecture
has no CONFIG_ACPI symbol, and therefore on it, <linux/acpi.h> does not
include <asm/acpi.h>, and <linux/interrupt.h> is not provided that way.
It is provided, however, through this "fallback" path:
drivers/ufs/host/ufs-qcom.c
-> include/linux/phy/phy.h
-> include/linux/regulator/consumer.h
-> include/linux/suspend.h
-> include/linux/swap.h
-> include/linux/memcontrol.h
-> include/linux/writeback.h
-> include/linux/interrupt.h
The point is that <linux/phy/phy.h> will stop providing
<linux/regulator/consumer.h>, and this would break the transitive
include chain on armv7.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
Cc: Manivannan Sadhasivam <mani@kernel.org>
Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
v6->v7: collect tag from Martin
v5->v6: patch is new
---
drivers/ufs/host/ufs-qcom.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index 872e4effa60f..c7a02f6ef504 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -10,6 +10,7 @@
#include <linux/devfreq.h>
#include <linux/gpio/consumer.h>
#include <linux/interconnect.h>
+#include <linux/interrupt.h>
#include <linux/module.h>
#include <linux/of.h>
#include <linux/phy/phy.h>
--
2.34.1
next prev parent reply other threads:[~2026-04-30 11:07 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 11:06 [PATCH v7 phy-next 00/27] Split Generic PHY consumer and provider Vladimir Oltean
2026-04-30 11:06 ` [PATCH v7 phy-next 01/27] ata: add <linux/pm_runtime.h> where missing Vladimir Oltean
2026-04-30 11:06 ` [PATCH v7 phy-next 02/27] PCI: Add missing headers transitively included by <linux/phy/phy.h> Vladimir Oltean
2026-04-30 11:06 ` [PATCH v7 phy-next 03/27] usb: add " Vladimir Oltean
2026-04-30 11:06 ` [PATCH v7 phy-next 04/27] drm: add <linux/pm_runtime.h> where missing Vladimir Oltean
2026-04-30 11:06 ` [PATCH v7 phy-next 05/27] phy: " Vladimir Oltean
2026-04-30 11:06 ` [PATCH v7 phy-next 06/27] phy: spacemit: include missing <linux/phy/phy.h> Vladimir Oltean
2026-04-30 11:06 ` [PATCH v7 phy-next 07/27] net: lan969x: include missing <linux/of.h> Vladimir Oltean
2026-04-30 11:06 ` [PATCH v7 phy-next 08/27] PCI: Remove device links to PHY Vladimir Oltean
2026-05-04 7:57 ` Vladimir Oltean
2026-04-30 11:06 ` [PATCH v7 phy-next 09/27] scsi: ufs: exynos: stop poking into struct phy guts Vladimir Oltean
2026-05-04 11:48 ` Vladimir Oltean
2026-04-30 11:06 ` [PATCH v7 phy-next 10/27] scsi: ufs: qcom: keep parallel track of PHY power state Vladimir Oltean
2026-04-30 11:06 ` Vladimir Oltean [this message]
2026-04-30 11:06 ` [PATCH v7 phy-next 12/27] drm/rockchip: dw_hdmi: avoid direct dereference of phy->dev.of_node Vladimir Oltean
2026-04-30 11:06 ` [PATCH v7 phy-next 13/27] usb: host: tegra: " Vladimir Oltean
2026-05-05 9:39 ` Vladimir Oltean
2026-04-30 11:06 ` [PATCH v7 phy-next 14/27] usb: gadget: tegra-xudc: " Vladimir Oltean
2026-05-05 9:34 ` Vladimir Oltean
2026-04-30 11:06 ` [PATCH v7 phy-next 15/27] phy: move provider API out of public <linux/phy/phy.h> Vladimir Oltean
2026-05-05 9:30 ` Vladimir Oltean
2026-04-30 11:06 ` [PATCH v7 phy-next 16/27] phy: make phy_get_mode(), phy_(get|set)_bus_width() NULL tolerant Vladimir Oltean
2026-04-30 11:06 ` [PATCH v7 phy-next 17/27] phy: introduce phy_get_max_link_rate() helper for consumers Vladimir Oltean
2026-04-30 11:59 ` Geert Uytterhoeven
2026-04-30 13:14 ` Vladimir Oltean
2026-04-30 11:06 ` [PATCH v7 phy-next 18/27] drm/rockchip: dsi: include PHY provider header Vladimir Oltean
2026-04-30 11:06 ` [PATCH v7 phy-next 19/27] drm: bridge: cdns-mhdp8546: use consumer API for getting PHY bus width Vladimir Oltean
2026-04-30 11:06 ` [PATCH v7 phy-next 20/27] media: sunxi: a83-mips-csi2: include PHY provider header Vladimir Oltean
2026-04-30 11:06 ` [PATCH v7 phy-next 21/27] net: renesas: rswitch: " Vladimir Oltean
2026-05-05 9:24 ` Vladimir Oltean
2026-04-30 11:06 ` [PATCH v7 phy-next 22/27] pinctrl: tegra-xusb: " Vladimir Oltean
2026-04-30 11:06 ` [PATCH v7 phy-next 23/27] power: supply: cpcap-charger: include missing <linux/property.h> Vladimir Oltean
2026-04-30 11:06 ` [PATCH v7 phy-next 24/27] phy: include PHY provider header (1/2) Vladimir Oltean
2026-04-30 11:06 ` [PATCH v7 phy-next 25/27] phy: include PHY provider header (2/2) Vladimir Oltean
2026-05-05 9:22 ` Vladimir Oltean
2026-04-30 11:06 ` [PATCH v7 phy-next 26/27] phy: remove temporary provider compatibility from consumer header Vladimir Oltean
2026-04-30 11:06 ` [PATCH v7 phy-next 27/27] MAINTAINERS: add regexes for linux-phy Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260430110652.558622-12-vladimir.oltean@nxp.com \
--to=vladimir.oltean@nxp.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox