From: Jakub Kicinski <kuba@kernel.org>
To: Eric Joyner <eric.joyner@amd.com>
Cc: <netdev@vger.kernel.org>, Brett Creeley <brett.creeley@amd.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next 3/5] ionic: Update ionic_if.h with new extra port stats structure
Date: Fri, 1 May 2026 16:40:53 -0700 [thread overview]
Message-ID: <20260501164053.23312056@kernel.org> (raw)
In-Reply-To: <20260501031555.43259-4-eric.joyner@amd.com>
On Thu, 30 Apr 2026 20:15:53 -0700 Eric Joyner wrote:
> @@ -2951,6 +2959,7 @@ union ionic_port_identity {
> * @sprom_page17: Extended Transceiver sprom, page 17
> * @rsvd: reserved byte(s)
> * @pb_stats: uplink pb drop stats
Looks like the removed field is left behind in the doc?
> + * @extra_stats: Extra port statistics data
> */
> struct ionic_port_info {
> union ionic_port_config config;
> @@ -2968,9 +2977,7 @@ struct ionic_port_info {
> };
> };
> u8 rsvd[376];
> -
> - /* pb_stats must start at 2k offset */
> - struct ionic_port_pb_stats pb_stats;
> + struct ionic_port_extra_stats extra_stats;
> };
next prev parent reply other threads:[~2026-05-01 23:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 3:15 [PATCH net-next 0/5] Expose more port stats to ethtool Eric Joyner
2026-05-01 3:15 ` [PATCH net-next 1/5] ionic: Small improvements in devcmd retry logic Eric Joyner
2026-05-01 23:37 ` Jakub Kicinski
2026-05-05 15:54 ` Eric Joyner
2026-05-01 3:15 ` [PATCH net-next 2/5] ionic: Report "link_down_events_phy" in ethtool statistics Eric Joyner
2026-05-01 23:39 ` Jakub Kicinski
2026-05-01 3:15 ` [PATCH net-next 3/5] ionic: Update ionic_if.h with new extra port stats structure Eric Joyner
2026-05-01 23:40 ` Jakub Kicinski [this message]
2026-05-01 3:15 ` [PATCH net-next 4/5] ionic: Report rx_bits_phy stat to ethtool Eric Joyner
2026-05-01 3:15 ` [PATCH net-next 5/5] ionic: Add .get_fec_stats ethtool handler Eric Joyner
2026-05-01 23:41 ` Jakub Kicinski
2026-05-05 13:54 ` Vadim Fedorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260501164053.23312056@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.joyner@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox