From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A64876FC5 for ; Fri, 1 May 2026 23:41:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777678903; cv=none; b=BVTgvXgJ5iVSF2CWtnm3MP5ZQN1EvHKJ1C4bo8xJeeCMALMjni7q1uiIRtB6mkAmDCoUI2JcLcGuraCCOD9s9I4zFVunWmIaay5Fg8vHkSFZDZK1RHtBXx8acmN8ONjsPV32ekT1cTFLWtVICS+kPqEkC43yaXB5GHzG7zlmxPA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777678903; c=relaxed/simple; bh=lhpeol+0ulG+Ef1czwz3jozMm0LyTrPVVBHkFeQSGrg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KlSuM4ewWGifW6CU0LF8QWbom2lDramFL/c71ZC+kQRPxWKticPgXaG/o9g4L9n0H4V524V2uHolG48Sp8S7f8BQC5X4JwILHIhtTQWtN4ZVa87fzU56MecNYhxNpWUldg6x5K7RZxxlIcLeNpfTRtjo9lMDCkPFTFF+mZkAZ5A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RCRg68/u; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RCRg68/u" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B892C2BCB8; Fri, 1 May 2026 23:41:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777678903; bh=lhpeol+0ulG+Ef1czwz3jozMm0LyTrPVVBHkFeQSGrg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RCRg68/upk468E2gh5yQVI1nCflGF0F/fV9fTB+yCKPZaF20fXKzxhnO7aTc7JIh3 jKxUOmZNIRD+xc3F6XjUtL7PkTLpMAdqqgLNS7ZnwgqqSweEemttaUiwPP7fx8SONL 2sRUqy/DpFo+0CzG1Cv5J+N3qdlCjz5dv5vl9d5+JtIZUNuddgiE5cpqtVRSnFmMQZ 4vpweih0Ow8nswPbWK13gQWecBTi7ry7gY2OMeosY2Zj7rhKYQ91J3XAbtuVczwCtD 6+CQ4An6ah1WiJTJWEva+SYzbApVGmxE4pyldJcs+J+s3yUAUdWlOEoyFde2/zobIa ebJRpIkTEWmOw== Date: Fri, 1 May 2026 16:41:42 -0700 From: Jakub Kicinski To: Eric Joyner Cc: , Brett Creeley , Andrew Lunn , "David S. Miller" , "Eric Dumazet" , Paolo Abeni Subject: Re: [PATCH net-next 5/5] ionic: Add .get_fec_stats ethtool handler Message-ID: <20260501164142.77cb73e7@kernel.org> In-Reply-To: <20260501031555.43259-6-eric.joyner@amd.com> References: <20260501031555.43259-1-eric.joyner@amd.com> <20260501031555.43259-6-eric.joyner@amd.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 30 Apr 2026 20:15:55 -0700 Eric Joyner wrote: > Several FEC error statistics being collected can be reported in a > dedicated ethtool callback for FEC errors, so implement the handler that > does so. This includes 802.3ck FEC histogram data that some newer > hardware collects. sparse says: drivers/net/ethernet/pensando/ionic/ionic_ethtool.c:449:37: warning: incorrect type in assignment (different base types) drivers/net/ethernet/pensando/ionic/ionic_ethtool.c:449:37: expected unsigned long long [usertype] sum drivers/net/ethernet/pensando/ionic/ionic_ethtool.c:449:37: got restricted __le64 const