Re: [PATCH net-next 2/3] macvlan: Do not transfer operational state when protodown is enabled

Jakub Kicinski
2026-05-05T00:57:01Z

On Sun, 3 May 2026 21:19:34 +0300 Ido Schimmel wrote:
> On Fri, May 01, 2026 at 06:09:48PM -0700, Jakub Kicinski wrote:
> > On Wed, 29 Apr 2026 15:46:23 +0300 Ido Schimmel wrote:
> > > - list_for_each_entry(vlan, &port->vlans, list)
> > > + list_for_each_entry(vlan, &port->vlans, list) {
> > > + if (vlan->dev->proto_down)
> > > + continue;
> > > netif_stacked_transfer_operstate(vlan->lowerdev,
> > > vlan->dev);
> >
> > Doesn't feel particularly macvlan-specific?
> > Other simple upper devs don't support protodown
> > but when they do presumably they'll have to add
> > this exact condition, too, so why not add it in
> > netif_stacked_transfer_operstate()?
>
> It seemed more consistent with patch #1 that invokes
> netif_stacked_transfer_operstate() from the driver. I can move it to the
> core in v2 [1] assuming we go for a solution that doesn't involve the
> driver at all.
>
> [1] https://github.com/idosch/linux/commit/1d86acbf0affc9004fad79820bbb2172aeb305a4.patch

👍