Re: [PATCH net-next 2/3] macvlan: Do not transfer operational state when protodown is enabled

Jakub Kicinski
2026-05-02T01:09:50Z

On Wed, 29 Apr 2026 15:46:23 +0300 Ido Schimmel wrote:
> - list_for_each_entry(vlan, &port->vlans, list)
> + list_for_each_entry(vlan, &port->vlans, list) {
> + if (vlan->dev->proto_down)
> + continue;
> netif_stacked_transfer_operstate(vlan->lowerdev,
> vlan->dev);

Doesn't feel particularly macvlan-specific?
Other simple upper devs don't support protodown
but when they do presumably they'll have to add
this exact condition, too, so why not add it in
netif_stacked_transfer_operstate()?