From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f173.google.com (mail-dy1-f173.google.com [74.125.82.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB9163A960E for ; Sun, 3 May 2026 06:19:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777789157; cv=none; b=O2V6jnBHBg5aSPUdMK7fCKakL+WMCBlnWDo3CJfYGzQ8i7x4vep7tm6i8c8YXHDq9TyexSmL+y9difGRLLbBVkeHlFj+w4GEB6tui8etwMnzpeLn8qBCApc39uYdETTUWjYhWz6atKFO6ARQKnaLxCwi6VXP5qNvRRhQ4obMKgs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777789157; c=relaxed/simple; bh=759b3UlnQOfdThqdxyzLJBkM1Zn0d5oNnJgG7T0QMAE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=I8GPNclwRpqNM8O0orMuA0G0AyEdZJUmHmJQHXYKJDDSUvLXeq0p6RfHZ7d74J+T1WL83umBMZrDJiv99+oqIaJccGq2wnwXYdenyNLbQ+z4fyotv2sbBXOWRRCZfw5DII9rYudhZSI936Mw+/G+SBMht+ZZhuQvYix8xA6A9e0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=svYT/tc3; arc=none smtp.client-ip=74.125.82.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="svYT/tc3" Received: by mail-dy1-f173.google.com with SMTP id 5a478bee46e88-2f0d3e07e30so1657117eec.0 for ; Sat, 02 May 2026 23:19:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777789155; x=1778393955; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FCCW3r7fnfxS+0XOPGZkhixJ6vMaqJcN4CAaFxI1VNw=; b=svYT/tc3yM4NZLQtuyjme6l302KdWx20E4GCyzG42jV/Fzq/c3mlt7uLBBy89SWRwz A8zUM2ugd+VNst3NlbYrLy7piE39yagO87uZYA+zXi7nC/VYlEKF7sDj8ELajdNT8DHL P4D/XBeYxxyTauiK67ZfZbPLS1xwywHXneXKt73xGElSPGriSv7joQMrvDvPuiyWCGpG fI0+Wktu3Yc4bZaoXrNIIQwm/IBjvArgVrf5XM9/9jScCbf/8m2n9K3WEpyOmq3s3H+d RQfd18LImLmTWqACbugGq4voEh8S9Px9dS1D1pOB0HpH1JQndZsvZxgPDdyme4SyBLDs X68A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777789155; x=1778393955; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=FCCW3r7fnfxS+0XOPGZkhixJ6vMaqJcN4CAaFxI1VNw=; b=NoEggNNPnUkR85zlmUFObVovZsbt9aKFK2/6YmhU5a3OVKjqEc3g8/uHJKGXITwJJT juS9ls6WxtUV7F0tYbdwvzNQF1iYi7itDkZ9YJa2pqGHO+pm13r1O/wcfzT5wz50oeBg QFAER2Z/GasLMgWlVlihUTWeVS8G7ltHtA31GMyaBg0Dnf4Sw5fI0o3n3Lr8ZUJF4O97 AsvyZYHr31Gqa5Wcx0CnYqcnMJyRNVhzde96h2yA0iCA943Sun8iRY10ZqCiQZsf44WH VIfW0IEO7gzLRA8QpT+Ulu6mBDdxGaMFBkAbFXjwT+EHkcO3f/CCgJ3BktPQesAoa5w1 JfYw== X-Gm-Message-State: AOJu0YxpjmaHPeVs0IdfhpnywWcWFjhTs/d25y+e4100o+omfyCfMyBN lib/KcDgMzddKqTHazbqVe6TqCGsIqbanqu0gwUiNrkGU+WpGGMza6zH X-Gm-Gg: AeBDieuWza2zt0oqs+XjISefsMgpu9YU0a6Gc0+eL7J61pi4WlUHIKKVFmMwUxwe2fY ayzC4k9b6ybfm0jTulQdy/m5X17XhkvSEiGpq4Ls9LX3vj+pfGFEjlHS0cLgzdeCeRJFW3b8THh b7yZZXPh27gLNMLUOgZsgwlxwsXQq+WiyTYzgipUOTGD8gftDtIud2y0m2WWa3Rnv4FZLYLJMtP U2vDwROQspXMYkyapyCImi7OWDqc7Oe3Pnkz4ryyGWtxoIKcF1N4EoqpzPPmU2sNvJSBrIS1hWX Zw1niyjbsPApSOyexA4U/rkeS0VnBTkIfe01drSN/K9N9oeWE68rDXSdhaIGDABozHFWNs8vFUN d0S2aLhXBtDy/wEoZ1x0hD3gmzs05kD9Bv47AOR26URNTYSjBIfDk2ZIn3FePx8eQw/ulsBt5Fr ijQuzdoX+tm+CldZovpmLy3BgBkSsIZodxHTKIucjqNBlUk5j2Wg== X-Received: by 2002:a05:7300:dd05:b0:2f1:496c:94d1 with SMTP id 5a478bee46e88-2f1496cb57fmr336943eec.21.1777789155134; Sat, 02 May 2026 23:19:15 -0700 (PDT) Received: from tresc054937.tre-sc.gov.br ([187.65.210.13]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ee3bf6811fsm11100344eec.29.2026.05.02.23.19.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 May 2026 23:19:14 -0700 (PDT) From: Luiz Angelo Daros de Luca Date: Sun, 03 May 2026 03:18:28 -0300 Subject: [net-next PATCH v2 8/8] net: dsa: realtek: rtl8365mb: add bridge port flags Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260503-realtek_forward-v2-8-d064e220b391@gmail.com> References: <20260503-realtek_forward-v2-0-d064e220b391@gmail.com> In-Reply-To: <20260503-realtek_forward-v2-0-d064e220b391@gmail.com> To: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Linus Walleij , =?utf-8?q?Alvin_=C5=A0ipraga?= , Yury Norov , Rasmus Villemoes , Russell King Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luiz Angelo Daros de Luca X-Mailer: b4 0.15.2 From: Alvin Šipraga Implement support for bridge port flags to control learning and flooding behavior. This patch maps hardware functionalities to the following bridge flags: - BR_LEARNING - BR_FLOOD - BR_MCAST_FLOOD - BR_BCAST_FLOOD By default, all flooding types are enabled during port setup to ensure standard bridge behavior. Co-developed-by: Alvin Šipraga Signed-off-by: Alvin Šipraga Signed-off-by: Luiz Angelo Daros de Luca --- drivers/net/dsa/realtek/realtek.h | 8 +++ drivers/net/dsa/realtek/rtl8365mb_main.c | 69 +++++++++++++++++++++ drivers/net/dsa/realtek/rtl83xx.c | 100 +++++++++++++++++++++++++++++++ drivers/net/dsa/realtek/rtl83xx.h | 4 ++ 4 files changed, 181 insertions(+) diff --git a/drivers/net/dsa/realtek/realtek.h b/drivers/net/dsa/realtek/realtek.h index ef2d3ddfef60..e78113f050dc 100644 --- a/drivers/net/dsa/realtek/realtek.h +++ b/drivers/net/dsa/realtek/realtek.h @@ -140,6 +140,14 @@ struct realtek_ops { int (*l2_del_mc)(struct realtek_priv *priv, int port, const unsigned char addr[ETH_ALEN], u16 vid); int (*l2_flush)(struct realtek_priv *priv, int port, u16 vid); + int (*port_set_learning)(struct realtek_priv *priv, int port, + bool enable); + int (*port_set_ucast_flood)(struct realtek_priv *priv, int port, + bool enable); + int (*port_set_mcast_flood)(struct realtek_priv *priv, int port, + bool enable); + int (*port_set_bcast_flood)(struct realtek_priv *priv, int port, + bool enable); int (*phy_read)(struct realtek_priv *priv, int phy, int regnum); int (*phy_write)(struct realtek_priv *priv, int phy, int regnum, u16 val); diff --git a/drivers/net/dsa/realtek/rtl8365mb_main.c b/drivers/net/dsa/realtek/rtl8365mb_main.c index 1b8034311b17..7c296f6a0a05 100644 --- a/drivers/net/dsa/realtek/rtl8365mb_main.c +++ b/drivers/net/dsa/realtek/rtl8365mb_main.c @@ -304,6 +304,21 @@ #define RTL8365MB_MSTI_CTRL_PORT_STATE_MASK(_physport) \ (0x3 << RTL8365MB_MSTI_CTRL_PORT_STATE_OFFSET((_physport))) +/* Unknown unicast DA flooding port mask */ +#define RTL8365MB_UNKNOWN_UNICAST_FLOODING_PMASK_REG 0x0890 +#define RTL8365MB_UNKNOWN_UNICAST_FLOODING_PMASK_MASK 0x07FF + +/* Unknown multicast DA flooding port mask */ +#define RTL8365MB_UNKNOWN_MULTICAST_FLOODING_PMASK_REG 0x0891 +#define RTL8365MB_UNKNOWN_MULTICAST_FLOODING_PMASK_MASK 0x07FF + +/* Broadcast flooding port mask */ +#define RTL8365MB_UNKNOWN_BROADCAST_FLOODING_PMASK_REG 0x0892 +#define RTL8365MB_UNKNOWN_BROADCAST_FLOODING_PMASK_MASK 0x07FF + +#define RTL8365MB_SUPPORTED_BRIDGE_FLAGS \ + (BR_LEARNING | BR_FLOOD | BR_MCAST_FLOOD | BR_BCAST_FLOOD) + /* Miscellaneous port configuration register, incl. VLAN egress mode */ #define RTL8365MB_PORT_MISC_CFG_REG_BASE 0x000E #define RTL8365MB_PORT_MISC_CFG_REG(_p) \ @@ -1450,6 +1465,49 @@ static int rtl8365mb_port_set_learning(struct realtek_priv *priv, int port, enable ? RTL8365MB_LEARN_LIMIT_MAX : 0); } +static int rtl8365mb_port_set_ucast_flood(struct realtek_priv *priv, int port, + bool enable) +{ + /* Frames with unknown unicast DA will be flooded to a programmable + * port mask that by default includes all ports. Add or remove + * the specified port from this port mask accordingly. + */ + return regmap_update_bits(priv->map, + RTL8365MB_UNKNOWN_UNICAST_FLOODING_PMASK_REG, + BIT(port), enable ? BIT(port) : 0); +} + +static int rtl8365mb_port_set_mcast_flood(struct realtek_priv *priv, int port, + bool enable) +{ + return regmap_update_bits(priv->map, + RTL8365MB_UNKNOWN_MULTICAST_FLOODING_PMASK_REG, + BIT(port), enable ? BIT(port) : 0); +} + +static int rtl8365mb_port_set_bcast_flood(struct realtek_priv *priv, int port, + bool enable) +{ + return regmap_update_bits(priv->map, + RTL8365MB_UNKNOWN_BROADCAST_FLOODING_PMASK_REG, + BIT(port), enable ? BIT(port) : 0); +} + +static int rtl8365mb_port_pre_bridge_flags(struct dsa_switch *ds, int port, + struct switchdev_brport_flags flags, + struct netlink_ext_ack *extack) +{ + struct realtek_priv *priv = ds->priv; + + dev_dbg(priv->dev, "pre_bridge_flags port:%d flags:%lx supported:%lx", + port, flags.mask, RTL8365MB_SUPPORTED_BRIDGE_FLAGS); + + if (flags.mask & ~RTL8365MB_SUPPORTED_BRIDGE_FLAGS) + return -EINVAL; + + return 0; +} + static int rtl8365mb_port_set_efid(struct realtek_priv *priv, int port, u32 efid) { @@ -2280,6 +2338,11 @@ static int rtl8365mb_setup(struct dsa_switch *ds) if (ret) goto out_teardown_irq; + /* Enable all types of flooding */ + ret = rtl83xx_setup_port_flood_control(priv, dp->index); + if (ret) + goto out_teardown_irq; + /* Set up per-port private data */ p->priv = priv; p->index = dp->index; @@ -2447,6 +2510,8 @@ static const struct dsa_switch_ops rtl8365mb_switch_ops = { .phylink_get_caps = rtl8365mb_phylink_get_caps, .port_bridge_join = rtl83xx_port_bridge_join, .port_bridge_leave = rtl83xx_port_bridge_leave, + .port_pre_bridge_flags = rtl8365mb_port_pre_bridge_flags, + .port_bridge_flags = rtl83xx_port_bridge_flags, .port_stp_state_set = rtl8365mb_port_stp_state_set, .port_fast_age = rtl83xx_port_fast_age, .port_fdb_add = rtl83xx_port_fdb_add, @@ -2481,6 +2546,10 @@ static const struct realtek_ops rtl8365mb_ops = { .l2_add_mc = rtl8365mb_l2_add_mc, .l2_del_mc = rtl8365mb_l2_del_mc, .l2_flush = rtl8365mb_l2_flush, + .port_set_learning = rtl8365mb_port_set_learning, + .port_set_ucast_flood = rtl8365mb_port_set_ucast_flood, + .port_set_mcast_flood = rtl8365mb_port_set_mcast_flood, + .port_set_bcast_flood = rtl8365mb_port_set_bcast_flood, .phy_read = rtl8365mb_phy_read, .phy_write = rtl8365mb_phy_write, }; diff --git a/drivers/net/dsa/realtek/rtl83xx.c b/drivers/net/dsa/realtek/rtl83xx.c index 36158209a192..fc01eb262fcf 100644 --- a/drivers/net/dsa/realtek/rtl83xx.c +++ b/drivers/net/dsa/realtek/rtl83xx.c @@ -3,6 +3,7 @@ #include #include #include +#include #include "realtek.h" #include "rtl83xx.h" @@ -707,6 +708,105 @@ int rtl83xx_port_mdb_del(struct dsa_switch *ds, int port, } EXPORT_SYMBOL_NS_GPL(rtl83xx_port_mdb_del, "REALTEK_DSA"); +/** + * rtl83xx_port_bridge_flags() - set port bridge flags + * @ds: DSA switch instance + * @port: port index + * @flags: bridge port flags + * @extack: netlink extended ack for reporting errors + * + * This function handles setting bridge port flags like learning and flooding. + * + * Context: Can sleep. + * Return: 0 on success, negative value for failure. + */ +int rtl83xx_port_bridge_flags(struct dsa_switch *ds, int port, + struct switchdev_brport_flags flags, + struct netlink_ext_ack *extack) +{ + struct realtek_priv *priv = ds->priv; + int ret; + + if (flags.mask & BR_LEARNING) { + if (!priv->ops->port_set_learning) + return -EOPNOTSUPP; + + ret = priv->ops->port_set_learning(priv, port, + !!(flags.val & BR_LEARNING)); + if (ret) + return ret; + } + + if (flags.mask & BR_FLOOD) { + if (!priv->ops->port_set_ucast_flood) + return -EOPNOTSUPP; + + ret = priv->ops->port_set_ucast_flood(priv, port, + !!(flags.val & BR_FLOOD)); + if (ret) + return ret; + } + + if (flags.mask & BR_MCAST_FLOOD) { + if (!priv->ops->port_set_mcast_flood) + return -EOPNOTSUPP; + + ret = priv->ops->port_set_mcast_flood(priv, port, + !!(flags.val & BR_MCAST_FLOOD)); + if (ret) + return ret; + } + + if (flags.mask & BR_BCAST_FLOOD) { + if (!priv->ops->port_set_bcast_flood) + return -EOPNOTSUPP; + + ret = priv->ops->port_set_bcast_flood(priv, port, + !!(flags.val & BR_BCAST_FLOOD)); + if (ret) + return ret; + } + + return 0; +} +EXPORT_SYMBOL_NS_GPL(rtl83xx_port_bridge_flags, "REALTEK_DSA"); + +/** + * rtl83xx_setup_port_flood_control() - setup default flood control for a port + * @priv: realtek_priv pointer + * @port: port index + * + * This function enables flooding for a given port. + * + * Context: Can sleep. + * Return: 0 on success, negative value for failure. + */ +int rtl83xx_setup_port_flood_control(struct realtek_priv *priv, int port) +{ + int ret; + + if (priv->ops->port_set_ucast_flood) { + ret = priv->ops->port_set_ucast_flood(priv, port, true); + if (ret) + return ret; + } + + if (priv->ops->port_set_mcast_flood) { + ret = priv->ops->port_set_mcast_flood(priv, port, true); + if (ret) + return ret; + } + + if (priv->ops->port_set_bcast_flood) { + ret = priv->ops->port_set_bcast_flood(priv, port, true); + if (ret) + return ret; + } + + return 0; +} +EXPORT_SYMBOL_NS_GPL(rtl83xx_setup_port_flood_control, "REALTEK_DSA"); + MODULE_AUTHOR("Luiz Angelo Daros de Luca "); MODULE_AUTHOR("Linus Walleij "); MODULE_DESCRIPTION("Realtek DSA switches common module"); diff --git a/drivers/net/dsa/realtek/rtl83xx.h b/drivers/net/dsa/realtek/rtl83xx.h index dcb819fe567f..d86447121276 100644 --- a/drivers/net/dsa/realtek/rtl83xx.h +++ b/drivers/net/dsa/realtek/rtl83xx.h @@ -27,6 +27,10 @@ int rtl83xx_port_bridge_join(struct dsa_switch *ds, int port, struct netlink_ext_ack *extack); void rtl83xx_port_bridge_leave(struct dsa_switch *ds, int port, struct dsa_bridge bridge); +int rtl83xx_port_bridge_flags(struct dsa_switch *ds, int port, + struct switchdev_brport_flags flags, + struct netlink_ext_ack *extack); +int rtl83xx_setup_port_flood_control(struct realtek_priv *priv, int port); void rtl83xx_port_fast_age(struct dsa_switch *ds, int port); int rtl83xx_port_fdb_add(struct dsa_switch *ds, int port, -- 2.53.0