From: Jakub Kicinski <kuba@kernel.org>
To: Maciek Machnikowski <maciek@machnikowski.net>
Cc: netdev@vger.kernel.org, richardcochran@gmail.com,
milena.olech@intel.com, willemdebruijn.kernel@gmail.com,
andrew@lunn.ch, vadim.fedorenko@linux.dev, horms@kernel.org
Subject: Re: [PATCH v5 net-next 3/3] selftests:net: Implement ptp4l sync test using netdevsim
Date: Mon, 4 May 2026 10:07:53 -0700 [thread overview]
Message-ID: <20260504100753.7cc193cc@kernel.org> (raw)
In-Reply-To: <20260503074747.1321-4-maciek@machnikowski.net>
On Sun, 3 May 2026 09:47:47 +0200 Maciek Machnikowski wrote:
> Add PTP synchronization test using ptp4l and netdevsim.
>
> The test creates two netdevsim adapters, links them together
> and runs the ptp4l leader and ptp4l follower on two ends
> of the netdevsim link and waits for the follower to report the
> synchronized state (s2) in its output log.
>
> This implementation runs the test runs over IPv4 link.
Doesn't seem to pass on netdevsim for us:
# 41.13 [+40.95] # ptp4l follower did not reach locked state (s2) within 40s
# 41.13 [+0.00] # Follower log (last 10 lines): ptp4l[2179.605]: ioctl SIOCETHTOOL failed: Operation not supported | ptp4l[2179.607]: interface 'eth0' does not support requested timestamping mode | failed to create a clock
# 41.15 [+0.02] # Check| At /srv/vmksft/testing/wt-2/tools/testing/selftests/net/./ptp.py, line 173, in ptp_sync_test:
# 41.15 [+0.01] # Check| _run_ptp4l_wait_sync(nsimsv.ifname, nsimcl.ifname, nssv.name, nscl.name)
# 41.16 [+0.01] # Check| At /srv/vmksft/testing/wt-2/tools/testing/selftests/net/./ptp.py, line 99, in _run_ptp4l_wait_sync:
# 41.17 [+0.01] # Check| ksft_true(False, "PTP sync timeout")
# 41.17 [+0.00] # Check failed False does not eval to True PTP sync timeout
# 41.32 [+0.16] not ok 1 ptp.ptp_sync_test
# 41.33 [+0.00] # Totals: pass:0 fail:1 xfail:0 xpass:0 skip:0 error:0
Anything we need to do?
next prev parent reply other threads:[~2026-05-04 17:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-03 7:47 [PATCH v5 net-next 0/3] Implement PTP support in netdevsim Maciek Machnikowski
2026-05-03 7:47 ` [PATCH v5 net-next 1/3] ptp_mock: Expose ptp_clock_info to external drivers Maciek Machnikowski
2026-05-03 7:47 ` [PATCH v5 net-next 2/3] netdevsim: Implement basic ptp support Maciek Machnikowski
2026-05-03 7:47 ` [PATCH v5 net-next 3/3] selftests:net: Implement ptp4l sync test using netdevsim Maciek Machnikowski
2026-05-04 17:07 ` Jakub Kicinski [this message]
2026-05-05 7:36 ` Maciek Machnikowski
2026-05-05 12:22 ` Andrew Lunn
2026-05-05 16:22 ` Maciek Machnikowski
2026-05-05 16:38 ` Vadim Fedorenko
2026-05-05 16:53 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260504100753.7cc193cc@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=horms@kernel.org \
--cc=maciek@machnikowski.net \
--cc=milena.olech@intel.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=vadim.fedorenko@linux.dev \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox