From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA042343D64 for ; Mon, 4 May 2026 12:32:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777897925; cv=none; b=cHtNXZ+ix8YwEjm668oULASAEII0r7k7V5ruoDfXFc4qICwNlMG2Yu5yy4O4FXlV2Ok6Qgq66bohF00svsIdy9htwwJxIh1xMpswu67gX8roIXzt9/Y0lQ8QjCGnvcJhIquQcoT3nEjQLbRJIjIry+3mRxg9dYm63Ub3O6D3ufk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777897925; c=relaxed/simple; bh=JvLuEHu2bzX+Z8ybm6nqQT+8KAh46mpFQ2UfmGvbRdU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UG46EIACBLttXdTe3YlmZGfWKNEnzopMRnrVO1ep65zlDb06rNzKSU3SaR1oO+cq2O6N4FM6hTUYl3xLsMdIvY896uJS5/BfhmmG0e2uz4hrQkJcpfgYMsparWwQROXZzDQrio7U0B5g3ZSCJ8g3R6iCr5ApuumOSUJ21LZiGZE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=YlkFXnKG; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=vm4NxGlj; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=YlkFXnKG; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=vm4NxGlj; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="YlkFXnKG"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="vm4NxGlj"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="YlkFXnKG"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="vm4NxGlj" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 87D535BD3A; Mon, 4 May 2026 12:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777897917; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+8M2SbcRdOT+1NM/sR9pAi2A2vxPT4uORclMDC0b5Vs=; b=YlkFXnKGzBFU/TAIW0x3CRBsjkRutu/V8MknsSqENCYLa+OjVAL7fxaDeizCOeknsXFHNM BsyUoAjod6wh5xeOt8SjCLTZQ88bSWbRv89/c8iNAbg1pHlv+fnbbTiuxSX49sCRVB5HpJ qG6yKLGy9zmbLHsL9791NmmFlZ8kQGE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777897917; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+8M2SbcRdOT+1NM/sR9pAi2A2vxPT4uORclMDC0b5Vs=; b=vm4NxGljIyhl50ImUW+mg7vASAIzWm/NwRSrTHclUbB6KuZ4RgVHVTtOKJ1bTbDhV1u3Nx sivkjEpENjg0AiDQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777897917; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+8M2SbcRdOT+1NM/sR9pAi2A2vxPT4uORclMDC0b5Vs=; b=YlkFXnKGzBFU/TAIW0x3CRBsjkRutu/V8MknsSqENCYLa+OjVAL7fxaDeizCOeknsXFHNM BsyUoAjod6wh5xeOt8SjCLTZQ88bSWbRv89/c8iNAbg1pHlv+fnbbTiuxSX49sCRVB5HpJ qG6yKLGy9zmbLHsL9791NmmFlZ8kQGE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777897917; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+8M2SbcRdOT+1NM/sR9pAi2A2vxPT4uORclMDC0b5Vs=; b=vm4NxGljIyhl50ImUW+mg7vASAIzWm/NwRSrTHclUbB6KuZ4RgVHVTtOKJ1bTbDhV1u3Nx sivkjEpENjg0AiDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E7CD7593A3; Mon, 4 May 2026 12:31:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 8MejNbyR+GnBXQAAD6G6ig (envelope-from ); Mon, 04 May 2026 12:31:56 +0000 From: Fernando Fernandez Mancera To: netdev@vger.kernel.org Cc: linux-kselftest@vger.kernel.org, horms@kernel.org, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, idosch@nvidia.com, dsahern@kernel.org, Fernando Fernandez Mancera Subject: [PATCH 2/3 net-next v3] ipv4: handle devconf post-set actions on netlink updates Date: Mon, 4 May 2026 14:31:42 +0200 Message-ID: <20260504123143.6284-2-fmancera@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260504123143.6284-1-fmancera@suse.de> References: <20260504123143.6284-1-fmancera@suse.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -6.80 X-Spam-Level: X-Spamd-Result: default: False [-6.80 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_SEVEN(0.00)[10]; URIBL_BLOCKED(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:email]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:email]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[] X-Spam-Flag: NO When IPv4 device configuration parameters are updated via netlink, the kernel currently only updates the value. This bypasses several post-modification actions that occur when these same parameters are updated via sysctl, such as flushing the routing cache or emitting RTM_NEWNETCONF notifications. This patch addresses the inconsistency by calling the devinet_conf_post_set() helper inside inet_set_link_af(). If a flush is required, we defer it until the netlink attribute parsing loop completes. This ensures consistent behavior and side-effects for devconf changes, regardless of whether they are initiated via sysctl or netlink. Signed-off-by: Fernando Fernandez Mancera --- v2: handled forwarding notification and disabling LRO v3: no changes --- net/ipv4/devinet.c | 29 +++++++++++++++++++++++++++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index 8300516fb38f..a35b72662e43 100644 --- a/net/ipv4/devinet.c +++ b/net/ipv4/devinet.c @@ -2161,6 +2161,20 @@ static bool devinet_conf_post_set(struct net *net, struct ipv4_devconf *cnf, NETCONFA_IGNORE_ROUTES_WITH_LINKDOWN, ifindex, cnf); break; + case IPV4_DEVCONF_FORWARDING: + if (new == 1) { + /* it is safe to use container_of() because forwarding case + * is only used by the netlink path + */ + struct in_device *idev = container_of(cnf, struct in_device, cnf); + + netif_disable_lro(idev->dev); + } + + inet_netconf_notify_devconf(net, RTM_NEWNETCONF, + NETCONFA_FORWARDING, + ifindex, cnf); + return true; default: break; } @@ -2173,6 +2187,8 @@ static int inet_set_link_af(struct net_device *dev, const struct nlattr *nla, { struct in_device *in_dev = __in_dev_get_rtnl(dev); struct nlattr *a, *tb[IFLA_INET_MAX+1]; + struct net *net = dev_net(dev); + bool flush_cache = false; int rem; if (!in_dev) @@ -2182,8 +2198,17 @@ static int inet_set_link_af(struct net_device *dev, const struct nlattr *nla, return -EINVAL; if (tb[IFLA_INET_CONF]) { - nla_for_each_nested(a, tb[IFLA_INET_CONF], rem) - ipv4_devconf_set(in_dev, nla_type(a), nla_get_u32(a)); + nla_for_each_nested(a, tb[IFLA_INET_CONF], rem) { + int old_value = ipv4_devconf_get(in_dev, nla_type(a)); + int new_value = nla_get_u32(a); + + ipv4_devconf_set(in_dev, nla_type(a), new_value); + if (devinet_conf_post_set(net, &in_dev->cnf, nla_type(a), new_value, + old_value, dev->ifindex)) + flush_cache = true; + } + if (flush_cache) + rt_cache_flush(net); } return 0; -- 2.53.0