Re: [PATCH net v2 2/2] selftests/net: add packetdrill test for locked SO_RCVBUF SWS

Ankit Jain
2026-05-05T18:27:25Z

Thanks for the review.

> I do not see the SWS effect you want to avoid in the first place.
>
> This test is an ad-hoc test about your change, but I still do not see
> why recomputing tp->ratio every time the rcvmss is increased is an
> issue on loopback interface.

For the packetdrill script, it is taking more time. To actually show
the window dropping to 0, I have to write a long script with many
packets and application reads. This is because TCP does not shrink the
right edge of an already open window.

Since the C-code fix in Patch 1 is tested and working fine, should I
send v3 with just the code fix first? I can work on the packetdrill
script and send it later in a separate patch. Or should I wait and
send both together?

Kindly suggest how I should proceed.

Thanks,
Ankit