Re: [PATCH net 2/4] net: sparx5: fix sleep in atomic context in MAC table access

Daniel Machon
2026-05-05T18:51:16Z

> On Mon, 4 May 2026 16:43:43 +0200 Daniel Machon wrote:
> > sparx5_mact_learn() is called from .ndo_set_rx_mode with
> > netif_addr_lock_bh held, but takes sparx5->lock which is a mutex.
> > A mutex may block, which is not allowed from atomic context.
>
> Could you try to switch to the recently added ndo_set_rx_mode_async?
> We added it exactly because most drivers have to sleep / wait for FW
> to do something.

Interesting. That should get rid of the spinlock and readx_poll_timeout_atomic
conversions. I will try it out. Thanks.

/Daniel