From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CFC117C220 for ; Tue, 5 May 2026 00:16:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940177; cv=none; b=SVnNmhEnHBx9huB2xnojajbvFRmrOae5zRkHOyBCHUCT62xvHyy2liakVYe/iwazJmAwk6vp8RnmMX7e3LWv4umBE/N9WAGkmmFrcEFTgN1wFEeAmf/75tbVOMlrCq9qkxB/gKSmxNRvYfdKu98VVmKvTliStcbfv9wW0MTDUwc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940177; c=relaxed/simple; bh=N7Q0Ae6m6x6vh7LGHKXMsvlFaehBTgaWDd++H1tb+oU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EzJsKrFh7RdojIIEugoY6ibRM1vTdmd8hKTqRyF+dXzRbty1GcMgzz2SKWacFWKjqfrRNELOwZ4cVP9W6CuERiqFDAAHa6TCDSFRRSygvFDgr7uIuw0iERgve5ZsBcvU7PwLUs6FR10HEFAJQjUVxurut01uNZLaQXqPS0WbC6U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org; spf=pass smtp.mailfrom=networkplumber.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20251104.gappssmtp.com header.i=@networkplumber-org.20251104.gappssmtp.com header.b=j3/QywUO; arc=none smtp.client-ip=209.85.167.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20251104.gappssmtp.com header.i=@networkplumber-org.20251104.gappssmtp.com header.b="j3/QywUO" Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-479fc1fc048so3308452b6e.1 for ; Mon, 04 May 2026 17:16:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20251104.gappssmtp.com; s=20251104; t=1777940174; x=1778544974; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=0vW3wfKNDyblJFV7YdonZtH5qOl3Qb0KySHL6/x6bkk=; b=j3/QywUOuDHlyATUMzjMgKnuBKehTCZU+/zosTDSYX/MkBNC95u3WqG6j3DjR5/LIo 4iw/pjPZM9Ruz0L2Xl2bYasowVmd3B+i+p8Rq1SFxw3ordUQFnlH93tU5LevMPZ4MoMj SrbNjE+WgkbDRI4wFinqllpwp0c2h73nJYtW6OPuXZyuP+DbeYb5yz7Acfr70m31dYy1 vLzyl4LW3KYsgzrcEMzJ4ZCNifnlXGp5hrD674MdQ0SDKDE0q6UXqqzHEJ1+wDOjjTcm 158xMII/qVacOeoqLruwEYY8Hql9ZCHCXdYpURslhsX3hWTPzbk6BFnkQK/bqdepJi9D bRUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777940174; x=1778544974; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0vW3wfKNDyblJFV7YdonZtH5qOl3Qb0KySHL6/x6bkk=; b=mXEy5IBhaqAPgNJW9Sljq11UbGOAWMJtiBA9ZXd2kBcWZlxmrbRpf1PL6YzoEmH4mt wd43+prtwaQrNO4gT6+5hlPwmXH8uDjJOkQHnFjnDVIlxhSuysXqQESyYBjq3pguLrDo wQRCsqJ9FsCUJMY6FjBJYMH+UBD6d4WIpzgFRlGvi62GWQ6aRx/BwXyx6QNRusb0thGG 27R4B4KwBwKaE5+nxaxlDVnyRqbQUNpCycYU5GZnB6IBNRfrfX01a58+B42LsPE7oD/J SKEiiW/f76D1HMIxITBj/Akuamw0f/rDxjWVrF821r/PXPC92LT8LHd2t+Xh8bwVmGPh YVdg== X-Gm-Message-State: AOJu0YyRZyBvUTWH3hBQnQ7HxUaoupWSDr794BEX2Xi1N3kUzXxFzKkX E8nh8BMU9tR+13dUN5muU2JVPuisfWUG3KIMHOn6r/6DCWT4CqwL4cQazaNjUcC9JGmknMmShCz +rjNX X-Gm-Gg: AeBDieudMuwiVriSM4IwvfHAkjtrFGgmvqylC8J7DtZhG51tYSPMVUxgHQYxEhbEte3 S/F0l/mLz49v22vAjM/v+7FPTLy7A1MZXU7RmtK0QRyLFiU6lplxBZYyt2ylKrQ/kBte1K2W+yP LxsAvzuWCz6NvhNDX0COgmvU66TPpWUUyPzdbmNYV5mHIbiarzK6fGyhX3duJ9TnoJgvD0g2cxk 8aVxjRsjpqRRr7/Kj3O1Newx516frNb+cm4tGTVIlp+vcUZLxKXACJD1/3nJ7rHmTFXdAEjHtx4 qNoAeS2abFuOfCStxVqD1G9yYFnck0zSVI96p3F6Bohq82ru9WCzRcLNWKFmd3ZGIq9UAB24ngP SCGU0MmRifmlzUcpo8r9HxwZLZZ80H/VjQN8Kv5vvbgo64jM1PirdueyxNcxyQE7+mnlDjkXcTI H4AiykKv8iYcJpbdmxSW0e9YR+pEQSlWt3yl+Yko0O7VdKVQ== X-Received: by 2002:a05:6808:1b8d:b0:479:e96e:65b0 with SMTP id 5614622812f47-47e18250dc1mr572179b6e.10.1777940174531; Mon, 04 May 2026 17:16:14 -0700 (PDT) Received: from phoenix.local ([104.202.41.210]) by smtp.gmail.com with ESMTPSA id 5614622812f47-47c76986404sm7590602b6e.15.2026.05.04.17.16.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 17:16:14 -0700 (PDT) Date: Mon, 4 May 2026 17:16:11 -0700 From: Stephen Hemminger To: netdev@vger.kernel.org Cc: jhs@mojatatu.com, jiri@resnulli.us Subject: Re: [PATCH net-next v2 4/5] net/sched: netem: add per-impairment extended statistics Message-ID: <20260504171611.127dc06b@phoenix.local> In-Reply-To: <20260503195348.521225-5-stephen@networkplumber.org> References: <20260503195348.521225-1-stephen@networkplumber.org> <20260503195348.521225-5-stephen@networkplumber.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 3 May 2026 12:52:02 -0700 Stephen Hemminger wrote: > Adds new counters that keep track of when netem applied > impairments (delay, loss, corruption, duplication, reordering). > Add a struct tc_netem_xstats reported via TCA_STATS_APP so that > userspace (tc -s qdisc show) can display per-impairment counters. > > Use the WRITE_ONCE/READ_ONCE pattern to allow for lockless > qdisc usage. > > Accompanying iproute2 change is submitted separately. > > Signed-off-by: Stephen Hemminger > --- I don't know how to argue with Sashiko but it is wrong. It flags the counters as susceptible to torn reads but these are informational only counters and the new counters follow the pattern of Eric's other recent changes. False positive report.