Re: [RFC PATCH net-next 1/2] net: napi: Fix interrupts permanently disabled during busy poll

Jakub Kicinski
2026-04-29T00:38:45Z

On Tue, 28 Apr 2026 17:51:30 +0000 Dragos Tatulea wrote:
> + local_irq_save(flags);
> + hrtimer_start(&napi->timer, ns_to_ktime(timeout),
> + HRTIMER_MODE_REL_PINNED);
> clear_bit(NAPI_STATE_SCHED, &napi->state);
> + local_irq_restore(flags);

I don't think disabling IRQ is necessary?
Isn't it legal to clear the bit first then schedule the timer?
The timer does not own the napi instance.