From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E2F138E5F9 for ; Mon, 4 May 2026 23:01:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777935673; cv=none; b=u1u12DPYzzuHq0uVUnB2JbNJk0FD5aUQ+ETqtvVyiFy+69E+kXoLHkXux7VT0tFAjtpBo4kr2ql2gqwEzhcqvOcHKC7R/mNYdgJnpYt4p1NQodNYgef8ksXPGSMlRqrmGE86MBq6z0Wx1Fsp4LF7y5GnMT21FErxepk11SjzQic= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777935673; c=relaxed/simple; bh=A+XjeW7tZE67izRGKyTPNSOrHccrCN9tEASrUvgClys=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eBeCMXfBMiTgU1cwYaPOI/qjSI98Qkoc1x9ka/idRu1upFPTiFtgkGCQxoBP/NtMbUQCCxM2HXj9maH0G2lg2ete0JZUSl+rqqB+umhAv/S53dYTSqZOE1ieFNf1ZtyVLBmB+e3ebpQLx5skqZ4yvNjQybys15YD+643acPHVKI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SBIYl5M6; arc=none smtp.client-ip=209.85.128.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SBIYl5M6" Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-7bda2d8c219so546367b3.0 for ; Mon, 04 May 2026 16:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777935670; x=1778540470; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9kFHbvO6/5kr0hLADWvDpYBOPBLThYVA7oIPjyyLqck=; b=SBIYl5M6LFGFGcIWuQEO7nR0qn/3DREjYXC8kTbn9GHRM0yJM6Rlva7yE9mJA6xfxy z8cDShLEB4nNgCyWRajp35fcKF8kgePdYfvrem6D6nci99wREpspBuZVcaycfApqyjM2 0mJCLPlWFYA7pa9TXcEkHZwv1HubBtKXzrgsD5kz5V30BZJP/ipi8Id7tbSJ69bMbcV1 gwWpT4fY0eaeOy41TnkHRI5Ov8GYUsQD9nJ+IIU8iww1o+WAKKhzA7cn9JGNtcMlkPvT Q+aL7rMEwIl8EEtExDLEYze4zbm4FqU++gWc6Qh+xawhr4sNwU1Eo5mkSBH+W65MyDQD iPAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777935670; x=1778540470; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9kFHbvO6/5kr0hLADWvDpYBOPBLThYVA7oIPjyyLqck=; b=NAhNZMSL0TE2hKz1KymvktD3HQoSocUupojqpgU2gf049f6VZRtHAgqD5NBXyy3bDp Sz/CWZGf4sDDabtWYUS+bfdPS+eW1c6t7mtYTqu+1JhlmwvULC5C5bMW2W/XtGnUrYsf VckVGt/VdC5OTjCXeucCNiIMiatoBtddViAhVgaPIgyutldh1SBqmXRXA/MuYBZUbuS8 NSuAL4UQcHtl+gXXfk+eg5a7VjH/zoGBJNCNm7XZbrchhvJZSE3w/2ooV6mMEVZlm+nH kKTLHvCOc9dLzzkRfBjY1cpcR2eaAkB2Nr4ceiwZK1/QQ4DQ6l3qgKFCtQIkX+J5tXIn zGcw== X-Gm-Message-State: AOJu0YwZxQcVXtqO6Y/HLNeIMESEvEJ59TO+eLtxg371vC2rq5vAmmPz B02rtW3y4WjRosnrPkcQU7S7s7ISCflk/9k8xZPbH4V9sHHyzj4cg39uySNd7w== X-Gm-Gg: AeBDiev2+Z3gMPWCf0kQHChzY9fzAYG/MXD8RMwsZjp6dI1DAu8yG26OHmOgXdcx51n 2QnobkAA1BHJKW1BF39yYcxAr5f08AIRlGdhCp4JcemoWocfoJoYfyiPjf9HdfIUKc7MGF4ZsjX 2kWFBrisutfogZHiEBPk+ACoVivb/tESHTxlxPFSgBybs+qlhq8ZmKHdiUSlA0/+R5akU93G68F uUyH38LXT4kufpW5Dk8SfeuI5GX0DgGtXy8JKiuU4WN+FZOcPPq7lCMttnAI1jjVEApc9bZ5Jvp W2XZrI+goppBo5pDL4ZiCWT5z4G/wqF354gajmQNLhzSMffP0582cno0XeRPZPJucWPa5lRPRlC O6WmogNGVoIh/Pad5cuissBLXmHiqBvWqej7cAEiYDDtvQhpT9ML0dMjm87CrOKw0dR4FMgMVDv WzNPiqCnuu0Cqn/9euWXOCFeq8eAAw76yiglkadfER5AeMvA== X-Received: by 2002:a05:690c:3701:b0:79e:631e:67b with SMTP id 00721157ae682-7bd770b12a0mr78091887b3.4.1777935669967; Mon, 04 May 2026 16:01:09 -0700 (PDT) Received: from localhost ([2a03:2880:21ff:50::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7bd66019105sm56579097b3.0.2026.05.04.16.01.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 16:01:09 -0700 (PDT) From: Wei Wang To: netdev@vger.kernel.org, Jakub Kicinski , Daniel Zahka , Willem de Bruijn , David Wei , Andrew Lunn , "David S . Miller" , Eric Dumazet , Simon Horman , Paolo Abeni Cc: Wei Wang Subject: [PATCH v13 net-next 1/5] psp: add admin/non-admin version of psp_device_get_locked Date: Mon, 4 May 2026 16:00:51 -0700 Message-ID: <20260504230056.917415-2-weibunny.kernel@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260504230056.917415-1-weibunny.kernel@gmail.com> References: <20260504230056.917415-1-weibunny.kernel@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Wei Wang Introduce 2 versions of psp_device_get_locked: 1. psp_device_get_locked_admin(): This version is used for operations that would change the status of the psd, and are currently used for dev-set and key-rotation. 2. psp_device_get_locked(): This is the non-admin version, which are used for broader user issued operations including: dev-get, rx-assoc, tx-assoc, get-stats. Following commit will be implementing both of the checks. Signed-off-by: Wei Wang Reviewed-by: Daniel Zahka --- Documentation/netlink/specs/psp.yaml | 4 ++-- net/psp/psp-nl-gen.c | 4 ++-- net/psp/psp-nl-gen.h | 2 ++ net/psp/psp.h | 2 +- net/psp/psp_main.c | 7 +++++- net/psp/psp_nl.c | 33 ++++++++++++++++++++-------- 6 files changed, 37 insertions(+), 15 deletions(-) diff --git a/Documentation/netlink/specs/psp.yaml b/Documentation/netlink/specs/psp.yaml index bfcd6e4ecb85..e3b0fe296e8f 100644 --- a/Documentation/netlink/specs/psp.yaml +++ b/Documentation/netlink/specs/psp.yaml @@ -196,7 +196,7 @@ operations: - psp-versions-ena reply: attributes: [] - pre: psp-device-get-locked + pre: psp-device-get-locked-admin post: psp-device-unlock - name: dev-change-ntf @@ -216,7 +216,7 @@ operations: reply: attributes: - id - pre: psp-device-get-locked + pre: psp-device-get-locked-admin post: psp-device-unlock - name: key-rotate-ntf diff --git a/net/psp/psp-nl-gen.c b/net/psp/psp-nl-gen.c index 953309952cef..a71dd629aeab 100644 --- a/net/psp/psp-nl-gen.c +++ b/net/psp/psp-nl-gen.c @@ -71,7 +71,7 @@ static const struct genl_split_ops psp_nl_ops[] = { }, { .cmd = PSP_CMD_DEV_SET, - .pre_doit = psp_device_get_locked, + .pre_doit = psp_device_get_locked_admin, .doit = psp_nl_dev_set_doit, .post_doit = psp_device_unlock, .policy = psp_dev_set_nl_policy, @@ -80,7 +80,7 @@ static const struct genl_split_ops psp_nl_ops[] = { }, { .cmd = PSP_CMD_KEY_ROTATE, - .pre_doit = psp_device_get_locked, + .pre_doit = psp_device_get_locked_admin, .doit = psp_nl_key_rotate_doit, .post_doit = psp_device_unlock, .policy = psp_key_rotate_nl_policy, diff --git a/net/psp/psp-nl-gen.h b/net/psp/psp-nl-gen.h index 599c5f1c82f2..977355455395 100644 --- a/net/psp/psp-nl-gen.h +++ b/net/psp/psp-nl-gen.h @@ -17,6 +17,8 @@ extern const struct nla_policy psp_keys_nl_policy[PSP_A_KEYS_SPI + 1]; int psp_device_get_locked(const struct genl_split_ops *ops, struct sk_buff *skb, struct genl_info *info); +int psp_device_get_locked_admin(const struct genl_split_ops *ops, + struct sk_buff *skb, struct genl_info *info); int psp_assoc_device_get_locked(const struct genl_split_ops *ops, struct sk_buff *skb, struct genl_info *info); void diff --git a/net/psp/psp.h b/net/psp/psp.h index 9f19137593a0..0f9c4e4e52cb 100644 --- a/net/psp/psp.h +++ b/net/psp/psp.h @@ -14,7 +14,7 @@ extern struct xarray psp_devs; extern struct mutex psp_devs_lock; void psp_dev_free(struct psp_dev *psd); -int psp_dev_check_access(struct psp_dev *psd, struct net *net); +int psp_dev_check_access(struct psp_dev *psd, struct net *net, bool admin); void psp_nl_notify_dev(struct psp_dev *psd, u32 cmd); diff --git a/net/psp/psp_main.c b/net/psp/psp_main.c index 524978dfb8fd..b56a51d524f5 100644 --- a/net/psp/psp_main.c +++ b/net/psp/psp_main.c @@ -27,10 +27,15 @@ struct mutex psp_devs_lock; * psp_dev_check_access() - check if user in a given net ns can access PSP dev * @psd: PSP device structure user is trying to access * @net: net namespace user is in + * @admin: If true, only allow access from @psd's main device's netns, + * for admin operations like config changes and key rotation. + * If false, also allow access from network namespaces that have + * an associated device with @psd, for read-only and association + * management operations. * * Return: 0 if PSP device should be visible in @net, errno otherwise. */ -int psp_dev_check_access(struct psp_dev *psd, struct net *net) +int psp_dev_check_access(struct psp_dev *psd, struct net *net, bool admin) { if (dev_net(psd->main_netdev) == net) return 0; diff --git a/net/psp/psp_nl.c b/net/psp/psp_nl.c index 0cc744a6e1c9..b4f1b7f9b0c2 100644 --- a/net/psp/psp_nl.c +++ b/net/psp/psp_nl.c @@ -41,7 +41,8 @@ static int psp_nl_reply_send(struct sk_buff *rsp, struct genl_info *info) /* Device stuff */ static struct psp_dev * -psp_device_get_and_lock(struct net *net, struct nlattr *dev_id) +psp_device_get_and_lock(struct net *net, struct nlattr *dev_id, + bool admin) { struct psp_dev *psd; int err; @@ -56,7 +57,7 @@ psp_device_get_and_lock(struct net *net, struct nlattr *dev_id) mutex_lock(&psd->lock); mutex_unlock(&psp_devs_lock); - err = psp_dev_check_access(psd, net); + err = psp_dev_check_access(psd, net, admin); if (err) { mutex_unlock(&psd->lock); return ERR_PTR(err); @@ -65,17 +66,31 @@ psp_device_get_and_lock(struct net *net, struct nlattr *dev_id) return psd; } -int psp_device_get_locked(const struct genl_split_ops *ops, - struct sk_buff *skb, struct genl_info *info) +static int __psp_device_get_locked(const struct genl_split_ops *ops, + struct sk_buff *skb, struct genl_info *info, + bool admin) { if (GENL_REQ_ATTR_CHECK(info, PSP_A_DEV_ID)) return -EINVAL; info->user_ptr[0] = psp_device_get_and_lock(genl_info_net(info), - info->attrs[PSP_A_DEV_ID]); + info->attrs[PSP_A_DEV_ID], + admin); return PTR_ERR_OR_ZERO(info->user_ptr[0]); } +int psp_device_get_locked_admin(const struct genl_split_ops *ops, + struct sk_buff *skb, struct genl_info *info) +{ + return __psp_device_get_locked(ops, skb, info, true); +} + +int psp_device_get_locked(const struct genl_split_ops *ops, + struct sk_buff *skb, struct genl_info *info) +{ + return __psp_device_get_locked(ops, skb, info, false); +} + void psp_device_unlock(const struct genl_split_ops *ops, struct sk_buff *skb, struct genl_info *info) @@ -160,7 +175,7 @@ static int psp_nl_dev_get_dumpit_one(struct sk_buff *rsp, struct netlink_callback *cb, struct psp_dev *psd) { - if (psp_dev_check_access(psd, sock_net(rsp->sk))) + if (psp_dev_check_access(psd, sock_net(rsp->sk), false)) return 0; return psp_nl_dev_fill(psd, rsp, genl_info_dump(cb)); @@ -310,7 +325,7 @@ int psp_assoc_device_get_locked(const struct genl_split_ops *ops, */ mutex_lock(&psd->lock); if (!psp_dev_is_registered(psd) || - psp_dev_check_access(psd, genl_info_net(info))) { + psp_dev_check_access(psd, genl_info_net(info), false)) { mutex_unlock(&psd->lock); psp_dev_put(psd); psd = NULL; @@ -334,7 +349,7 @@ int psp_assoc_device_get_locked(const struct genl_split_ops *ops, psp_dev_put(psd); } else { - psd = psp_device_get_and_lock(genl_info_net(info), id); + psd = psp_device_get_and_lock(genl_info_net(info), id, false); if (IS_ERR(psd)) { err = PTR_ERR(psd); goto err_sock_put; @@ -577,7 +592,7 @@ static int psp_nl_stats_get_dumpit_one(struct sk_buff *rsp, struct netlink_callback *cb, struct psp_dev *psd) { - if (psp_dev_check_access(psd, sock_net(rsp->sk))) + if (psp_dev_check_access(psd, sock_net(rsp->sk), false)) return 0; return psp_nl_stats_fill(psd, rsp, genl_info_dump(cb)); -- 2.52.0