From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52F30290DBB; Tue, 5 May 2026 08:23:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777969395; cv=none; b=qTrq5Pb5iezsZqPpm3lFztpbE/aIUtY2dcNM47tK+54wz7f2LaULJDh7t8IRgYtr0dLF5ZHFp9QW07DNDnxbc+WCJKTcdvGfnoeRblGB/k+dHeKRg1aD9EdHnbVO+LXDhQjUqDGHzqX/uS1khh9jKNljAN/koVn7A8AXjf8/X9s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777969395; c=relaxed/simple; bh=Ind4ewbTlV0VMaMhRBhUOAJ51ivGX/THmUva9v/9gmM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=kRvZCEIrnjCbN5JiwF7v5lqE6uhexrnYPb7KHODKVHu6FXVChUvb2CmFQb8nxL8O9npYwwlRfDJ3DwFhbVMW7kjG6+R03JqdV+Kf9d6M36ra93cbgsrbvJWaEH3rGRC1RVfUmh9tuZQ0m2VfVTnaCPPxwqElfH0OVUI4D1TzmCk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=f2M9o2jP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="f2M9o2jP" Received: by smtp.kernel.org (Postfix) with ESMTPS id D07FFC2BCB9; Tue, 5 May 2026 08:23:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777969394; bh=Ind4ewbTlV0VMaMhRBhUOAJ51ivGX/THmUva9v/9gmM=; h=From:Date:Subject:To:Cc:Reply-To:From; b=f2M9o2jPkz+uTAfhKYX5YkSYI+7u87WX9J92R27Ny34tJVw2/einWFQVPGJzLRIV+ tJlEsetedtd67kB0cJTD9CSSmehibKuRitWy2gfFlmVbzb6aS1FS03MaGW3Cnx1sAH bCDKOOQRtgL40/GnDMd0xwv3Fn1vinkB/q/+18bfc7yrVy2khSL6vRLyvnJaTZvZf9 3m/lP0WJmdw533Q1AkefvNZlHfK5cvHq2goaCVqB1Ds2uxq+cOxVkOM7zGRA/W7pmV Q7kZfWHTBBkwuCI3mAatmXjH0z3XDA/CeBMp45ne7twljN7PJhQHhcEB0TtoggxfOd qjViqG+YX22fQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2EE3CD3430; Tue, 5 May 2026 08:23:14 +0000 (UTC) From: Abid Ali via B4 Relay Date: Tue, 05 May 2026 08:23:07 +0000 Subject: [PATCH RESEND] net: stmmac: fix RX DMA leak on TX alloc failure Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260505-stmmac-rx-desc-cleanup-v1-1-df85cd095ebc@gmail.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Abid Ali X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777969393; l=998; i=dev.taqnialabs@gmail.com; s=20260425; h=from:subject:message-id; bh=6KNXYVuQw7qzkBuKkHzTHDqB5iOSzE7NC8yleiDYCcg=; b=dzQlfnpwahC08WkpKQ0tTinR9UEjPL8aHxj20pFBtZJaX/rBZuZ3C4W1mAVOnRozY04M1UhGs MgNHvyl7iCwBLgbr1viXQcq7sz6Ik7I3ZbtoXTL0C10kDcNVVtAAbiG X-Developer-Key: i=dev.taqnialabs@gmail.com; a=ed25519; pk=4Syx51HH/MOySSUpi79M2ToLOdwt1yiNb338eKZBJNk= X-Endpoint-Received: by B4 Relay for dev.taqnialabs@gmail.com/20260425 with auth_id=752 X-Original-From: Abid Ali Reply-To: dev.taqnialabs@gmail.com From: Abid Ali Free RX DMA resources when alloc_dma_tx_desc_resources() fails in alloc_dma_desc_resources(). Signed-off-by: Abid Ali --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 13d3cac05..8bb843b55 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -2370,8 +2370,12 @@ static int alloc_dma_desc_resources(struct stmmac_priv *priv, return ret; ret = alloc_dma_tx_desc_resources(priv, dma_conf); + if (ret) { + free_dma_rx_desc_resources(priv, dma_conf); + return ret; + } - return ret; + return 0; } /** --- base-commit: 028ef9c96e96197026887c0f092424679298aae8 change-id: 20260425-stmmac-rx-desc-cleanup-440f05845492 Best regards, -- Abid Ali