From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCB7D3A1A3B for ; Tue, 5 May 2026 08:59:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777971587; cv=none; b=Pue/6KS7mqNlbWcfA0nkv9eKA9JV7pastXoFo2eHl6ohR4SJWebxON77FYKEwNpHpRq3oXy/6GFVbTxJcRU1Nq7yo1Q/3DhvJT6RL1EqdM7cHxOhyRtgZJI0hGsEMN90eP46gY9pdT2gqOTF4wJxE+5B2iKotlAQVcaeawMTdk8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777971587; c=relaxed/simple; bh=GtnmXgWBnlVbum8VU82XoIoP2qzEtwowPEy/lSbUNBc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=petBoSw3tu3RHt8FgJE82TYtgGW+zlSyRZKW41l5m0gcgTG0RmRBHG0cObkA2o1cqI8o7KvWtLtKkyqY9jKE1vOzqf923VI/ik3ucCa2wUEQUJxizR1R2jS12kPQnnjyMt4Hhogi0e6g5tvyAnzpJFJHrqLH/XyDDZ5o7/o9e9A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dPNbfl+m; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dPNbfl+m" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-365425c98c6so1383249a91.0 for ; Tue, 05 May 2026 01:59:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777971585; x=1778576385; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=scgXwfpWRTztGmGbOBFzi2/rYTv6bkNqRVNUxAo7T3c=; b=dPNbfl+mQfuF5iFuA4h/oDLdV+N6e39r4NeGUMHjBrQ8VpddRgowN/3bUgf73Xz0UQ +EivlcGMfx2NMdJnxbGnkfZKH0oKpKd9lH1O3zEBueWHipWF2LW2vFu22kzwLD0xZXCE IjJnS6mzDEEZzDHqrJoW5Aj/3PYMRO+qtiuEO6ffgCbeyFGftbbfiZt/EcrajVgrdfoO Xp0d34QjvfonJnfdtp/ZvU6L6+bDDnUwlC+dkvCKnMlNaZ1iDDMD+53SECpP+oI8AWFH kGywZY4KHbkQRd4O6AQ9XPx8fmIQcmu0NCE3B5Z6VEw+wk0N+CXbSk8bskdQcO9Dc9Fd REnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777971585; x=1778576385; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=scgXwfpWRTztGmGbOBFzi2/rYTv6bkNqRVNUxAo7T3c=; b=T6EGiiBGnu3lFpvB3Ntj5VSiKXKaIT8q0hOlHhqzKACP7BrGzsQ8WWkpdctj68X6eW wxs7yM/mKlfiQP7i97rf/IrvOHJSCjGXyp2xa7V3c1XFuaNWcHVcV7RDRlxMe4fFnUZX e4Ji3sMOcMzcsH3HYn4OHWyoF7C9iUIDmWd69n6R4aiVp14ieEQWzRgJX7RL9h1ZY+jM XTQSFSvH/+y6Vz5qpM2wN8epfylhy31eZuaB0Kscn3xp9suZEsBvFjxzI9aa6c5Kiyg/ N1Pn62gFF+dGr8utoWA80hvxkeJK2wVpWrfoEqi2wMU9arMEK10u+AHfWeihMZAa7+W+ budg== X-Forwarded-Encrypted: i=1; AFNElJ/b9QAQuH3uffmDUgnpWaGntIhpRSkBsLcZiZ3DBpsbK8FvtBX+GDgM5pvSYGC3D923qRaqLes=@vger.kernel.org X-Gm-Message-State: AOJu0Ywf8q32F1aJSTyFnL598+ZW3RDaiBOmjllhd+Qkkh1w/25plY0v HO1f8EXznNgJApqmB8XYHDIWcBQXTbWj6+OEVuZGcv37Cs5XT6QDbOtn X-Gm-Gg: AeBDietamV4f90jf8uLPMvglh1mv6pLpkpjXF4cHdRBeCWrIXL9wkFM1oz0HeF4dY72 ucYvxJGTJMjS/4wxklFPZAmTs9BAW5LjZa0ulczhFPFXNTULMRF24ONWJpMuZqEfMxY52t+583u haBxZo16mMk5fx8+ey32K/rUSX6N8GPc5+l+8G9B82tQX4BPlSfQM3lbUb+PpXjXu4w3htnDpZ4 2cEjpo5aFUKymNVoMbFRN0XeBRMKSPVQjIxcE6eF+J1wM25kAucBAS1MAMpvuBZgimgi8CzPT4A ENfjOGqsRqje4mHuMIV6cshJlIo9tyTqLl/lWMaD3ZbIvxNW0wkvp4dmdBtwysRX5fGSiEyfAs7 Y3GHVDSwZ0i8ra5GuRjDUNzmR/0LdLI9PjP0qf1vLbv0qziyaJOszJdN8dkcc2rjj1qiKXpC4xz XTgqvwbe6rlwDEfugGdEaFmIboZVAL2hSvNrdSs4vZiz25hb3AYTPW1SsVmP6NVjR/rqP/t+Rl X-Received: by 2002:a17:90b:17d0:b0:35a:cf:64a6 with SMTP id 98e67ed59e1d1-3650ce552camr13753846a91.23.1777971585283; Tue, 05 May 2026 01:59:45 -0700 (PDT) Received: from localhost.localdomain ([115.110.225.242]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-364dbeb2db0sm19293267a91.10.2026.05.05.01.59.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 01:59:44 -0700 (PDT) From: Shitalkumar Gandhi X-Google-Original-From: Shitalkumar Gandhi To: =?UTF-8?q?Niklas=20S=C3=B6derlund?= Cc: Geert Uytterhoeven , Jakub Kicinski , "David S . Miller" , Eric Dumazet , Paolo Abeni , Andrew Lunn , Simon Horman , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Shitalkumar Gandhi Subject: [PATCH net v2] net: rtsn: fix mdio_node leak in rtsn_mdio_alloc() Date: Tue, 5 May 2026 14:28:40 +0530 Message-Id: <20260505085840.352206-1-shitalkumar.gandhi@cambiumnetworks.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260504200356.3529873-1-shitalkumar.gandhi@cambiumnetworks.com> References: <20260504200356.3529873-1-shitalkumar.gandhi@cambiumnetworks.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit of_get_child_by_name() takes a reference. The rtsn_reset() and rtsn_change_mode() failure paths jump to out_free_bus and leak mdio_node. Add out_put_node to drop it before falling through. Fixes: b0d3969d2b4d ("net: ethernet: rtsn: Add support for Renesas Ethernet-TSN") Signed-off-by: Shitalkumar Gandhi Reviewed-by: Geert Uytterhoeven --- Changes in v2: - Restore blank line between `return 0;` and `out_put_node:` label (Geert) - Add Reviewed-by: Geert Uytterhoeven Link to v1: https://lore.kernel.org/netdev/20260504200356.3529873-1-shitalkumar.gandhi@cambiumnetworks.com/ drivers/net/ethernet/renesas/rtsn.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/renesas/rtsn.c b/drivers/net/ethernet/renesas/rtsn.c index 03a2669f0518..ee8381b60b8d 100644 --- a/drivers/net/ethernet/renesas/rtsn.c +++ b/drivers/net/ethernet/renesas/rtsn.c @@ -797,11 +797,11 @@ static int rtsn_mdio_alloc(struct rtsn_private *priv) /* Enter config mode before registering the MDIO bus */ ret = rtsn_reset(priv); if (ret) - goto out_free_bus; + goto out_put_node; ret = rtsn_change_mode(priv, OCR_OPC_CONFIG); if (ret) - goto out_free_bus; + goto out_put_node; rtsn_modify(priv, MPIC, MPIC_PSMCS_MASK | MPIC_PSMHT_MASK, MPIC_PSMCS_DEFAULT | MPIC_PSMHT_DEFAULT); @@ -824,6 +824,8 @@ static int rtsn_mdio_alloc(struct rtsn_private *priv) return 0; +out_put_node: + of_node_put(mdio_node); out_free_bus: mdiobus_free(mii); return ret; -- 2.25.1