public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Jamal Hadi Salim <jhs@mojatatu.com>
To: netdev@vger.kernel.org
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
	davem@davemloft.net, kuba@kernel.org, edumazet@google.com,
	pabeni@redhat.com, jiri@resnulli.us, horms@kernel.org,
	vinicius.gomes@intel.com, graypanda.inzag@gmail.com,
	victor@mojatatu.com
Subject: [PATCH net 0/2] Introduce CBS reset ops
Date: Tue,  5 May 2026 09:16:02 -0400	[thread overview]
Message-ID: <20260505131604.128605-1-jhs@mojatatu.com> (raw)

QFQ uses qlen to check whether it should reset pointer q->in_serv_agg.
When QFQ has a CBS child which has a netem child it is possible to create a
scenario where QFQ's qlen goes to 0 but the computation makes it underflow.
This then aggrevates a null pointer deref.

Jamal Hadi Salim (1):
  net/sched: sch_cbs: Call qdisc_reset for child qdisc

Victor Nogueira (1):
  selftests/tc-testing: Add QFQ/CBS qlen underflow test

 net/sched/sch_cbs.c                           | 12 +++++-
 .../tc-testing/tc-tests/infra/qdiscs.json     | 41 +++++++++++++++++++
 2 files changed, 52 insertions(+), 1 deletion(-)

-- 
2.34.1


                 reply	other threads:[~2026-05-05 13:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260505131604.128605-1-jhs@mojatatu.com \
    --to=jhs@mojatatu.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=graypanda.inzag@gmail.com \
    --cc=horms@kernel.org \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=victor@mojatatu.com \
    --cc=vinicius.gomes@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox