From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E66A31A045 for ; Tue, 5 May 2026 23:47:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778024857; cv=none; b=pQBOS/uOz9JL85dUAB3JUQTwzGoz3FEHi3SScaTQZRUfth3nZMZym53XwnAoijnfLDYmZ1J86O3KYSJiqjz8KgvZ35EewLqEdb5I9iY6JRsH5FJ14hoovkvwlPzSShblR1VyU5jRVPDBs1FCrWraESaBsbfcK2QLUEN3UqOK/nE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778024857; c=relaxed/simple; bh=3r0ZNyX7X5IFV2nmj70h8MMAibad4YbMGo46z2KFL3k=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RQqrjmtHXaURJsFgG0MWkLWQP1ZthW5XRmNfYSbz6MWLRKmrv8ontn/Szen0gFlfYKypVIhvJCsIwD6r4mb+4ThAdshxYurzUI/rgleysIlJNNmJCHjPvLO3bCO6JJCGeTog818Jae0WSxdIKF9NQPMzo3X5u50SYALDfkuQJvg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mSZqag/N; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mSZqag/N" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4839C2BCB4; Tue, 5 May 2026 23:47:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778024857; bh=3r0ZNyX7X5IFV2nmj70h8MMAibad4YbMGo46z2KFL3k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mSZqag/N7r8AJmkmWKSMWc2XDHcFWL0l2IRahDmpTvkdMKpw0q5vX/uyu1YxkwexJ OJEYOiGJiXJx/edjOD5FZ0SnOBHB5aBpjgoiy+OGXUW2gOYQAclwhnUE/wheB9K7kU J+V0ow0Mf25DcPNpw5YCZgeF4/zaFAJ2eWlpOxdqKgBpnSPCRIVih0Li0BIYc3nIzv Wxxm3XLwajFtHA2Iti3ZedeI3UGVgY9ZmDOHBKpMuYxsthWO5Je2ARt4n6OyPkb+lg 8xHsqfmznJ9lUUK8MiY2Tp1COk/s+/rIXhmTZ+nWHY7yY2v9bulRxbchQfXwSEOPp7 Ie/iBEug+i0kw== Date: Tue, 5 May 2026 16:47:36 -0700 From: Jakub Kicinski To: Holger Brunck Cc: "Christophe Leroy (CS GROUP)" , "netdev@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "andrew+netdev@lunn.ch" , "qiang.zhao@nxp.com" , "horms@kernel.org" Subject: Re: [PATCH net] net: wan: fsl_ucc_hdlc: free tx_skbuff in uhdlc_memclean Message-ID: <20260505164736.26d203a8@kernel.org> In-Reply-To: References: <20260504161145.2217950-1-holger.brunck@hitachienergy.com> <3e1a653b-81bc-4008-8f84-77c823aeef49@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 5 May 2026 08:33:34 +0000 Holger Brunck wrote: > > I don't think you can just kfree() an skb like this. > > > > I think you have to call dev_kfree_skb_any() instead. > > yes you are right or at least dev_kfree_skb() as the error handling code in > ucc_hdlc_tx does. Please make it clear in the commit message how you discovered the issue and how you tested your patches.