From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f49.google.com (mail-dl1-f49.google.com [74.125.82.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74A8A2D1907 for ; Thu, 7 May 2026 02:58:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778122720; cv=none; b=QfMr9Krve735yLllj3hEJdxZ0roRKx5GOiSvC23Zb3F+d/4KjrZJndmgmOX+YMyBZovYeWKdTYnoYFt5t852whKv29Wqns/1/5aCBLmV1suGh/VKy0pKwvEPPLQJWW+RLh54vvrcFJi6ryt/4uHM1gKvtjmHD7eUTDf27/uORtA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778122720; c=relaxed/simple; bh=n/9wL+EzxOeVLUDw+TuXzntXGa/ukJOkqD/4rI9oPps=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hj4VKZ94vnKTz38+1nCPTrwnndp3F4SH66zt4NYWePC977IIWGKgioVw8sVQqL6qJ2ISCeqEZkfBDD/xicynWhUpthx5RCyyuFlzFpE940LMyWlORUdaIm27sGCl/Z06ajb1aM5UN8/57Roy9xWQEA8XUQJMKtcP6BIwu1If/48= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oBTPYBvM; arc=none smtp.client-ip=74.125.82.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oBTPYBvM" Received: by mail-dl1-f49.google.com with SMTP id a92af1059eb24-12c19d23b19so735186c88.0 for ; Wed, 06 May 2026 19:58:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778122719; x=1778727519; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xdWapj7nZPh2nnXNORR4M7t33366rcLzDB4tv9BjBYc=; b=oBTPYBvMO0yJgEEXb95s+NGO6OoquJam/f5F3pbGIbVzwMXtbK0MuqFRf/1yt0zdw4 qAiTG8cbNzsta+DvlVapDGN1W8gGutSws4lD+h9rWEkrSNSwLnCsDPFznTROAHqngcmR /mDXaMJ2J5mvaiM776R9u9l6rbGFWgGcOzcGqO1AIwA8K0JeKP+2enyersJB0WPLYmZ0 JnKp8a618Ne/UMEj+nFVKoLvXFCtrdwWYyhI1LIfKH/2X+lo8zmyYP87230TAHeAUmYS 6VodKat/AbanDFDGDMufxjnoDHKhb83vVKFG/MKdDCGw3+kYNc9fZBgA3HwLVs1yqfTN 7h3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778122719; x=1778727519; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=xdWapj7nZPh2nnXNORR4M7t33366rcLzDB4tv9BjBYc=; b=dBNcq/Rs8gdUeOnQF+6605pPuvBrgbjkMGkL1syBQtZsiVrR9ehok9Y/PJTfOTgbRp chBiF0rO4Q7d6IPHrpPW3WjU3I/K9KyPh+YWyldUitTZ/wnJU+MnLKeJtPjpvBb/DIiE 0nAQZCVy+xL7CNgnyn4kTWkRhjQKfLrrYU+D1voYD2fa4p0M4K5xmIF+VfmXaAqIyIlX BA2sRpbRQMKE9TkJJBEzXco4A2cerQNcGVNnkY0RpKELpmrnkX35I9oSSILWLiOgMjsJ dutZaYAPz9O66vsltV770gNWc3cvGhbzDg4EOBSl0zM96AKA8VFG8KhM40HnpVWLyz0t Y6Ew== X-Gm-Message-State: AOJu0Yye+HNjzE3jlCaZlBGU4PCiqCz+HlAabnmat0OsUMMvlBlSP3uz Wc6XT8/k/i2Pb1ZFSbsQ9cN26jGaB4qJjIUrtOW0wxIu1+3sbPunxV3N X-Gm-Gg: AeBDievdsCg4Me1wkPvofCoc8zhSuzyUzrbo9CZ93BkQbig96RAhHYaM2JEQTI0UQ6x FMw1ie99Ji3Dq4lxzUQDO85twIdio9w6+IkK7Ir0xinohKxUuINSDl+COfPI+6fQBUS5jIAz/Mo t0cguvYOg8wZhvhTWANC66xZzUy0dSmE6RBZv7QsB7KMzvhkmVwYEsc3VNvDMNUvgCl6AEtmCyT gEfMLtP+QUSEoBKXoBS3KKDaNkzEkmdZ1zaEofZl+iHfX4svH/YOo3H4W+Y9uC6G7JlVTwXj8+e flcyw7SUz8eb1lL5KUtWh0feCr4Xep/XbKsGPqaCg8Q2ciUfOuYmAouBe3TLBbSH+gBmKt1bqTh AoiLa7WogDVoOzRFy+b5OpSIc5h64SIJqHr0eAcR5Ed3WLswhhktLvi1dgZfPDzRLyWFBgAzB3q hoUmaBcCBmBxZmvE+7AhXeMie/uEzw2yQb51fG2pM9k80WQjkHooufqLnOIckg X-Received: by 2002:a05:7022:43a6:b0:130:c9cc:3384 with SMTP id a92af1059eb24-1319d14e094mr2506293c88.30.1778122718543; Wed, 06 May 2026 19:58:38 -0700 (PDT) Received: from tresc054937.tre-sc.gov.br ([187.65.210.13]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-131f9789e3dsm6561267c88.8.2026.05.06.19.58.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 19:58:37 -0700 (PDT) From: Luiz Angelo Daros de Luca Date: Wed, 06 May 2026 23:58:18 -0300 Subject: [net-next PATCH v3 1/8] net: dsa: realtek: rtl8365mb: use ERR_PTR Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260506-realtek_forward-v3-1-1d87c5f85a3b@gmail.com> References: <20260506-realtek_forward-v3-0-1d87c5f85a3b@gmail.com> In-Reply-To: <20260506-realtek_forward-v3-0-1d87c5f85a3b@gmail.com> To: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Linus Walleij , =?utf-8?q?Alvin_=C5=A0ipraga?= , Yury Norov , Rasmus Villemoes , Russell King Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luiz Angelo Daros de Luca X-Mailer: b4 0.15.2 Convert numeric error codes into human-readable strings by using %pe together with ERR_PTR() in dev_err() messages. Reviewed-by: Linus Walleij Signed-off-by: Luiz Angelo Daros de Luca --- drivers/net/dsa/realtek/rtl8365mb.c | 40 ++++++++++++++++++++----------------- 1 file changed, 22 insertions(+), 18 deletions(-) diff --git a/drivers/net/dsa/realtek/rtl8365mb.c b/drivers/net/dsa/realtek/rtl8365mb.c index c35cef01ec26..edbc16345d0d 100644 --- a/drivers/net/dsa/realtek/rtl8365mb.c +++ b/drivers/net/dsa/realtek/rtl8365mb.c @@ -789,8 +789,8 @@ static int rtl8365mb_phy_read(struct realtek_priv *priv, int phy, int regnum) ret = rtl8365mb_phy_ocp_read(priv, phy, ocp_addr, &val); if (ret) { dev_err(priv->dev, - "failed to read PHY%d reg %02x @ %04x, ret %d\n", phy, - regnum, ocp_addr, ret); + "failed to read PHY%d reg %02x @ %04x, ret %pe\n", phy, + regnum, ocp_addr, ERR_PTR(ret)); return ret; } @@ -817,8 +817,8 @@ static int rtl8365mb_phy_write(struct realtek_priv *priv, int phy, int regnum, ret = rtl8365mb_phy_ocp_write(priv, phy, ocp_addr, val); if (ret) { dev_err(priv->dev, - "failed to write PHY%d reg %02x @ %04x, ret %d\n", phy, - regnum, ocp_addr, ret); + "failed to write PHY%d reg %02x @ %04x, ret %pe\n", phy, + regnum, ocp_addr, ERR_PTR(ret)); return ret; } @@ -1068,8 +1068,8 @@ static void rtl8365mb_phylink_mac_config(struct phylink_config *config, ret = rtl8365mb_ext_config_rgmii(priv, port, state->interface); if (ret) dev_err(priv->dev, - "failed to configure RGMII mode on port %d: %d\n", - port, ret); + "failed to configure RGMII mode on port %d: %pe\n", + port, ERR_PTR(ret)); return; } @@ -1098,8 +1098,8 @@ static void rtl8365mb_phylink_mac_link_down(struct phylink_config *config, false, false); if (ret) dev_err(priv->dev, - "failed to reset forced mode on port %d: %d\n", - port, ret); + "failed to reset forced mode on port %d: %pe\n", + port, ERR_PTR(ret)); return; } @@ -1129,8 +1129,8 @@ static void rtl8365mb_phylink_mac_link_up(struct phylink_config *config, rx_pause); if (ret) dev_err(priv->dev, - "failed to force mode on port %d: %d\n", port, - ret); + "failed to force mode on port %d: %pe\n", port, + ERR_PTR(ret)); return; } @@ -1285,8 +1285,8 @@ static void rtl8365mb_get_ethtool_stats(struct dsa_switch *ds, int port, u64 *da mib->length, &data[i]); if (ret) { dev_err(priv->dev, - "failed to read port %d counters: %d\n", port, - ret); + "failed to read port %d counters: %pe\n", port, + ERR_PTR(ret)); break; } } @@ -1638,7 +1638,8 @@ static irqreturn_t rtl8365mb_irq(int irq, void *data) return IRQ_HANDLED; out_error: - dev_err(priv->dev, "failed to read interrupt status: %d\n", ret); + dev_err(priv->dev, "failed to read interrupt status: %pe\n", + ERR_PTR(ret)); out_none: return IRQ_NONE; @@ -1776,7 +1777,8 @@ static int rtl8365mb_irq_setup(struct realtek_priv *priv) ret = request_threaded_irq(irq, NULL, rtl8365mb_irq, IRQF_ONESHOT, "rtl8365mb", priv); if (ret) { - dev_err(priv->dev, "failed to request irq: %d\n", ret); + dev_err(priv->dev, "failed to request irq: %pe\n", + ERR_PTR(ret)); goto out_remove_irqdomain; } @@ -1952,14 +1954,16 @@ static int rtl8365mb_setup(struct dsa_switch *ds) ret = rtl8365mb_reset_chip(priv); if (ret) { - dev_err(priv->dev, "failed to reset chip: %d\n", ret); + dev_err(priv->dev, "failed to reset chip: %pe\n", + ERR_PTR(ret)); goto out_error; } /* Configure switch to vendor-defined initial state */ ret = rtl8365mb_switch_init(priv); if (ret) { - dev_err(priv->dev, "failed to initialize switch: %d\n", ret); + dev_err(priv->dev, "failed to initialize switch: %pe\n", + ERR_PTR(ret)); goto out_error; } @@ -2077,8 +2081,8 @@ static int rtl8365mb_detect(struct realtek_priv *priv) ret = rtl8365mb_get_chip_id_and_ver(priv->map, &chip_id, &chip_ver); if (ret) { - dev_err(priv->dev, "failed to read chip id and version: %d\n", - ret); + dev_err(priv->dev, "failed to read chip id and version: %pe\n", + ERR_PTR(ret)); return ret; } -- 2.54.0