From: albin_yang@163.com
To: alexjlzheng@gmail.com
Cc: alexjlzheng@tencent.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, horms@kernel.org,
kuba@kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, pabeni@redhat.com, sd@queasysnail.net,
shenyangyang4@huawei.com, Wei Yang <albinwyang@tencent.com>
Subject: Re: [PATCH] macsec: defer RX SA cleanup from RCU callback to workqueue
Date: Wed, 6 May 2026 20:56:15 +0800 [thread overview]
Message-ID: <20260506125615.3078625-1-albin_yang@163.com> (raw)
In-Reply-To: <20260506100107.388184-1-alexjlzheng@tencent.com>
On Wed, May 06, 2026 at 10:01:07AM +0800, alexjlzheng@tencent.com wrote:
> crypto_free_aead() can call vunmap() internally (e.g. via
> dma_free_attrs() in hardware crypto drivers like hisi_sec2), which
> must not be called from softirq context.
>
> free_rxsa() is an RCU callback and therefore runs in softirq context,
> causing a kernel crash when the underlying AEAD implementation
> performs DMA unmapping during tfm destruction:
>
> [...]
Looks good to me.
Reviewed-by: Wei Yang <albinwyang@tencent.com>
next prev parent reply other threads:[~2026-05-06 12:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 10:01 [PATCH] macsec: defer RX SA cleanup from RCU callback to workqueue alexjlzheng
2026-05-06 12:56 ` albin_yang [this message]
2026-05-06 17:41 ` Kuniyuki Iwashima
2026-05-06 17:55 ` Sabrina Dubroca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260506125615.3078625-1-albin_yang@163.com \
--to=albin_yang@163.com \
--cc=albinwyang@tencent.com \
--cc=alexjlzheng@gmail.com \
--cc=alexjlzheng@tencent.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
--cc=shenyangyang4@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox