From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B42463A1A3C for ; Thu, 7 May 2026 14:49:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778165366; cv=none; b=s2WWjZCMSjMzqUaN3V1/2qKseoWWu03QvJmtQbdX1D9BLMdsBR97pPHE/ph+lXTn7+NlGZWA2wLKmpQ0tQZV/H/9493eLxWOSfW9+I+00l2dEsglgksOWVJdI2KOkxxhzzTcQYKeBfS64fwrmt9IShw2NndWnZ3RBB9ee0MjWA0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778165366; c=relaxed/simple; bh=0UEQFqnl250j7u4bGJcBxutylZ1Mf5pF7DjU6CUdE8M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DkuoSp4sySwIRSHkqtaQzITdoPWHnZre32xbSSgzuEhKXWZYGlP4TWFY2AubMji3RTfS/E0tWv06MX57ALq1KmzL2tBSanAITWTZSZfjziQMkn67yP26NR1cwV+LGCRCfLOnnpE6lLDuNSs3j+56LaoH5RWakkHjt+9G/ax3bpA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1wL01i-0001Vq-3i; Thu, 07 May 2026 16:48:34 +0200 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wL01Z-000wEM-1k; Thu, 07 May 2026 16:48:26 +0200 Received: from pengutronix.de (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 264265306B3; Thu, 07 May 2026 14:48:25 +0000 (UTC) Date: Thu, 7 May 2026 16:48:24 +0200 From: Marc Kleine-Budde To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= Cc: Michael Grzeschik , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vincent Mailhol , Krzysztof Halasa , Johannes Berg , Steffen Klassert , David Dillow , Ion Badulescu , Mark Einon , Rasesh Mody , GR-Linux-NIC-Dev@marvell.com, Manish Chopra , Potnuri Bharat Teja , Denis Kirjanov , Jijie Shao , Jian Shen , Cai Huoqing , Fan Gong , Tony Nguyen , Przemek Kitszel , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Mark Bloch , Ido Schimmel , Petr Machata , Yibo Dong , Heiner Kallweit , nic_swsd@realtek.com, Jiri Pirko , Francois Romieu , Daniele Venzano , Samuel Chessman , Jiawen Wu , Mengyuan Lou , Kevin Curtis , Arend van Spriel , Stanislav Yakovlev , Richard Cochran , Kees Cook , Aleksandr Loktionov , Thomas Gleixner , Jacob Keller , Thomas Fourier , Ingo Molnar , Kory Maincent , Zilin Guan , Vadim Fedorenko , Marco Crivellari , Bjorn Helgaas , David Arinzon , Yeounsu Moon , Denis Benato , Yonglong Liu , Andy Shevchenko , Randy Dunlap , Yicong Hui , MD Danish Anwar , Nathan Chancellor , Ethan Nelson-Moore , Larysa Zaremba , Ian Lin , Colin Ian King , Double Lo , Markus Schneider-Pargmann , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-can@vger.kernel.org, linux-parisc@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@corigine.com, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com Subject: Re: [PATCH net-next v2 1/2] net: Consistently define pci_device_ids using named initializers Message-ID: <20260507-dangerous-manipulative-guan-bfd474-mkl@pengutronix.de> X-AI: stop_reason: "refusal" References: <76da4f44d48bdde84580963862bf9616bee5c9e9.1778149923.git.u.kleine-koenig@baylibre.com> <20260507-healthy-gainful-fox-500552-mkl@pengutronix.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3r5cznssyoe7scuq" Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org --3r5cznssyoe7scuq Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH net-next v2 1/2] net: Consistently define pci_device_ids using named initializers MIME-Version: 1.0 On 07.05.2026 16:23:43, Uwe Kleine-K=C3=B6nig (The Capable Hub) wrote: > Hello Marc, > > On Thu, May 07, 2026 at 12:55:45PM +0200, Marc Kleine-Budde wrote: > > > + }, { > > > /* ASEM Dual CAN raw -new model */ > > > - ASEM_RAW_CAN_VENDOR_ID, ASEM_RAW_CAN_DEVICE_ID, > > > - ASEM_RAW_CAN_SUB_VENDOR_ID, ASEM_RAW_CAN_SUB_DEVICE_ID_BIS, > > > - 0, 0, > > > - (kernel_ulong_t)&plx_pci_card_info_asem_dual_can > > > + PCI_DEVICE_SUB(ASEM_RAW_CAN_VENDOR_ID, ASEM_RAW_CAN_DEVICE_ID, > > > + ASEM_RAW_CAN_SUB_VENDOR_ID, ASEM_RAW_CAN_SUB_DEVICE_ID_BIS= ), > > > + .driver_data =3D (kernel_ulong_t)&plx_pci_card_info_asem_dual_can, > > > }, > > > - { 0,} > > > + { } > > > > Nitpick: can you convert the terminating entry to follow the same style > > as the rest of the driver: > > > > diff --git a/drivers/net/can/sja1000/plx_pci.c b/drivers/net/can/sja100= 0/plx_pci.c > > index a03553b80a5d..d69ff0ccfd94 100644 > > --- a/drivers/net/can/sja1000/plx_pci.c > > +++ b/drivers/net/can/sja1000/plx_pci.c > > @@ -353,8 +353,8 @@ static const struct pci_device_id plx_pci_tbl[] =3D= { > > PCI_DEVICE_SUB(ASEM_RAW_CAN_VENDOR_ID, ASEM_RAW_CAN_DE= VICE_ID, > > ASEM_RAW_CAN_SUB_VENDOR_ID, ASEM_RAW_CA= N_SUB_DEVICE_ID_BIS), > > .driver_data =3D (kernel_ulong_t)&plx_pci_card_info_as= em_dual_can, > > - }, > > - { } > > + }, { > > + } > > }; > > MODULE_DEVICE_TABLE(pci, plx_pci_tbl); > > After the conversation in the v1 thread it was unclear to me if you > stand by your opinion, so I kept the format as it was. I interpret your > repetition of the nitpick as request to rework the can drivers for the > next revision (if that happens). Doh - Yes, right, we discussed this already. Keep it as is and add my: Acked-by: Marc Kleine-Budde # for drivers/net/can regards, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung N=C3=BCrnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 | --3r5cznssyoe7scuq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSl+MghEFFAdY3pYJLMOmT6rpmt0gUCafymNgAKCRDMOmT6rpmt 0nq+AQDxBatA6k3wbRiLlE0iYqFi1UszWzbE6VspAxP9GaL27AEAvpxnHmYAF7Ba NGRZfHI9sLbcPJXvBj/FLuPCtchoBwQ= =GAHD -----END PGP SIGNATURE----- --3r5cznssyoe7scuq--