From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BFDE3EDACE; Thu, 7 May 2026 11:59:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778155178; cv=none; b=WFSqdwbTOfUpEVu6T6h30yPfYPehkMOMP+O/FprfyLdePDUkkcmnP/dNYT9N932kDTt0E23FoEO0cGI4sr1fFbiYFtDBygB1XR2ACP9rCNdhEdeFfsOt1wOBu0Abz61rctKJaeFQwBihOIJyEAHi+anSa2UXLy2Kx86xN89enNU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778155178; c=relaxed/simple; bh=9Qi7Bqf5701zJ+UIELOq4/coD675DIWia6FjFcBsdSc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZU6h0E3MrdlTXn21XzUWRSOiNT0OFvVrQd4jRN5ChG9eBqKH4NpQVq5lsLXFKi5vtOW5zyVWFch/n/uYEPJYJ7ZTwbMkd+DoFoYF1TO2NCK5cLMbKrbeYSDiKsZTb3mRSKJH9uhyUWBTb/Oasn1Xq5HsNX0/Iu0UvNXbycS/r8A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bq45yKfc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bq45yKfc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8EEE1C2BCB2; Thu, 7 May 2026 11:59:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778155177; bh=9Qi7Bqf5701zJ+UIELOq4/coD675DIWia6FjFcBsdSc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bq45yKfcYsPFrE1PHqbs6G+XyY2DJcGK41Vz3PwpzJB3t096MthbcPGb1ILjQ7XDw Xo4pa/qX0L07J7j1Vai5aowj9taZgDkcjA6pfu90MU76J+Go2uXC16ufpjnl6JRRH5 0IOxz0YxsDe+gYfRyLpGBn7jFWPM9HFpB2Mb+dWjBW0vNoBYQSfyzlksJmIJyUHUt2 4mJ5e19UP6lfuYRPo2SczVOchJAhey9XFUM4dwCDZ0eodWRAA18AEzuybR53bWjCIW wnUHLJ/ZnmnV7uKC5nvk0ZeYd3y8B17TCKy7hmwg+Z0MOHARiFcMGfElUpmWDJ+muH ToaMw08cwweOQ== Date: Thu, 7 May 2026 06:59:35 -0500 From: Rob Herring To: Herve Codina Cc: Linus Walleij , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Conor Dooley , Horatiu Vultur , netdev@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH] dt-bindings: net: lan966x: Accept standard ethernet prefixes Message-ID: <20260507115935.GA1119810-robh@kernel.org> References: <20260507-lan966-binding-v1-1-e99293d2a4ec@kernel.org> <20260507134043.35fdb1b9@bootlin.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260507134043.35fdb1b9@bootlin.com> On Thu, May 07, 2026 at 01:40:43PM +0200, Herve Codina wrote: > Hi Linus, > > On Thu, 07 May 2026 11:26:01 +0200 > Linus Walleij wrote: > > > The dsa.yaml and ethernet-switch.yaml bindings recommend > > prefixing ethernet switches and ports with "ethernet-" so > > make the LAN966x do the same. > > > > Reported-by: Herve Codina > > Signed-off-by: Linus Walleij > > --- > > .../devicetree/bindings/net/microchip,lan966x-switch.yaml | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml > > index 306ef9ecf2b9..0f0f35865ef4 100644 > > --- a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml > > +++ b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml > > @@ -17,7 +17,7 @@ description: | > > > > properties: > > $nodename: > > - pattern: "^switch@[0-9a-f]+$" > > + pattern: "^(ethernet-)?switch@[0-9a-f]+$" > > > > compatible: > > const: microchip,lan966x-switch > > @@ -70,7 +70,7 @@ properties: > > additionalProperties: false > > > > patternProperties: > > - "^port@[0-9a-f]+$": > > + "^(ethernet-)?port@[0-9a-f]+$": > > type: object > > > > $ref: /schemas/net/ethernet-controller.yaml# > > @@ -138,7 +138,7 @@ additionalProperties: false > > examples: > > - | > > #include > > - switch: switch@e0000000 { > > + switch: ethernet-switch@e0000000 { > > compatible = "microchip,lan966x-switch"; > > reg = <0xe0000000 0x0100000>, > > <0xe2000000 0x0800000>; > > @@ -151,14 +151,14 @@ examples: > > #address-cells = <1>; > > #size-cells = <0>; > > > > - port0: port@0 { > > + port0: ethernet-port@0 { > > reg = <0>; > > phy-handle = <&phy0>; > > phys = <&serdes 0 0>; > > phy-mode = "gmii"; > > }; > > > > - port1: port@1 { > > + port1: ethernet-port@1 { > > reg = <1>; > > sfp = <&sfp_eth1>; > > managed = "in-band-status"; > > > > --- > > base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 > > change-id: 20260507-lan966-binding-0df62a018509 > > > > Best regards, > > -- > > Linus Walleij > > > > With those changes, dtb_check will not be happy when following dtsi/dts are > involved: > - arch/arm/boot/dts/microchip/lan966x.dtsi > - arch/arm/boot/dts/microchip/lan966x-kontron-kswitch-d10-mmt.dtsi > - arch/arm/boot/dts/microchip/lan966x-pcb8290.dts > - arch/arm/boot/dts/microchip/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dts > - arch/arm/boot/dts/microchip/lan966x-kontron-kswitch-d10-mmt-8g.dts How so? the added prefix is optional. Rob