Netdev List
 help / color / mirror / Atom feed
From: Ankit Jain <ankit-aj.jain@broadcom.com>
To: edumazet@google.com, netdev@vger.kernel.org
Cc: kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com,
	ncardwell@google.com, kuniyu@google.com, horms@kernel.org,
	shuah@kernel.org, quic_subashab@quicinc.com,
	quic_stranche@quicinc.com, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org, karen.badiryan@broadcom.com,
	ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com,
	vamsi-krishna.brahmajosyula@broadcom.com, yin.ding@broadcom.com,
	tapas.kundu@broadcom.com, Ankit Jain <ankit-aj.jain@broadcom.com>
Subject: [PATCH net v3 0/2] tcp: protect locked SO_RCVBUF from Silly Window Syndrome
Date: Thu,  7 May 2026 15:48:04 +0000	[thread overview]
Message-ID: <20260507154806.18635-1-ankit-aj.jain@broadcom.com> (raw)

This patch series fixes Silly Window Syndrome (SWS) for sockets using 
locked SO_RCVBUF.

When applications like Tomcat lock SO_RCVBUF, receiving small packets 
causes the memory truesize penalty to drop the scaling_ratio to 1. 
This shrinks the internal window clamp and leads to 504 Gateway Timeouts.

Patch 1 bypasses this penalty for locked sockets, except for GRO packets.
Patch 2 adds a packetdrill test to validate this fix.

Link to v1:
https://lore.kernel.org/all/20260427152756.1205-1-ankit-aj.jain@broadcom.com/
Link to v2:
https://lore.kernel.org/all/20260504144945.13477-1-ankit-aj.jain@broadcom.com/

v2 -> v3:
 - Changed GRO detection from checking tp->advmss to skb->len > len 
   based on Eric Dumazet's suggestion. This correctly detects GRO 
   packets even if they contain tiny segments.
 - Updated packetdrill script. Removed the ad-hoc mss 48 configuration. 
   It now uses a standard 1460 MSS and sends varying packet sizes 
   (600, 700, 800 bytes) to naturally trigger the scaling_ratio 
   recalculation.

Testing:
 - Verified fix in a live Java/Tomcat environment (504 timeouts resolved).
 - Passed the newly added packetdrill test demonstrating the clamp bypass.
 - Passed upstream regression tests: tcp_rcv_neg_window.pkt,
   tcp_rcv_wnd_shrink_allowed.pkt, tcp_rcv_wnd_shrink_nomem.pkt,
   tcp_rcv_zero_wnd_fin.pkt, and tcp_rcv_big_endseq.pkt

Ankit Jain (2):
  tcp: protect locked SO_RCVBUF from Silly Window Syndrome
  selftests/net: add packetdrill test for locked SO_RCVBUF SWS

 net/ipv4/tcp_input.c                          |  7 ++++-
 .../net/packetdrill/tcp_locked_rcvbuf_sws.pkt | 29 +++++++++++++++++++
 2 files changed, 35 insertions(+), 1 deletion(-)
 create mode 100644 tools/testing/selftests/net/packetdrill/tcp_locked_rcvbuf_sws.pkt

-- 
2.53.0


             reply	other threads:[~2026-05-07 15:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-07 15:48 Ankit Jain [this message]
2026-05-07 15:48 ` [PATCH net v3 1/2] tcp: protect locked SO_RCVBUF from Silly Window Syndrome Ankit Jain
2026-05-11  7:18   ` Eric Dumazet
2026-05-07 15:48 ` [PATCH net v3 2/2] selftests/net: add packetdrill test for locked SO_RCVBUF SWS Ankit Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260507154806.18635-1-ankit-aj.jain@broadcom.com \
    --to=ankit-aj.jain@broadcom.com \
    --cc=ajay.kaher@broadcom.com \
    --cc=alexey.makhalov@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=karen.badiryan@broadcom.com \
    --cc=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=quic_stranche@quicinc.com \
    --cc=quic_subashab@quicinc.com \
    --cc=shuah@kernel.org \
    --cc=tapas.kundu@broadcom.com \
    --cc=vamsi-krishna.brahmajosyula@broadcom.com \
    --cc=yin.ding@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox