Netdev List
 help / color / mirror / Atom feed
From: Simon Wunderlich <sw@simonwunderlich.de>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	b.a.t.m.a.n@lists.open-mesh.org,
	Lyes Bourennani <lbourennani@fuzzinglabs.com>,
	stable@vger.kernel.org, Alexis Pinson <apinson@fuzzinglabs.com>,
	Sven Eckelmann <sven@narfation.org>,
	Simon Wunderlich <sw@simonwunderlich.de>
Subject: [PATCH net 1/8] batman-adv: fix integer overflow on buff_pos
Date: Fri,  8 May 2026 17:43:07 +0200	[thread overview]
Message-ID: <20260508154314.12817-2-sw@simonwunderlich.de> (raw)
In-Reply-To: <20260508154314.12817-1-sw@simonwunderlich.de>

From: Lyes Bourennani <lbourennani@fuzzinglabs.com>

Fixing an integer overflow present in batadv_iv_ogm_send_to_if. The size
check is done using the int type in batadv_iv_ogm_aggr_packet whereas the
buff_pos variable uses the s16 type. This could lead to an out-of-bound
read.

Cc: stable@vger.kernel.org
Fixes: c6c8fea29769 ("net: Add batman-adv meshing protocol")
Signed-off-by: Lyes Bourennani <lbourennani@fuzzinglabs.com>
Signed-off-by: Alexis Pinson <apinson@fuzzinglabs.com>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
---
 net/batman-adv/bat_iv_ogm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/batman-adv/bat_iv_ogm.c b/net/batman-adv/bat_iv_ogm.c
index f28e9cbf8ad5f..618d1889c04e7 100644
--- a/net/batman-adv/bat_iv_ogm.c
+++ b/net/batman-adv/bat_iv_ogm.c
@@ -335,7 +335,7 @@ static void batadv_iv_ogm_send_to_if(struct batadv_forw_packet *forw_packet,
 	struct batadv_priv *bat_priv = netdev_priv(hard_iface->mesh_iface);
 	const char *fwd_str;
 	u8 packet_num;
-	s16 buff_pos;
+	int buff_pos;
 	struct batadv_ogm_packet *batadv_ogm_packet;
 	struct sk_buff *skb;
 	u8 *packet_pos;
-- 
2.47.3


  reply	other threads:[~2026-05-08 15:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-08 15:43 [PATCH net 0/8] pull request: batman-adv 2026-05-08 Simon Wunderlich
2026-05-08 15:43 ` Simon Wunderlich [this message]
2026-05-10 17:10   ` [PATCH net 1/8] batman-adv: fix integer overflow on buff_pos patchwork-bot+netdevbpf
2026-05-08 15:43 ` [PATCH net 2/8] batman-adv: reject new tp_meter sessions during teardown Simon Wunderlich
2026-05-08 15:43 ` [PATCH net 3/8] batman-adv: stop tp_meter sessions during mesh teardown Simon Wunderlich
2026-05-09 18:52   ` Sven Eckelmann
2026-05-08 15:43 ` [PATCH net 4/8] batman-adv: stop caching unowned originator pointers in BAT IV Simon Wunderlich
2026-05-08 15:43 ` [PATCH net 5/8] batman-adv: tp_meter: fix tp_num leak on kmalloc failure Simon Wunderlich
2026-05-08 15:43 ` [PATCH net 6/8] batman-adv: bla: prevent use-after-free when deleting claims Simon Wunderlich
2026-05-08 15:43 ` [PATCH net 7/8] batman-adv: bla: only purge non-released claims Simon Wunderlich
2026-05-08 15:43 ` [PATCH net 8/8] batman-adv: bla: put backbone reference on failed claim hash insert Simon Wunderlich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260508154314.12817-2-sw@simonwunderlich.de \
    --to=sw@simonwunderlich.de \
    --cc=apinson@fuzzinglabs.com \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=lbourennani@fuzzinglabs.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=sven@narfation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox