From: Stefano Garzarella <sgarzare@redhat.com>
To: netdev@vger.kernel.org
Cc: "Yiqi Sun" <sunyiqixm@gmail.com>,
"Stefano Garzarella" <sgarzare@redhat.com>,
linux-kernel@vger.kernel.org,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
kvm@vger.kernel.org, "Simon Horman" <horms@kernel.org>,
"Bobby Eshleman" <bobbyeshleman@meta.com>,
"Jason Wang" <jasowang@redhat.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
virtualization@lists.linux.dev,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Arseniy Krasnov" <avkrasnov@salutedevices.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Bobby Eshleman" <bobby.eshleman@bytedance.com>
Subject: [PATCH net 0/2] vsock/virtio: fix vsockmon tap skb construction
Date: Fri, 8 May 2026 18:44:09 +0200 [thread overview]
Message-ID: <20260508164411.261440-1-sgarzare@redhat.com> (raw)
While reviewing the patch posted by Yiqi Sun [1] to fix an issue in
virtio_transport_build_skb(), I discovered another issue related to
the offset and length of the payload to be copied in the new skb.
This was introduced when we did the skb conversion, and fixed by
patch 1.
Patch 2 fixes the issue found by Yiqi Sun in a different way: using
iov_iter_kvec() to properly initialize all the iov_iter fields and
removing the linear vs non-linear split like we alredy do in
vhost-vsock.
It could have been a single patch, but since there were two affected
commits, I decided to keep the fixes separate.
[1] https://lore.kernel.org/netdev/20260430071110.380509-1-sunyiqixm@gmail.com/
Stefano Garzarella (2):
vsock/virtio: fix length and offset in tap skb for split packets
vsock/virtio: fix empty payload in tap skb for non-linear buffers
net/vmw_vsock/virtio_transport_common.c | 47 +++++++++----------------
1 file changed, 16 insertions(+), 31 deletions(-)
--
2.54.0
next reply other threads:[~2026-05-08 16:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 16:44 Stefano Garzarella [this message]
2026-05-08 16:44 ` [PATCH net 1/2] vsock/virtio: fix length and offset in tap skb for split packets Stefano Garzarella
2026-05-08 22:22 ` Bobby Eshleman
2026-05-10 11:24 ` Arseniy Krasnov Arseniy Krasnov
2026-05-08 16:44 ` [PATCH net 2/2] vsock/virtio: fix empty payload in tap skb for non-linear buffers Stefano Garzarella
2026-05-08 22:30 ` Bobby Eshleman
2026-05-10 11:28 ` Arseniy Krasnov Arseniy Krasnov
2026-05-09 19:38 ` [PATCH net 0/2] vsock/virtio: fix vsockmon tap skb construction Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260508164411.261440-1-sgarzare@redhat.com \
--to=sgarzare@redhat.com \
--cc=avkrasnov@salutedevices.com \
--cc=bobby.eshleman@bytedance.com \
--cc=bobbyeshleman@meta.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=horms@kernel.org \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stefanha@redhat.com \
--cc=sunyiqixm@gmail.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox