From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D35E61A6829; Sat, 9 May 2026 01:17:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778289462; cv=none; b=AN7m6hm2znumMrCWZVQk8yG21aVCWiu4CON/RgWoun+ryylIphDOoNhjdw0qloF+BmKy043oj9K71bAOTHs5mfRsnHNaCC8b+J2B6wW2iMML4csbGXy3tGCGbqm7FbcpDcjyjCuh9RiKDAZOIg/8k9RnDAG9LRlIe9OXr0VdYWg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778289462; c=relaxed/simple; bh=dqbu/2cwJe9fc/ymneIOMGUzRsyVd9sMZhEcCdTLQTg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=I+oXBtf03diEkLQJ9s83shgpNQJL4sQUXQgTYFFoQRVjIlfL9YrbBtxWQ2xJtOIzLN0MnHbCBCEX7N84nv1KLBqIf2gnV4afHyuOjQ5zjtwtYFN9nuyTE7LajWKzWhFadzYwOgPpF5xTPxLtBtkOCa2cMxnxf2YOnRobqzjy7GY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NQSb3G6Z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NQSb3G6Z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1632CC2BCB0; Sat, 9 May 2026 01:17:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778289462; bh=dqbu/2cwJe9fc/ymneIOMGUzRsyVd9sMZhEcCdTLQTg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NQSb3G6ZWQixDHh127SxTxWsxzDeUMN/UbgL6qJPZX86UeiuW1Wh1llTt1mQqSSsO OvIUoHM5nHa3ge6dmMf7s9zJN4aNw5MkRK41a3w5j6NiZRxHJ0s/k50uxQUDtTa1Gc CZ8uP31v1MQ9kn69GHqkRYeCjdsOEHj0j6Nwxa+b79gLqbtHxzi3FvIFJ/ia7r68ty KlIQyku30SSlxZaUflMeT7flXArxpXk/TsLTwjFM0qOKGXwKQckfTwExWGIw/hFjPS e6Mq8IsG9u62KJVStVpscYYfUiawGFAwJTdn7YZp6GNVNl5ayrR5VKaDXnGqOtDJ2p WKbzJ2NtOK2AA== Date: Fri, 8 May 2026 18:17:41 -0700 From: Jakub Kicinski To: Sajal Gupta Cc: petkan@nucleusys.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: usb: pegasus: replace simple_strtoul with kstrtouint Message-ID: <20260508181741.50c093ee@kernel.org> In-Reply-To: <20260506152653.52329-1-sajal2005gupta@gmail.com> References: <20260506152653.52329-1-sajal2005gupta@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 6 May 2026 20:56:36 +0530 Sajal Gupta wrote: > + token = strsep(&id, ":"); > + if (token) { > + err = kstrtouint(token, 16, &vendor_id); > + if (err) > + return; > + } Why bother capturing err if we can't return it? if (token && kstrtouint(token, 16, &vendor_id))