Re: [PATCH net-next v3 1/3] net/ethernet: add ZTE network driver support

[Junyang Han <han.junyang@zte.com.cn>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1300 bytes --]

Hi Andrew,

Thank you for taking the time to review.

> +    struct devlink *devlink;

> +    int ret;
> +
> +    devlink = devlink_alloc(&dh_pf_devlink_ops, sizeof(struct dh_core_dev),
> +                &pdev->dev);

> Wrong indentation. In fact, this seems to have spaces not tabs. What
> does checkpatch say about these files? Or is you email still broken?


I double-checked the patch file locally. The indentation does use
tabs, not spaces:

  $ cat -A v3-0001-*.patch | grep -A3 "devlink_alloc"
  +^Idevlink = devlink_alloc(&dh_pf_devlink_ops, sizeof(struct dh_core_dev),$
  +^I^I^I^I&pdev->dev);$
  +^Iif (!devlink)$
  +^I^Ireturn -ENOMEM;$

And checkpatch.pl --strict also reports 0 errors, 0 warnings:

  total: 0 errors, 0 warnings, 4 checks, 320 lines checked

I checked the raw email on lore.kernel.org and found that our
corporate mail system is converting the original text/plain email
into a multipart MIME message with both text/plain and text/html
alternatives. In the HTML part, all tabs are replaced with
non-breaking spaces (HTML   entity). This is likely what
you are seeing.

I will fix the mail server configuration and resend the series.

Sorry for the inconvenience, and thanks again for your patience.

Best regards,
Junyang Han

[-- Attachment #1.1.2: Type: text/html , Size: 2491 bytes --]