From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1B3231E826; Sat, 9 May 2026 12:25:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.3 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778329537; cv=none; b=A4S70DOaJILDG9xH9qoWH5inGCZBS9/JtjuUfYwxj1p12fz88WOL7dm7oHRHqg/hYg77EljFQmpAjeRXaNvY7CRhiCt+/80HstHyw/pzl6rW3tWOPJ6/cuhdcQVy53mGKnhtFNRTaRubVO67oLf+4ub63iU0PjMGcKX8Ihb3l+A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778329537; c=relaxed/simple; bh=SZzgKhru9GjGOWN+5OHlyXNBAsMahYKqH36gc5+DQe0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pNChEtZxx3h+HELntHuOR2hg5e0va40kJ4gKapykI5BU0BUsbbeOR3wrKZWw2urcALy2FHf317O3/ZbxTigewNne7kN96wMsO92WtwhJvzU97Iv2U06ZuZZkPoUDCIe+RDIaLeyozfpdtADYSnCxcKi59rYeS9HE6e/Ej44h6JI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=T2eSd+wz; arc=none smtp.client-ip=117.135.210.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="T2eSd+wz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=Fk g6lQ4GJs9udxWaNzC8LJuS4vQnXLrNAT5MiyCXhPU=; b=T2eSd+wzsdcOCHqlYG VQR95q68JBfX7qGJJ3FpFYZ3Evck1QYSejkNGH1taLYtk7ILgs1YIrIis0llP70D XFPZlGpiLz7tsBJvmav7AkP4+sJHpkEeIHrNMsMk69Ygxqm6fiis9Iv6R1QICwLK mnY+Tspn8BkZECJA6dSPazTkk= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g1-1 (Coremail) with SMTP id _____wAXMmqCJ_9pzPqMAQ--.11251S2; Sat, 09 May 2026 20:24:35 +0800 (CST) From: albin_yang@163.com To: 3chas3@gmail.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org Cc: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, albinwyang@tencent.com Subject: [PATCH] net: atm: fix skb leak in sigd_send() default branch Date: Sat, 9 May 2026 20:23:58 +0800 Message-ID: <20260509122358.1102997-1-albin_yang@163.com> X-Mailer: git-send-email 2.43.7 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:_____wAXMmqCJ_9pzPqMAQ--.11251S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7Xr45Xw17Kr13XrWrKF4DArb_yoW3tFX_Wa 48trsagrW8Xr4fCws3Jr45JrWfKw4rur1rXrWxKFWUJa42yr1UKr9YkrykJ34UKw48tFy5 uws5ur95K3WYkjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8I_M3UUUUU== X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/xtbCzgNE5mn-J4P4OQAA3c From: Wei Yang The default branch in sigd_send() calls sock_put() and returns -EINVAL without freeing the skb, while all other exit paths do so. Add the missing dev_kfree_skb() before sock_put() to fix the leak. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Wei Yang --- net/atm/signaling.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/atm/signaling.c b/net/atm/signaling.c index ae88a5d2f29b..0000000000000 100644 --- a/net/atm/signaling.c +++ b/net/atm/signaling.c @@ -179,6 +179,7 @@ static int sigd_send(struct atm_vcc *vcc, struct sk_buff *skb) default: pr_alert("bad message type %d\n", (int)msg->type); + dev_kfree_skb(skb); /* Paired with find_get_vcc(msg->vcc) above */ sock_put(sk); return -EINVAL; }