From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0E3413A86C for ; Sun, 10 May 2026 08:15:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778400950; cv=none; b=Qn8dSC1TMmZfFzr3IyAao9FscN0ec3tjsLY1DxU1ConeCTEWIjtRpr3KBuGj5Ow2Sioc+YEdwrwgAgobu8EA7QzfYGYhXiZbmFKkljChL2f/PvkUsFYp/34eOnO+9SqzlboyO22UKJYW/qF6JkMQbAWvVUbZAUn8XCe+SjjliuM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778400950; c=relaxed/simple; bh=rqdP1dVHU2d5Wwe1A02epIYY7UuprbmmmJ5IdRaVijk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OO0SZl/YcoK1dKi83Akc/QkqUVyfhAcNQvB9bnZMun4L7g52LY7xajA7AKihOlylLPPbhZjFSNctMjMnWbN9U2hhpMQnphqZBA1xfKSHRk6wLTftSd8JYcnm0Yn66faaRiBXI86mAsvtHKZV2pNEWoFy5CTOHKcE0q4DgtCacr0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=eILlLV/w; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=OtJhikpK; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=eILlLV/w; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=OtJhikpK; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="eILlLV/w"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="OtJhikpK"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="eILlLV/w"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="OtJhikpK" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5D47B6B4AB; Sun, 10 May 2026 08:15:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778400943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gcSX08BpEo4UlsqWRJioDN4Re3zSnDtP4ShcRwE1jVA=; b=eILlLV/wqenzWpkvXX8AdEapFBmzYm4WUaquwdkORkvOyPXnOMHY9i+9r1C8si+A5UimYw DPZtETMU5Kz+JQeh7VHhc+45uQpp/KJmY20gJ5qX9ETADbqQnuk8VkkHcUGMmoiLavez6c c3Mi+j7+TDKUTRIWDZey4a/cr3h/uSQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778400943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gcSX08BpEo4UlsqWRJioDN4Re3zSnDtP4ShcRwE1jVA=; b=OtJhikpK1DajUfx0LGbBYDXokGgieFiu9X7r+zgTeCdPXB7G4DHBKpHWdF6icyUNS34xAc yh16Yf5oJgMJSCBg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="eILlLV/w"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OtJhikpK DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778400943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gcSX08BpEo4UlsqWRJioDN4Re3zSnDtP4ShcRwE1jVA=; b=eILlLV/wqenzWpkvXX8AdEapFBmzYm4WUaquwdkORkvOyPXnOMHY9i+9r1C8si+A5UimYw DPZtETMU5Kz+JQeh7VHhc+45uQpp/KJmY20gJ5qX9ETADbqQnuk8VkkHcUGMmoiLavez6c c3Mi+j7+TDKUTRIWDZey4a/cr3h/uSQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778400943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gcSX08BpEo4UlsqWRJioDN4Re3zSnDtP4ShcRwE1jVA=; b=OtJhikpK1DajUfx0LGbBYDXokGgieFiu9X7r+zgTeCdPXB7G4DHBKpHWdF6icyUNS34xAc yh16Yf5oJgMJSCBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BD09A593A3; Sun, 10 May 2026 08:15:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id wBJDK64+AGrIDgAAD6G6ig (envelope-from ); Sun, 10 May 2026 08:15:42 +0000 From: Fernando Fernandez Mancera To: netdev@vger.kernel.org Cc: linux-kselftest@vger.kernel.org, horms@kernel.org, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, dsahern@kernel.org, davem@davemloft.net, Fernando Fernandez Mancera , Nicolas Dichtel Subject: [PATCH 2/3 net-next v4] ipv4: handle devconf post-set actions on netlink updates Date: Sun, 10 May 2026 10:15:27 +0200 Message-ID: <20260510081528.5257-2-fmancera@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260510081528.5257-1-fmancera@suse.de> References: <20260510081528.5257-1-fmancera@suse.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Level: X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,6wind.com:email,suse.de:dkim,suse.de:email,suse.de:mid]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCPT_COUNT_SEVEN(0.00)[10]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: 5D47B6B4AB X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spam-Flag: NO X-Spam-Score: -3.01 When IPv4 device configuration parameters are updated via netlink, the kernel currently only updates the value. This bypasses several post-modification actions that occur when these same parameters are updated via sysctl, such as flushing the routing cache or emitting RTM_NEWNETCONF notifications. This patch addresses the inconsistency by calling the devinet_conf_post_set() helper inside inet_set_link_af(). If a flush is required, we defer it until the netlink attribute parsing loop completes. This ensures consistent behavior and side-effects for devconf changes, regardless of whether they are initiated via sysctl or netlink. Reviewed-by: Nicolas Dichtel Signed-off-by: Fernando Fernandez Mancera --- v2: handled forwarding notification and disabling LRO v3: no changes v4: no changes --- net/ipv4/devinet.c | 29 +++++++++++++++++++++++++++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index 8300516fb38f..a35b72662e43 100644 --- a/net/ipv4/devinet.c +++ b/net/ipv4/devinet.c @@ -2161,6 +2161,20 @@ static bool devinet_conf_post_set(struct net *net, struct ipv4_devconf *cnf, NETCONFA_IGNORE_ROUTES_WITH_LINKDOWN, ifindex, cnf); break; + case IPV4_DEVCONF_FORWARDING: + if (new == 1) { + /* it is safe to use container_of() because forwarding case + * is only used by the netlink path + */ + struct in_device *idev = container_of(cnf, struct in_device, cnf); + + netif_disable_lro(idev->dev); + } + + inet_netconf_notify_devconf(net, RTM_NEWNETCONF, + NETCONFA_FORWARDING, + ifindex, cnf); + return true; default: break; } @@ -2173,6 +2187,8 @@ static int inet_set_link_af(struct net_device *dev, const struct nlattr *nla, { struct in_device *in_dev = __in_dev_get_rtnl(dev); struct nlattr *a, *tb[IFLA_INET_MAX+1]; + struct net *net = dev_net(dev); + bool flush_cache = false; int rem; if (!in_dev) @@ -2182,8 +2198,17 @@ static int inet_set_link_af(struct net_device *dev, const struct nlattr *nla, return -EINVAL; if (tb[IFLA_INET_CONF]) { - nla_for_each_nested(a, tb[IFLA_INET_CONF], rem) - ipv4_devconf_set(in_dev, nla_type(a), nla_get_u32(a)); + nla_for_each_nested(a, tb[IFLA_INET_CONF], rem) { + int old_value = ipv4_devconf_get(in_dev, nla_type(a)); + int new_value = nla_get_u32(a); + + ipv4_devconf_set(in_dev, nla_type(a), new_value); + if (devinet_conf_post_set(net, &in_dev->cnf, nla_type(a), new_value, + old_value, dev->ifindex)) + flush_cache = true; + } + if (flush_cache) + rt_cache_flush(net); } return 0; -- 2.53.0