From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f202.google.com (mail-qt1-f202.google.com [209.85.160.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4566366DB5 for ; Sun, 10 May 2026 09:14:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778404501; cv=none; b=aMK0lxNwNIRCVGLZjB09QQd8JMM7o5nu6knPPD8zOdjhjbp3LtQcKCx5iU8cJqwUAQ3cyFS8cp//0keqWVJKo63JxNjjBXTHICnn92O7yrKMP1qjNLGayvBPh64jnG7IQBvvWDim8utyZVyn4yysB3S1dFVS5EKIsRNTCuy4Uek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778404501; c=relaxed/simple; bh=+KCAirgd7r7eFIl2O0hGNpNJ3U6W5UCLU8KE4ODXhco=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=lgjCPui72fGSjNgX88qQCh7ckzCqNSWdpNpsCgyQC4zXEwZhmmDhHcyb6UCi8HFtQxogYpoFMk3oW/FdO7XnEd3wVrDo42nLfOjWdTbjvJjiYxb/Hn5dREtlghTFDpgF1HBhnaSul+5+ynoZAgGw96eKRjpGASZ9U73KafASQgw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--edumazet.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=NJ8orM6/; arc=none smtp.client-ip=209.85.160.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--edumazet.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="NJ8orM6/" Received: by mail-qt1-f202.google.com with SMTP id d75a77b69052e-50e2592ea3bso7388521cf.2 for ; Sun, 10 May 2026 02:14:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778404499; x=1779009299; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=VOglpBhTFNNNTPCJN+FqA5y+7b269n1Bm9vi5MkWMDc=; b=NJ8orM6/cmQ+zb9lX49AVGokQNxMvkM7dDgvLRZTWNzR7VNe3B2aWP00sBuDhBTXjb 8fVr6SpH8Bt7mD0+AcPlDDJx/QNt8BZ3vgElNFC0T/0JOKs080lYt31hmtYKwhq+zk+W 4hqR4a7q4eoMfBQ2ec1d++SmN1E7JKSK7kSMFSVZ36lthKfnehLdlFbypndwmkAVCG6Q kX8uxZraMkYI2VcKd0hkQXSuj6BB1lcVuvUrU1fJRDTpdEQheAs0TCXvu1iMGJq8HJwA X9JAR6utNdt9wvv00U+kLwDjVd1ctvKJxT+JLnnC46FmWw+G4njDA/WOMrA7dbyTDt+w J3hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778404499; x=1779009299; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VOglpBhTFNNNTPCJN+FqA5y+7b269n1Bm9vi5MkWMDc=; b=LSV0mo0sCesr47ethna+PsJcNwyt7FS0QQ/N5ax5Erm05gCHUSphSDKCTO4tFGtk89 8bM3I1cvxrUmPT9+du4geHqBqS2V5LScoUx2w45Na2Z9+FiyuBQW2ywDgX8gOpfn1hXE EGP5s0xdqYW/EjvI2frzrw0tR5CifK8qKdgYYBaQ3XxKX7VXTprdvjQY4+VXtvqMZ2xa pfwvB95nHmIEkdCLOtCUGNNRDrmyd2rr0XLKyfDdlIZAxMEOX9i0fxavbYAJ8IleEQYO iGctoeFK9jMZvtcd2ae0pbNG2RzS/llsM0hB1OGTSH8Hk6S/Zg6DxCckyJNYbDqrUBKz bf9w== X-Forwarded-Encrypted: i=1; AFNElJ8reB6wyP+grjydF/X6/3Imric7rgS4psVhIkHu97Ll/ACYX7RWVjEu03Q0BsJ6ZN9kkR1gmHg=@vger.kernel.org X-Gm-Message-State: AOJu0YwGMWs5B5iQVrynaTZ7ra0E3FxkWqOtTvZ10mzXQf3Sngjrhafw pImpRtr/lKXVphjKwTpCGKHB0xi6K/iuNB6Jomk63RTjmOaO08mkr/wnTJj5QKU8GUy8sjNxe0q 8sIR5sfJmexZ2bg== X-Received: from qtbhf6.prod.google.com ([2002:a05:622a:6086:b0:50f:9c36:1323]) (user=edumazet job=prod-delivery.src-stubby-dispatcher) by 2002:a05:622a:5a9b:b0:50e:6139:492b with SMTP id d75a77b69052e-51461c3620dmr260327941cf.23.1778404498588; Sun, 10 May 2026 02:14:58 -0700 (PDT) Date: Sun, 10 May 2026 09:14:48 +0000 In-Reply-To: <20260510091455.4039245-1-edumazet@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260510091455.4039245-1-edumazet@google.com> X-Mailer: git-send-email 2.54.0.563.g4f69b47b94-goog Message-ID: <20260510091455.4039245-2-edumazet@google.com> Subject: [PATCH v2 net-next 1/8] net/sched: add READ_ONCE() in gnet_stats_add_queue[_cpu] From: Eric Dumazet To: "David S . Miller" , Jakub Kicinski , Paolo Abeni Cc: Simon Horman , Jamal Hadi Salim , Jiri Pirko , Victor Nogueira , netdev@vger.kernel.org, eric.dumazet@gmail.com, Eric Dumazet Content-Type: text/plain; charset="UTF-8" Stats are read locklessly, add READ_ONCE() to prevent load-tearing. Write side will be handled in separate patches. Signed-off-by: Eric Dumazet --- net/core/gen_stats.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/net/core/gen_stats.c b/net/core/gen_stats.c index b71ccaec0991461333dbe465ee619bca4a06e75b..1a2380e74272de8eaf3d4ef453e56105a31e9edf 100644 --- a/net/core/gen_stats.c +++ b/net/core/gen_stats.c @@ -345,11 +345,11 @@ static void gnet_stats_add_queue_cpu(struct gnet_stats_queue *qstats, for_each_possible_cpu(i) { const struct gnet_stats_queue *qcpu = per_cpu_ptr(q, i); - qstats->qlen += qcpu->qlen; - qstats->backlog += qcpu->backlog; - qstats->drops += qcpu->drops; - qstats->requeues += qcpu->requeues; - qstats->overlimits += qcpu->overlimits; + qstats->qlen += READ_ONCE(qcpu->qlen); + qstats->backlog += READ_ONCE(qcpu->backlog); + qstats->drops += READ_ONCE(qcpu->drops); + qstats->requeues += READ_ONCE(qcpu->requeues); + qstats->overlimits += READ_ONCE(qcpu->overlimits); } } @@ -360,11 +360,11 @@ void gnet_stats_add_queue(struct gnet_stats_queue *qstats, if (cpu) { gnet_stats_add_queue_cpu(qstats, cpu); } else { - qstats->qlen += q->qlen; - qstats->backlog += q->backlog; - qstats->drops += q->drops; - qstats->requeues += q->requeues; - qstats->overlimits += q->overlimits; + qstats->qlen += READ_ONCE(q->qlen); + qstats->backlog += READ_ONCE(q->backlog); + qstats->drops += READ_ONCE(q->drops); + qstats->requeues += READ_ONCE(q->requeues); + qstats->overlimits += READ_ONCE(q->overlimits); } } EXPORT_SYMBOL(gnet_stats_add_queue); -- 2.54.0.563.g4f69b47b94-goog