From: David Laight <david.laight.linux@gmail.com>
To: Steffen Klassert <steffen.klassert@secunet.com>
Cc: <netdev@vger.kernel.org>, Sabrina Dubroca <sd@queasysnail.net>,
Simon Horman <horms@kernel.org>,
Tobias Brunner <tobias@strongswan.org>,
Herbert Xu <herbert@gondor.apana.org.au>, <devel@linux-ipsec.org>
Subject: Re: [PATCH ipsec-next v2] esp: Consolidate esp4 and esp6
Date: Sun, 10 May 2026 12:20:15 +0100 [thread overview]
Message-ID: <20260510122015.02dcbf4d@pumpkin> (raw)
In-Reply-To: <afr4ipktV91sA8WU@secunet.com>
On Wed, 6 May 2026 10:15:06 +0200
Steffen Klassert <steffen.klassert@secunet.com> wrote:
> This patch merges common code of esp4.c and esp6.c into
> xfrm_esp.c. This almost halves the size of the ESP
> implementation for the price of three indirect calls
> on UDP/TCP encapsulation. No functional changes.
Merging into a new file make it very difficult to see the changes
(both now and in the future).
It might be better to merge the changes into either esp4.c or esp6.c
and then rename the file afterwards.
Since there are only two possibilities (ipv4 and ipv6) conditional
calls would be better than indirect ones.
But it is pretty impossible to see where that happens in the changes.
-- David
prev parent reply other threads:[~2026-05-10 11:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 8:15 [PATCH ipsec-next v2] esp: Consolidate esp4 and esp6 Steffen Klassert
2026-05-09 13:56 ` Simon Horman
2026-05-10 8:06 ` Steffen Klassert
2026-05-09 14:00 ` Simon Horman
2026-05-10 11:20 ` David Laight [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260510122015.02dcbf4d@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=devel@linux-ipsec.org \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
--cc=steffen.klassert@secunet.com \
--cc=tobias@strongswan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox