From: Marco Crivellari <marco.crivellari@suse.com>
To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: Tejun Heo <tj@kernel.org>, Lai Jiangshan <jiangshanlai@gmail.com>,
Frederic Weisbecker <frederic@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Marco Crivellari <marco.crivellari@suse.com>,
Michal Hocko <mhocko@suse.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
Ethan Nelson-Moore <enelsonmoore@gmail.com>,
Haren Myneni <haren@linux.ibm.com>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
MD Danish Anwar <danishanwar@ti.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Mika Westerberg <westeri@kernel.org>,
Nicholas Piggin <npiggin@gmail.com>,
Nick Child <nnac123@linux.ibm.com>,
Petko Manolov <petkan@nucleusys.com>,
Rick Lindsley <ricklind@linux.ibm.com>,
Roger Quadros <rogerq@kernel.org>,
Yehezkel Bernat <YehezkelShB@gmail.com>
Subject: [RFC PATCH net-next 0/5] net: Move system_long_wq to system_dfl_long_wq
Date: Mon, 11 May 2026 11:28:35 +0200 [thread overview]
Message-ID: <20260511092846.120141-1-marco.crivellari@suse.com> (raw)
Hello,
Currently the code uses the per-cpu workqueue system_long_wq to schedule
long running works.
Unbound works could benefit from scheduler task placement, to optimize
performance and power consumption. Another good reason to have this unbound,
is the "queue_delayed_work()" function, used to enqueue the work item.
More details on this will follow in the next section.
Recently, a new unbound workqueue specific for long running work has been
added:
c116737e972e ("workqueue: Add system_dfl_long_wq for long unbound works")
~~~ Details about queue_delayed_work ~~~
system_long_wq is a per-cpu workqueue and it is used as a parameter of
queue_delayed_work(). This function schedule an item that it will later
be enqueued (once the timer will fire). __queue_delayed_work() does the job
receiving as "cpu" WORK_CPU_UNBOUND:
if (housekeeping_enabled(HK_TYPE_TIMER)) {
// [....]
} else {
if (likely(cpu == WORK_CPU_UNBOUND))
add_timer_global(timer);
else
add_timer_on(timer, cpu);
}
The timer is global, so can fire everywhere, and the work item will be
enqueued where the timer fired.
Since the workqueue work doesn't rely on per-cpu variables, there is no
obvious reason that justify the use of a per-cpu workqueue. So change the
workqueue with the new system_dfl_long_wq, so that the used workqueue is
now unbound and can benefit from scheduler task placement.
Thanks!
Marco Crivellari (5):
ibmvnic: Move long delayed work on system_dfl_long_wq
net: ti: icssg-stats: Move long delayed work on system_dfl_long_wq
net: thunderbolt: Move long delayed work on system_dfl_long_wq
net: usb: pegasus: Move long delayed work on system_dfl_long_wq
r8152: Move long delayed work on system_dfl_long_wq
drivers/net/ethernet/ibm/ibmvnic.c | 4 ++--
drivers/net/ethernet/ti/icssg/icssg_stats.c | 2 +-
drivers/net/thunderbolt/main.c | 7 ++++---
drivers/net/usb/pegasus.c | 9 +++++----
drivers/net/usb/r8152.c | 7 ++++---
5 files changed, 16 insertions(+), 13 deletions(-)
--
2.54.0
next reply other threads:[~2026-05-11 9:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 9:28 Marco Crivellari [this message]
2026-05-11 9:28 ` [RFC PATCH net-next 1/5] ibmvnic: Move long delayed work on system_dfl_long_wq Marco Crivellari
2026-05-11 9:28 ` [RFC PATCH net-next 2/5] net: ti: icssg-stats: " Marco Crivellari
2026-05-11 10:14 ` Richard Cheng
2026-05-11 9:28 ` [RFC PATCH net-next 3/5] net: thunderbolt: " Marco Crivellari
2026-05-11 9:28 ` [RFC PATCH net-next 4/5] net: usb: pegasus: " Marco Crivellari
2026-05-11 9:28 ` [RFC PATCH net-next 5/5] r8152: " Marco Crivellari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260511092846.120141-1-marco.crivellari@suse.com \
--to=marco.crivellari@suse.com \
--cc=YehezkelShB@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=bigeasy@linutronix.de \
--cc=chleroy@kernel.org \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=enelsonmoore@gmail.com \
--cc=frederic@kernel.org \
--cc=haren@linux.ibm.com \
--cc=jiangshanlai@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maddy@linux.ibm.com \
--cc=mhocko@suse.com \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=nnac123@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=pabeni@redhat.com \
--cc=petkan@nucleusys.com \
--cc=ricklind@linux.ibm.com \
--cc=rogerq@kernel.org \
--cc=tj@kernel.org \
--cc=westeri@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox