Netdev List
 help / color / mirror / Atom feed
From: Minxi Hou <houminxi@gmail.com>
To: netdev@vger.kernel.org
Cc: aconole@redhat.com, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v9 0/2] selftests: openvswitch: add pop_vlan test
Date: Mon, 11 May 2026 20:05:43 +0800	[thread overview]
Message-ID: <20260511120543.390702-1-houminxi@gmail.com> (raw)
In-Reply-To: <20260509135423.3433910-1-houminxi@gmail.com>

Found a few issues in v9 that need fixing, will respin as v10:

- Commit message for patch 1 references removing MAX_ENCAP_DEPTH,
  which was dropped in an earlier revision. Needs cleanup.

- Masked VLAN format string produces output that cannot be parsed
  back (round-trip failure for vlan key with masks).

- Negative test in patch 2 lacks a return flow for in_port(2),
  so ping fails regardless of whether pop_vlan works correctly.
  Need to add a return flow to make the negative case meaningful.

Minxi

      parent reply	other threads:[~2026-05-11 12:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-09 13:54 [PATCH net-next v9 0/2] selftests: openvswitch: add pop_vlan test Minxi Hou
2026-05-09 13:54 ` [PATCH net-next v9 1/2] selftests: openvswitch: add vlan() and encap() flow string parsing Minxi Hou
2026-05-09 13:54 ` [PATCH net-next v9 2/2] selftests: openvswitch: add pop_vlan test Minxi Hou
2026-05-11 12:05 ` Minxi Hou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260511120543.390702-1-houminxi@gmail.com \
    --to=houminxi@gmail.com \
    --cc=aconole@redhat.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox