Netdev List
 help / color / mirror / Atom feed
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Josua Mayer <josua@solid-run.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>, Frank Li <Frank.Li@nxp.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
	Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Yazan Shhady <yazan.shhady@solid-run.com>,
	Mikhail Anikin <mikhail.anikin@solid-run.com>,
	Alexander Dahl <ada@thorsis.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Conor Dooley <conor.dooley@microchip.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] arm64: dts: imx8dxl: Add SolidRun SoM and HummingBoard
Date: Mon, 11 May 2026 15:50:53 +0300	[thread overview]
Message-ID: <20260511125053.xgzqic62zhhdjyn5@skbuf> (raw)
In-Reply-To: <f0fdea25-6b2d-4b64-b925-a3f30c8e044c@solid-run.com>

On Mon, May 11, 2026 at 12:30:35PM +0000, Josua Mayer wrote:
> I had the reverse understanding, the switch port specifies rgmii-id,
> and the cpu port specifies "rgmii".
> 
> The switch port has mode rgmii-id, indicating that someone should add delays.

Yes, but my understanding is that it is out of scope for the phy-mode = "rgmii-id"
to decide who. It just means that there are no PCB delays.

> It is a fixed link without PHY, so switch must add the delays.

This is an obsolete interpretation of phy-mode. sja1105_parse_rgmii_delays()
explains that in the new interpretation, 'rgmii' or 'rgmii-id' doesn't
indicate anything. The switch inserts the delays because of the
"rx-internal-delay-ps" and "tx-internal-delay-ps" properties.

> From the cpu (eqos) perspcetive it is also a fixed link without phy,
> so I specify rgmii indicating nobody should add delays.
> 
> Is this correct?

My understanding may be wrong, but I directly quote:
- If the PCB does not add these delays via extra long traces,
  'rgmii-id' should be used. Here, 'id' refers to 'internal delay',
  where either the MAC or PHY adds the delay.
- When the PCB does not implement the delays, the MAC or PHY must.
  As such, this is software configuration, and so not described in
  Device Tree.

> >
> >> +	pinctrl-0 = <&eqos_pins>;
> >> +	pinctrl-names = "default";
> >> +	status = "okay";
> >> +
> >> +	fixed-link {
> >> +		full-duplex;
> >> +		speed = <1000>;
> >> +	};
> >> +};
> >> +
> >> +&lpspi0 {
> >> +	cs-gpios = <&lsio_gpio1 8 GPIO_ACTIVE_LOW>, <&lsio_gpio1 7 GPIO_ACTIVE_LOW>;
> >> +	pinctrl-0 = <&lpspi0_pins>, <&switch_pins>;
> >> +	pinctrl-names = "default";
> >> +	status = "okay";
> >> +
> >> +	ethernet-switch@0 {
> >> +		compatible = "nxp,sja1110a";
> >> +		reg = <0>;
> >> +		reset-gpios = <&lsio_gpio4 3 GPIO_ACTIVE_LOW>;
> >> +		spi-max-frequency = <4000000>;
> >> +
> >> +		ethernet-ports {
> >> +			#address-cells = <1>;
> >> +			#size-cells = <0>;
> >> +
> >> +			/* 100Base-TX on connector J26 */
> >> +			port@1 {
> > Some people might prefer seeing ethernet-port@N instead of port@N, to
> > fully avoid confusion with dtschema/schemas/graph.yaml (although, the
> > container node being ethernet-ports now, the confusion should be
> > avoidable).
> >
> > Also, if you ever perform device tree fixups from the bootloader (like
> > for setting status = "disabled" to status = "okay" for the ports that go
> > to addon boards), please never hardcode fixup paths,
> 
> I was expecting device-tree overlays to be used, in which case aliases
> are not needed.

Ok, what do you need for device tree overlays to reference these nodes?
Don't you need a label for them to appear in /__symbols__? Or do you
reference by "&{/absolute/path}" (still bad)?

> > but always use eth
> > aliases to get to them.
> However if it is okay to add eth[0-9]+ aliases also for switch ports, I'll add them.

Absolutely ok.

> > This is in case the port node names ever change,
> > to avoid bootloader regressions.
> Good point!

I don't think there's any downside to adding aliases, so please do, in
case anyone needs them, they should be there.

  reply	other threads:[~2026-05-11 12:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 10:11 [PATCH v4 0/2] arm64: dts: imx8dxl: Add SolidRun SoM and HummingBoard Josua Mayer
2026-05-11 10:11 ` [PATCH v4 1/2] dt-bindings: arm: fsl: Add SolidRun i.MX8DXL " Josua Mayer
2026-05-11 10:11 ` [PATCH v4 2/2] arm64: dts: imx8dxl: Add SolidRun " Josua Mayer
2026-05-11 11:24   ` Vladimir Oltean
2026-05-11 12:30     ` Josua Mayer
2026-05-11 12:50       ` Vladimir Oltean [this message]
2026-05-11 13:29     ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260511125053.xgzqic62zhhdjyn5@skbuf \
    --to=vladimir.oltean@nxp.com \
    --cc=Frank.Li@nxp.com \
    --cc=ada@thorsis.com \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=josua@solid-run.com \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikhail.anikin@solid-run.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=yazan.shhady@solid-run.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox