From: Jinliang Zheng <alexjlzheng@gmail.com>
To: sd@queasysnail.net
Cc: albinwyang@tencent.com, alexjlzheng@gmail.com,
alexjlzheng@tencent.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com,
hannes@stressinduktion.org, horms@kernel.org, kuba@kernel.org,
kuniyu@google.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, pabeni@redhat.com,
shenyangyang4@huawei.com
Subject: Re: [PATCH net v3 1/3] macsec: introduce dedicated workqueue for SA crypto cleanup
Date: Mon, 11 May 2026 22:00:05 +0800 [thread overview]
Message-ID: <20260511140005.2619263-1-alexjlzheng@tencent.com> (raw)
In-Reply-To: <agHahVF3yq9AuLmj@krikkit>
On Sun, 11 May 2026, Sabrina Dubroca wrote:
> > + macsec_wq = alloc_ordered_workqueue("macsec", 0);
>
> Why did you pick an ordered workqueue instead of a normal one?
I chose an ordered workqueue for its serialized execution, which
avoids potential ordering issues between concurrent SA destructions.
In hindsight, there is no actual ordering dependency between SA
cleanups, so a normal workqueue is sufficient here.
Should I send a v4 with that switched to alloc_workqueue()?
Thanks,
Jinliang
> > +err_destroy_wq:
> > + /* Precautionary, mirrors macsec_exit() to stay safe if work
> > + * ever becomes queueable before this point in the future.
> > + */
>
> I don't think this comment is really necessary, but ok.
>
> (I missed the discussion on v2, it's not possible to create SAs at
> this point, but it's reasonable to add the rcu_barrier here)
next prev parent reply other threads:[~2026-05-11 14:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-09 3:33 [PATCH net v3 0/3] macsec: use rcu_work to fix crypto cleanup in softirq context alexjlzheng
2026-05-09 3:33 ` [PATCH net v3 v3 1/3] macsec: introduce dedicated workqueue for SA crypto cleanup alexjlzheng
2026-05-11 13:32 ` Sabrina Dubroca
2026-05-11 14:00 ` Jinliang Zheng [this message]
2026-05-11 14:37 ` [PATCH net " Sabrina Dubroca
2026-05-11 14:49 ` Jinliang Zheng
2026-05-09 3:33 ` [PATCH net v3 v3 2/3] macsec: use rcu_work to defer RX SA crypto cleanup out of softirq alexjlzheng
2026-05-11 13:50 ` Sabrina Dubroca
2026-05-09 3:33 ` [PATCH net v3 v3 3/3] macsec: use rcu_work to defer TX " alexjlzheng
2026-05-11 13:50 ` Sabrina Dubroca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260511140005.2619263-1-alexjlzheng@tencent.com \
--to=alexjlzheng@gmail.com \
--cc=albinwyang@tencent.com \
--cc=alexjlzheng@tencent.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hannes@stressinduktion.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
--cc=shenyangyang4@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox