From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f175.google.com (mail-dy1-f175.google.com [74.125.82.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C59BA402B83 for ; Mon, 11 May 2026 15:31:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778513469; cv=none; b=cjP9FTUNM6NilZo9TdCj9nWGqh8pqyl13uFidzhEU/GDOqGDS6wF8iJMyaXIdy4aiyW6Gyvjacgct6sXyMNdnEXCRNVi4DFZ7SGvsxp2/SUlVBtcs+EFfcn4DkuL5cIeJ+GLpN7Eih13f5jIs/E6nOiGRCAqB1rNlbdvkUil2To= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778513469; c=relaxed/simple; bh=SgSiyMa+zj6kS5NN2ljh0uTfNzIqhtjSmTnWZr5hJjE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hyDfmeP8jN5+opdFbu0elYoymaQlqmSR07tuet9h23fdA6x6mzIl5pod6KF63zEO78enk6tXor+QD+BaK61u1g30WAc71P72Z/qvJ+G9J20tut7l1hWBP+pos4hQT1e79n9rHrfX+V6vN3GTbz3AyG67DOyBR4+i5TPpo4T7pSk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pMQBQqes; arc=none smtp.client-ip=74.125.82.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pMQBQqes" Received: by mail-dy1-f175.google.com with SMTP id 5a478bee46e88-2b4520f6b32so7688515eec.0 for ; Mon, 11 May 2026 08:31:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778513467; x=1779118267; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7YautqB2qa5gfJ4hkw5WBxG8wVsiKhkZ8EXwO8lSOmU=; b=pMQBQqesbR4y6bn4SzKr7p4IWybaORq/VdprQbp2mfFYmmrXN63KAQ0fMAoREf3rA1 2Sef619bHhyHcUF84dn8st6oFlN53mcr7l+HDAz0UoKiCUphVFiehIvNPDGUPpBWj2/p dvgL+ZUol+DdODhNrmvOupGbn/S7Xr0NorDhn6LlSPb/bVT8B8FAes4VuRtChnDT0DEI ZWxijtpKUP3sGDgqh4WHVj1HKDkyYlxngDBDhCXUkRMnCWTRW9Kdf4qK2EREP9g7uvR5 u2HlzEvL00EXIbtbe8ScBLBTYqTwGqcdTJTiQ5zH+5PbwiISKRbg9LG6rUL0pKKs1uoj pFxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778513467; x=1779118267; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7YautqB2qa5gfJ4hkw5WBxG8wVsiKhkZ8EXwO8lSOmU=; b=o/XKd8psArDLAH4lxJASFyGyHO0Y4AOnZIIyWYrIIddLvgQ1MR+rzih2wy0ACr+e55 TZ6v60Sv68r7dklMf2W0eScdjCT/KQzWv0DElMDJLTVSm7cGbIAA80hJq79OPg6kZp8M wAmZsFEC0SXn6wgUnCD68GbW5YqknFLpJIW+3e9WapZD+tCWwqmsi9XK2tA72xsOmz5f FMy8Y5AjAdP56Hboltma6lHzUgTHSaOR6uv2NQb2OCFoTmxhyHu2qWt7/PJzIayZ/CxG +Yd9ueWh2lbGbJnvoiVYof2wTedxXwYjHqwHQZmeIXZBCiMEN7dwGzHpdn0tUW3EFKta iP7w== X-Gm-Message-State: AOJu0YzNTB8Eel/bAyU/bUZ1Axop2mv72TarC1IYrrlsMyr78dTOgcQT e4+IdW1FKkOb2ZCHSc96SPeT1CFhwTU4afiW4yP21BKS8pYCR4yc8+tG X-Gm-Gg: Acq92OFyYaVq0WSbtEkFCD1yh/LD9GXsqX7DofHRilviYVwtHc20xEQcURA5k0De3tZ ZGaqHAPvRRmu3Jiyjq/URI44Hw227AAc/XJS+7a2QAoY9q7pGV7B5/daRby9t4xWLWnPLv6qNRv CrktLEeluFmGsWmMzDB9ySCI73buCLFm8MInRd2hsCjgtnG4iOltLXfIeHbXix468lSS9MM0tqK II6PC95fPHPNAmjewqheXPPxh6lXxqmuKW/wulLNVVKhjoeQvIYlwD1I1Qwt4aubN9QUzakchF5 jWy5qNZhF5IEK1TyYOVaMdWYV9RCr0qJjMypaj1Ywmh0koG2QIzswp2t3y+LVqQ/k7uYoVsVbit wO50042dzXP71ZKAsvyox5CsaaOg7qRTcLEBvhRT4CmsRl/kEqaVja9JHDQU5mKkSiPYOChFZlY p8t99agVLHh9AnNGDGU/TNZlcDR2yXntOq3wU= X-Received: by 2002:a05:7022:4182:b0:12a:6c7e:bef2 with SMTP id a92af1059eb24-131967d5082mr12940006c88.7.1778513466470; Mon, 11 May 2026 08:31:06 -0700 (PDT) Received: from VM-16-24-fedora.. ([43.153.32.141]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f8859eafcdsm17464080eec.6.2026.05.11.08.31.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 08:31:06 -0700 (PDT) From: alexjlzheng@gmail.com X-Google-Original-From: alexjlzheng@tencent.com To: sd@queasysnail.net, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, hannes@stressinduktion.org, albinwyang@tencent.com, shenyangyang4@huawei.com, kuniyu@google.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jinliang Zheng Subject: [PATCH net v4 v4 1/3] macsec: introduce dedicated workqueue for SA crypto cleanup Date: Mon, 11 May 2026 23:30:58 +0800 Message-ID: <20260511153102.2640368-2-alexjlzheng@tencent.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20260511153102.2640368-1-alexjlzheng@tencent.com> References: <20260511153102.2640368-1-alexjlzheng@tencent.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Jinliang Zheng Introduce a dedicated ordered workqueue, macsec_wq, which will be used by subsequent patches to defer SA crypto cleanup (crypto_free_aead and related teardown) out of softirq context. Using a dedicated workqueue instead of system_wq allows macsec_exit() to drain exactly the work items belonging to this module via destroy_workqueue(), without interfering with unrelated work items on system_wq or causing unexpected delays elsewhere. rcu_barrier() in macsec_exit() ensures all in-flight rcu_work callbacks have enqueued their work items before destroy_workqueue() drains and destroys the queue, making the two-step teardown correct and complete. The same sequence is kept in the error path of macsec_init() as a precaution, to mirror macsec_exit() and stay safe if work ever becomes queueable before this point in the future. While at it, rename the error labels in macsec_init() from the resource-named style (rtnl:, notifier:, wq:) to the err_xxx: style (err_rtnl:, err_notifier:, err_destroy_wq:) to align with the broader kernel convention. Signed-off-by: Jinliang Zheng --- drivers/net/macsec.c | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c index f6cad0746a02..35284ff7a17e 100644 --- a/drivers/net/macsec.c +++ b/drivers/net/macsec.c @@ -26,6 +26,8 @@ #include +static struct workqueue_struct *macsec_wq; + /* SecTAG length = macsec_eth_header without the optional SCI */ #define MACSEC_TAG_LEN 6 @@ -4450,25 +4452,35 @@ static int __init macsec_init(void) { int err; + macsec_wq = alloc_workqueue("macsec", WQ_UNBOUND, 0); + if (!macsec_wq) + return -ENOMEM; + pr_info("MACsec IEEE 802.1AE\n"); err = register_netdevice_notifier(&macsec_notifier); if (err) - return err; + goto err_destroy_wq; err = rtnl_link_register(&macsec_link_ops); if (err) - goto notifier; + goto err_notifier; err = genl_register_family(&macsec_fam); if (err) - goto rtnl; + goto err_rtnl; return 0; -rtnl: +err_rtnl: rtnl_link_unregister(&macsec_link_ops); -notifier: +err_notifier: unregister_netdevice_notifier(&macsec_notifier); +err_destroy_wq: + /* Precautionary, mirrors macsec_exit() to stay safe if work + * ever becomes queueable before this point in the future. + */ + rcu_barrier(); + destroy_workqueue(macsec_wq); return err; } @@ -4478,6 +4490,7 @@ static void __exit macsec_exit(void) rtnl_link_unregister(&macsec_link_ops); unregister_netdevice_notifier(&macsec_notifier); rcu_barrier(); + destroy_workqueue(macsec_wq); } module_init(macsec_init); -- 2.39.3