From: Jakub Kicinski <kuba@kernel.org>
To: "Íñigo Huguet" <ihuguet@redhat.com>
Cc: "Íñigo Huguet" <ihuguet@riseup.net>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Shuah Khan" <shuah@kernel.org>,
"Sabrina Dubroca" <sd@queasysnail.net>,
"Filip Pokryvka" <fpokryvk@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next 0/5] netdevsim: get link via ethtool, set via sysfs
Date: Mon, 11 May 2026 16:59:30 -0700 [thread overview]
Message-ID: <20260511165930.14c7b6b9@kernel.org> (raw)
In-Reply-To: <CACT4oucitAa05V11KD0d2mQYc7h1L36zDGumnRYXn6+6XUa=QA@mail.gmail.com>
On Mon, 11 May 2026 11:50:32 +0200 Íñigo Huguet wrote:
> On Sun, May 10, 2026 at 6:52 PM Jakub Kicinski <kuba@kernel.org> wrote:
> > Could you please explain your motivation? Feels quite trivial,
> > so it's not immediately obvious why we need tests.
> >
>
> We use netdevsim for some userspace CI testing here at Red Hat. Specifically,
> There are some tests that require reacting to carrier changes on a device
> matched by permanent MAC address from userspace. As veths don't have a
> permanent MAC address, we need netdevsim for this test case.
>
> As you say, it's pretty trivial, but IMHO there's nothing against it, as it
> will help to resemble better a typical Ethernet device.
>
> Note: we know that there's no guarantee regarding netdevsim's uAPI and we're
> ready to adapt for any change, but the truth is that there's no reasonable
> replacement of netdevsim for these kinds of cases where veth is not enough.
All code require maintenance. I'm trying to push back on netdevsim use
across the board. It was essentially a workaround for us not having any
real HW CI upstream. But that's no longer the case. Well, we still don't
have any crypto-capable HW :/ I think you'd be better off implementing
whatever you need in a small OOT module instead adding fake tests
upstream.
prev parent reply other threads:[~2026-05-11 23:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-10 16:43 [PATCH net-next 0/5] netdevsim: get link via ethtool, set via sysfs Íñigo Huguet
2026-05-10 16:43 ` [PATCH net-next 1/5] netdevsim: Add ethtool get_link support Íñigo Huguet
2026-05-10 16:43 ` [PATCH net-next 2/5] netdevsim: allow changing carrier state via sysfs Íñigo Huguet
2026-05-10 16:43 ` [PATCH net-next 3/5] selftest: netdevsim: test carrier change " Íñigo Huguet
2026-05-10 16:43 ` [PATCH net-next 4/5] selftest: netdevsim: cleanup the devices and module on failure Íñigo Huguet
2026-05-10 16:43 ` [PATCH net-next 5/5] selftest: netdevsim: suppress socat warnings Íñigo Huguet
2026-05-10 16:52 ` [PATCH net-next 0/5] netdevsim: get link via ethtool, set via sysfs Jakub Kicinski
2026-05-11 9:50 ` Íñigo Huguet
2026-05-11 23:59 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260511165930.14c7b6b9@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fpokryvk@redhat.com \
--cc=ihuguet@redhat.com \
--cc=ihuguet@riseup.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox