From: Jakub Kicinski <kuba@kernel.org>
To: David Yang <mmyangfl@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: mention the convention for .ndo_setup_tc()
Date: Mon, 11 May 2026 17:31:59 -0700 [thread overview]
Message-ID: <20260511173159.5d71d05b@kernel.org> (raw)
In-Reply-To: <20260507214054.2539790-1-mmyangfl@gmail.com>
On Fri, 8 May 2026 05:40:51 +0800 David Yang wrote:
> qdisc_offload_dump_helper(), originated from commit 602f3baf2218
> ("net_sch: red: Add offload ability to RED qdisc"), is designed to that
>
> Whether RED is being offloaded is being determined every time dump
> action is being called because parent change of this qdisc could
> change its offload state but doesn't require any RED function to be
> called.
>
> and returning -EOPNOTSUPP (for dump queries) does not mean "I don't have
> any statistics", but "I don't offload this qdisc anymore". At least two
> existing drivers did it wrong, so it is worth mentioning.
Applied (with a minor tweak), thanks!
prev parent reply other threads:[~2026-05-12 0:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 21:40 [PATCH] net: mention the convention for .ndo_setup_tc() David Yang
2026-05-12 0:31 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260511173159.5d71d05b@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmyangfl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox