From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD9AC3E1717; Tue, 12 May 2026 16:33:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778603631; cv=none; b=tHIx1N0OVUro6FOxmnvhEc+OcopW0niqa+TK+yqF2f8KKlW+NFn8gDRXYTvw1mCurT/QSoVodOqPCa7ZRzBBLna+jTQ3gu5KRgErd3lZZsuB8K/rZseZ+xQvYkwes5+hepwG+Q/o00HnKPAHO405rq3mThO/cjM5sMc2wrGfXIQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778603631; c=relaxed/simple; bh=fXB28kVuTkDkMqgoAEx3TNG/xeQuDfpRTyYYR9Bcoz4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KiDp7SEvrZgnpzAHvc5mKXiwUg6CF+0ELjJjw3yAC2ZSthLlIP48QCHj/SsZ7QrdbCvypMGVyoGWNvYWWWGOH/0/lGzoVn2naYdSEuQTojUazLlZPhsBE4FstYbpNnBWhCTKdFCb4Axkcqh8LP9t+ODOLUWgcO+4vFrsvKrq/Sc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GAWe0xzN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GAWe0xzN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A860BC2BCB0; Tue, 12 May 2026 16:33:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778603631; bh=fXB28kVuTkDkMqgoAEx3TNG/xeQuDfpRTyYYR9Bcoz4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GAWe0xzNZftlm2rMK+5z7ZTR1c1Rli62/A+p/enKDIBpmsZl+1QinD2bJbO74Ro4Z n8SKVqnizPk+bLAysFD6Hr8s418XdXmlokS2SNOwxbSyPg+3vlPQkr/XSrc0GbZ0jS sIWw2AzdbB033pjpSbNPrRd84l/npLvcxe4b4z94CK5AwQxviurnpvzAvzid4TAdjk VqErqbMz3jts81Hes8cytCOmlgh8UoH/6nPtt38KYMFsuKYhOmQHE1sKIVS7rc5JKH qDLyVNfAI8wv9Myc0fZq3Mj55rlDKkKvu+Nn22psb807paPdmLao0g8/PCF8xLTyKg qNEqAZSvSbBpw== Date: Tue, 12 May 2026 17:33:46 +0100 From: Conor Dooley To: Minda Chen Cc: Alexandre Torgue , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Emil Renner Berthing , Rob Herring , Krzysztof Kozlowski , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "devicetree@vger.kernel.org" Subject: Re: [net-next v3 3/5] dt-bindings: net: starfive,jh7110-dwmac: Add jhb100 sgmii rx clk Message-ID: <20260512-verbalize-nutty-137aedb43c81@spud> References: <20260507094115.8355-1-minda.chen@starfivetech.com> <20260507094115.8355-4-minda.chen@starfivetech.com> <20260507-annotate-cleat-52614476a8f7@spud> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="soViVKHqocBr5BBm" Content-Disposition: inline In-Reply-To: --soViVKHqocBr5BBm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 12, 2026 at 11:11:20AM +0000, Minda Chen wrote: >=20 >=20 > >=20 > > > + > > > + clock-names: > > > + oneOf: > > > + - items: > > > + - const: stmmaceth > > > + - const: pclk > > > + - const: ptp_ref > > > + - const: tx > > > + - const: gtx > > > + - items: > > > + - const: stmmaceth > > > + - const: pclk > > > + - const: ptp_ref > > > + - const: tx > > > + - const: gtx > > > + - const: sgmii_rx > >=20 > > Can't you just leave this list outside the conditional section, and add= the extra > > item to the end? The only difference appears to be the sgmii_rx clock, = and it's at > > the end. > >=20 > > I'm also not really convinced that this flexibility is required, unless= there are > > some controllers on the platform that do not support sgmii. > >=20 > > pw-bot: changes-requested > >=20 > > Cheers, > > Conor. > >=20 >=20 > Thanks. Yes, can do it more simple . I think change the clocks-names in p= roperties like this is Okay. >=20 > clock-names: > + minItems: 5 > items: > - const: stmmaceth > - const: pclk > - const: ptp_ref > - const: tx > - const: gtx > + - enum: > + - sgmii_rx This can remain const, only need the enum if there are options. >=20 > =20 > > > if: > > > properties: > > > compatible: > > > -- > > > 2.17.1 > > > --soViVKHqocBr5BBm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCagNWZwAKCRB4tDGHoIJi 0szgAQCIwA7rp54f62xNDMF0ehEbgxoMB8c08droQhw01YHC6wEAtaCNcVpthUi1 0DMQYR7ZolpGRgfM73GccwFnlpXI8QA= =TcYb -----END PGP SIGNATURE----- --soViVKHqocBr5BBm--