Netdev List
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Ethan Nelson-Moore <enelsonmoore@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: MAINTAINERS: Add self for the 3c509 network driver
Date: Tue, 12 May 2026 08:53:02 -0700	[thread overview]
Message-ID: <20260512085302.53cca49a@kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.21.2605120123260.46195@angie.orcam.me.uk>

On Tue, 12 May 2026 11:26:37 +0100 (BST) Maciej W. Rozycki wrote:
> On Mon, 11 May 2026, Jakub Kicinski wrote:
> > > Here:
> > > https://lore.kernel.org/all/alpine.DEB.2.21.2604240004280.28583@angie.orcam.me.uk/  
> > 
> > Maciej, what's the relevance of your machine in the lab?  
> 
>  It's one of my test machines for the defxx driver, specifically the EISA 
> binding.  The Ethernet link served by the 3c509 driver is for Internet 
> access, FDDI is intranet.
> 
> > Does the platform or any component that you test on this
> > platform have actual users?  
> 
>  I believe the defxx driver does, yes; unsure about the EISA binding.
> 
> > If the answer is no / unsure please fix the driver up to
> > follow modern coding standards and submit the patch.  
> 
>  I don't mind updating for our coding standards, though such a change 
> might be considered just irritating noise that interferes with `git blame' 
> (though with the removal of the code upstream, this got broken already 
> anyway).  NB it's the reason why I have hesitated to reformat the defxx 
> driver for decades now, which obviously has much more serious issues here 
> such as the assumption of 4-character tabs.
> 
>  I think the re-addition needs to be done in two stages, first being a 
> plain revert so that no code change comes unrecorded in git, followed by 
> the actual formatting cleanup.  Sadly this won't fix `git blame', but at 
> least the diff will be empty between the repo states as at respectively 
> the removal and the re-addition.

Right, since it was already removed the git blame is going to point
to the re-addition. Hence it's an opportunity for a cleanup.

>  Does it answer your questions and seem like a reasonable course of 
> action?

Sounds fine, I'd squash them, but as long as the patches come in one
series - either way works!

  reply	other threads:[~2026-05-12 15:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 10:23 MAINTAINERS: Add self for the 3c509 network driver Maciej W. Rozycki
2026-04-27 14:36 ` Andrew Lunn
2026-05-08 22:00 ` patchwork-bot+netdevbpf
2026-05-09 23:05   ` Ethan Nelson-Moore
2026-05-10  1:57     ` Maciej W. Rozycki
2026-05-10 15:58       ` Jakub Kicinski
2026-05-10 21:44         ` Ethan Nelson-Moore
2026-05-11 23:20           ` Jakub Kicinski
2026-05-12 10:26             ` Maciej W. Rozycki
2026-05-12 15:53               ` Jakub Kicinski [this message]
2026-05-10 15:59     ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260512085302.53cca49a@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=enelsonmoore@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macro@orcam.me.uk \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox