From: Stephen Hemminger <stephen@networkplumber.org>
To: netdev@vger.kernel.org
Cc: jhs@mojatatu.com, Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH net-next v5 5/5] net/sched: netem: add per-impairment extended statistics
Date: Tue, 12 May 2026 10:58:05 +0200 [thread overview]
Message-ID: <20260512105805.1dfe97b0@stephen-xps.local> (raw)
In-Reply-To: <20260509171123.307549-6-stephen@networkplumber.org>
On Sat, 9 May 2026 10:03:26 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:
> unters for each impairment netem applies (delay, loss,
> ECN marking, corruption, duplication, reordering) and for skb
> allocation failures during enqueue. Exposed through TCA_STATS_APP
> as struct tc_netem_xstats.
>
> Counters increment when an impairment is occurs, independent of later
> events that may mask its on-wire effect. Added allocation_errors
> (similar to sch_fq) to account for when impairment could not be
> applied due to memory pressure, etc.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>
> Note to reviewers. The READ_ONCE/WRITE_ONCE pattern is to
> align with upcoming changes removing qdisc_lock.
> For some reason current AI prompts are obsessed with complaining
> about 64 bit torn read/write on these, since the counters are
> informational only, any such complaints are false positive.
The automated review comments on this patch are false positives.
Unfortunately, the review automation doesn't look at precedents
in other qdisc like RED, FQ, ...
prev parent reply other threads:[~2026-05-12 8:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-09 17:03 [PATCH net-next v5 0/5] net/sched: netem: enhancements Stephen Hemminger
2026-05-09 17:03 ` [PATCH net-next v5 1/5] net/sched: netem: reorder struct netem_sched_data Stephen Hemminger
2026-05-09 17:03 ` [PATCH net-next v5 2/5] net/sched: netem: remove useless VERSION Stephen Hemminger
2026-05-09 17:03 ` [PATCH net-next v5 3/5] net/sched: netem: replace pr_info with netlink extack error messages Stephen Hemminger
2026-05-09 17:03 ` [PATCH net-next v5 4/5] net/sched: netem: handle multi-segment skb in corruption Stephen Hemminger
2026-05-09 17:03 ` [PATCH net-next v5 5/5] net/sched: netem: add per-impairment extended statistics Stephen Hemminger
2026-05-12 8:58 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512105805.1dfe97b0@stephen-xps.local \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox