From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7AD132143D for ; Tue, 12 May 2026 14:44:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778597066; cv=none; b=KgHPZPGlR6Cw9PrmlbWmVgWdaxrwEGL3A7EU1KUniH1AFHYzmybGJeX7FgfOqxuldpg2MNe1pQJjTSIMMBRNMRTyj/7ZarMMudmGr+gaJ95irN5xYbEQ5ToPSCDeDfd992w96MQHBzOCDVenU1Wy0+gekzwQuBfp7w+DXnm9Sx4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778597066; c=relaxed/simple; bh=pNjPLUfYOnlL9AuWfKEjlCxudFzPIGw2EJqVl9WOMxQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=L9cpmrUQKrQKjwHt45oUN7gefbztdv+C/nIu5nVxNCcPOhOj6/PTihcF3T8JZUKwIe2bkP+vxjRKOu+reeoa+k3T58oS8HKnn38RMrriZAucJmcqEbPbJQBhvk90r1p12eCVR8t1rcUF/eb8QPKURI4oldQ1f9LmrWbTYkJM2zo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Parc8l9R; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Parc8l9R" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-43fe62837baso2938106f8f.3 for ; Tue, 12 May 2026 07:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778597063; x=1779201863; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Sza2ZxpHlBY8pmqC5zMaFu/RPKkibTVxTiEJ6kAqjb8=; b=Parc8l9RtSWs1uSoBeSworOcRTD0ctS3rqLYfEtNkczKqfx9HYKPvgQs4ABgELQw57 VXadQdQIH+fsvzks32Q8j6wKH44MDtuV0rg8mI5fdjaL/mIDpUpxFw2+2gVTP6isqz8o 7AXHio+M/gEDejoCF7tXuHoY3Zid1fh9enhiyxmT8Jjd8MRtiZD/t8ffw5SVehrmggUs 9OqGfo7OOFlknp6X8Hm32QjNNgJDEFD/B6gwGVf+GgNVGuxzmf2ZbqN7f8svy2v9NNq3 wHGb+XGijRq24soHDH39ni1pWy26RB2ej9ZtBLqKXO92PA/g1z12221VM+pReObyhNjY Gwcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778597063; x=1779201863; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Sza2ZxpHlBY8pmqC5zMaFu/RPKkibTVxTiEJ6kAqjb8=; b=KJ97HMGBet2MNdx1rAoOfzp40gJYfHZVkuAjsXBTI1usx2zHYP5V0BqafkVksMcLDg NvKXbWuNMxZxGoA0jv56SzGaJ4AOM6gcBU2h1fPqg7EcttoButVJzihaH07ox3CWCm/d guYjZHmdTKAf7IMbqetKUCWcsKKQRdx2gjh4KDQewQz3GUmyDo+kkH/Bytl+Lq+1PiT5 IJvAs4CouqLr5vKVzGrOPaY+zx0AGvNXfIJ1A0wOcxb2m1oXKX025oW3gaWVbChr9ZFq RI1PvXbSK74of+3lyu2GtPa3dKslDsalKkmZOJ8gIT3zacmKmw1DrAoP7eUJCJek8mhO A20Q== X-Forwarded-Encrypted: i=1; AFNElJ+VcEXKsLOaDZG/JoS7uC0VvO5pNaXWtFlS5QiIvXAb0dMIyICZfLCPx6WWmkn4jZEVYcNQ9vk=@vger.kernel.org X-Gm-Message-State: AOJu0YzcYQTltVN7cdrs58kWvZfrFTu3wFb4b+dl5/hMeVpF4/cpmj82 sXzv537n6l2l5b8kpwBGM68ZHYhwq4GM0gvjPuzBPw2uSwShejlRo95l X-Gm-Gg: Acq92OEIcQBHjOmI/C/DzARW2HimD+pIbKGlm1V9PF/LKiQ1tWXt7It2J48sDDH+vxX MmA2sJ1WZw1j0wX1xu6w3Qm6LsT9Cqrb3khJ7a/LYzI3zPcIziui2w34CnXbkNkwYGgswk5bxT/ /JTk0eGG/rH9cbWMyPffYKQNWBkrxnRA6N2xc9+GJ3sl/Fz1/sSmn0caNGIffKivIGq6JdEBB4g 4lAg0++UNjQvFv5au6mVrQi1tZ2NCkwSyOoOLGsLL3mktLgI0mfZMwftKhwsBo5CJfK1Ta7kJ36 g88jPHP/tHvSP64EgeALT58XMsmIlV8QcfQMChKvZ97460JhxoUZmMy60UjKld1HHpptdFSVNtr qLt0CyC0b90xAJX2Y6RAU14NL9ins1AWV9SZ3f2LHlPfz/1dEeKLbgsGY0/f9FDy0RGuuQg/e5a nfamxmJF77dvmBv/O1RHViNHShiOxkDDa3Xd9sNKEtmdRnl/YZG99ZpbdL1JrzoK0gPl1D3mInF H/1 X-Received: by 2002:a05:6000:4011:b0:44a:aa3c:5927 with SMTP id ffacd0b85a97d-45b13e55d33mr5041184f8f.29.1778597063157; Tue, 12 May 2026 07:44:23 -0700 (PDT) Received: from ubuntu-f6bvp (lfbn-idf1-1-304-238.w86-195.abo.wanadoo.fr. [86.195.26.238]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45491f8d4c3sm32858657f8f.34.2026.05.12.07.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 07:44:22 -0700 (PDT) From: f6bvp To: toke@toke.dk, kuba@kernel.org, stable@vger.kernel.org Cc: Bernard Pidoux , davem@davemloft.net, netdev@vger.kernel.org, pabeni@redhat.com, gregkh@linuxfoundation.org, linux-hams@vger.kernel.org Subject: Re: [PATCH net-deletions] net: remove ax25 and amateur radio (hamradio) subsystem Date: Tue, 12 May 2026 16:42:28 +0200 Message-ID: <20260512144416.9848-1-bernard.f6bvp@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <87se8mytvv.fsf@toke.dk> References: <87se8mytvv.fsf@toke.dk> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Bernard Pidoux Toke Høiland-Jørgensen writes: > Acked-by: Toke Høiland-Jørgensen Hello Toke, Jakub, all, I understand the decision to move AX.25, NET/ROM, and ROSE out of tree, and I am not opposing it. The maintenance burden caused by AI-generated syzbot reports with no human follow-up is a legitimate reason to act. That said, I would like to raise one specific concern: the ROSE subsystem accumulated a number of real bugs through upstream commits that were merged without hardware testing. I have been running ROSE on actual packet radio equipment and was able to reproduce and fix five of these bugs, confirmed via KASAN and netconsole. The most severe symptom is that the ROSE module cannot be cleanly unloaded once an AX.25 connection has been established, which makes amateur radio applications that rely on ROSE effectively unusable until a reboot. My five patches address: 1. rose: fix dev_put() leak in rose_loopback_timer() Fixes: 0453c6824595 ("net/rose: fix unbound loop in rose_loopback_timer()") 2. rose: hold loopback neighbour reference across timer callback Fixes: d860d1faa6b2 ("net: rose: convert 'use' field to refcount_t") 3. rose: fix race between loopback timer and module removal Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") 4. rose: clear neighbour pointer after rose_neigh_put() in state machines Fixes: d860d1faa6b2 ("net: rose: convert 'use' field to refcount_t") 5. rose: guard rose_neigh_put() against NULL in timer expiry Fixes: 5de7665e0a07 ("net: rose: fix timer races against user threads") Each patch carries the appropriate Fixes: tag and a Tested-by from me on real hardware. They are visible on lore.kernel.org. Since ROSE will no longer be maintained in-tree from 7.1 onward, the only remaining users are those running current stable kernels (7.0.y and earlier). Would it be possible to have these five patches queued for the stable trees via Greg's stable process? I am happy to resend them as a formal series tagged [PATCH stable] against the current stable releases if that is preferred. Thank you for your work on the Linux networking subsystem. 73 de Bernard Pidoux, F6BVP