From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC822883F; Wed, 13 May 2026 00:06:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778630812; cv=none; b=lbqpk19EZS5Vg+ynJzPVDQ39+NiqwJxqSbDCIdQiZwHwZP10fgsATtq+TjK73PaidWYtucFYgSV69m+fnBZ4N867WaXy+OPVhIimNBFoCjNCmV363rv4YHW4n42eDIKohkNSLgyi+zPuJnrc2opCBKXFcE2P+UQ+Ugosd5/oiRw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778630812; c=relaxed/simple; bh=DToW+fuh/tneKrnx4rW0q0YfbWJJOyE7I2Z47WBrJfo=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aBQZuo/WDhrfdDmWZj+81tukIXDFwJF1R+vwzU+KJ+qnPJjM9BBbxC3zboqmBIY3DTfcdOVB+38CwI+bBLck0AbMHxHN24Rmeq9vsR0I1Z0Tmk8V8rZ5hCqg5i5WAfWWhPnagF/warzosAx8ol/bt+x8srtjRwJcToNh/1CX/J8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PJeGwkFR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PJeGwkFR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD61FC2BCB0; Wed, 13 May 2026 00:06:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778630812; bh=DToW+fuh/tneKrnx4rW0q0YfbWJJOyE7I2Z47WBrJfo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PJeGwkFR2zlogn/hZ1XOQ4uz4Y8WCDMCh6CvxcnTAzu0y+FKcgg5jRfLCAaZYGiZs +Pqab1hGRmcMrU+WbWXuatZk1DrLH7lkMWN9nryQTxQxB4ehkogNnof84TqYnp0Wkd tVpPjn+EV6ZtR2KBRd5F+Tbe3we6eJuWGIBF1YcobJczYmAtvD6ihtMjThOT2fs+ks BWjE5pCwcYmxsNzQ7BtejWbiv7YbWGz9ZqYx0917MngaMWTQuFqvf0dqQUDsQ/9CNp dw1EcL/iRqMKw8ld6h2qa3BBA6dd9HEQxiPfY47K3/+N2hnebt2cnYFNk1CBumT7j4 6unhEvI29W/eQ== Date: Tue, 12 May 2026 17:06:50 -0700 From: Jakub Kicinski To: David Howells Cc: netdev@vger.kernel.org, Hyunwoo Kim , Marc Dionne , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, Jeffrey Altman , Jiayuan Chen , stable@kernel.org Subject: Re: [PATCH net 3/3] rxrpc: Fix RESPONSE packet verification to extract skb to a linear buffer Message-ID: <20260512170650.4acfad72@kernel.org> In-Reply-To: <20260511160753.607296-4-dhowells@redhat.com> References: <20260511160753.607296-1-dhowells@redhat.com> <20260511160753.607296-4-dhowells@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 11 May 2026 17:07:49 +0100 David Howells wrote: > This improves the fix for CVE-2026-43500. > > Fix the verification of RESPONSE packets to avoid the problem of > overwriting a RESPONSE packet sent via splice to a local address by > extracting the contents of the UDP packet into a kmalloc'd linear buffer > rather than decrypting the data in place in the sk_buff (which may corrupt > the original buffer). net/rxrpc/conn_event.c:254:10: warning: variable 'ret' is uninitialized when used here [-Wuninitialized] 254 | return ret; | ^~~ net/rxrpc/conn_event.c:250:9: note: initialize the variable 'ret' to silence this warning 250 | int ret; | ^ | = 0