From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5526938B130; Wed, 13 May 2026 07:21:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778656878; cv=none; b=NuWv3xcAynVEZAESL/Aqyfca++fsId3dKa9Ld0kkRRBlNnDRMHJ+XrwP7HNcLsG5urNR8tQwvs0Ff7vsihKlP2swMR647FxkfOCglmQNliWkImBX9id9fTYdWV+mJCyulZC8MpKEutxy4KaEQnStIfK7mTM9tRplHSXmkLClJZY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778656878; c=relaxed/simple; bh=Ro/6Yan4wzkoz45rJvdI0ZqKjoE6IvDotb3bzyFTqzU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mzjiLLH5VtUCLfVCKfBU2/KpoNqLHjpkOSptJkjTI9DZPHaC6zqu2zVoHX2ngjtErevYwWfMlZsz7fO7UeUAMxHoZpmCnyE8ch4JCzy5OrJ+e1eb9zTuxlPkxQGNbRhCzlkb/HhOzeySUdYrMqh3ntekuZPBYmgjfqQ1LaaauTA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DvLNBXfw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DvLNBXfw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29F63C2BCB7; Wed, 13 May 2026 07:21:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778656878; bh=Ro/6Yan4wzkoz45rJvdI0ZqKjoE6IvDotb3bzyFTqzU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DvLNBXfwOBhVOqd9Qry9LHxy2y8gmsfFQi7xLcW9o0ZIySpHvWIy/wfP7Z2ycUg0z 7DSdewBaKcG/Ex5Z6vqfdBe8xxsX+X/7hc8JJ8Oz3iuXin6jck7787m0TKUW88S/+I NTwAqUo2/qGaZ3k8uZoJouzOxFuil+supCWUzQktV5xhLjopr37zQIwySA+FN+N6Of bJD8qWnDc61CRWIWFLFS+jltOONpI9ak+sL2HlIfBWMoGCJhNN2oRPQ9erRSoujvwC AeJ5lrCh05BEZUXjf/cHO0KyzZCxRoxesv4+MgRoU7whXEryqNis6rDxoa3LxAaVwK oh4rUjwhchGtQ== Date: Wed, 13 May 2026 10:21:13 +0300 From: Leon Romanovsky To: Eric Joyner Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, Brett Creeley , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Abhijit Gangurde , Allen Hubbe , Jason Gunthorpe Subject: Re: [PATCH net-next 3/4] RDMA/ionic: Add debugfs support Message-ID: <20260513072113.GE15586@unreal> References: <20260506041935.1061-1-eric.joyner@amd.com> <20260506041935.1061-4-eric.joyner@amd.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260506041935.1061-4-eric.joyner@amd.com> On Tue, May 05, 2026 at 09:19:34PM -0700, Eric Joyner wrote: > From: Allen Hubbe > > Adds a per-RDMA device debugfs folder under the parent ionic ethernet > device's folder for the LIF. Exports RDMA-specific debug information and > various queue information. > > Signed-off-by: Allen Hubbe > Co-developed-by: Eric Joyner > Signed-off-by: Eric Joyner > --- > drivers/infiniband/hw/ionic/Makefile | 2 +- > drivers/infiniband/hw/ionic/ionic_admin.c | 4 + > .../infiniband/hw/ionic/ionic_controlpath.c | 14 + > drivers/infiniband/hw/ionic/ionic_debugfs.c | 750 ++++++++++++++++++ > drivers/infiniband/hw/ionic/ionic_ibdev.c | 3 + > drivers/infiniband/hw/ionic/ionic_ibdev.h | 29 + > drivers/infiniband/hw/ionic/ionic_lif_cfg.c | 3 + > drivers/infiniband/hw/ionic/ionic_lif_cfg.h | 2 + > 8 files changed, 806 insertions(+), 1 deletion(-) > create mode 100644 drivers/infiniband/hw/ionic/ionic_debugfs.c I'll comment on this patch only, but the same issues apply to the whole series. 1. This series should target rdma-next, not net-next. 2. Jakub's feedback is valid and should be addressed. 3. The patch is too large and exposes too many details that should be gathered through the FW (fwctl). 4. It exposes a large number of fields from general RDMA structures, which suggests that this dump is placed in the wrong layer. Thanks