From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D985F3A4F5E; Wed, 13 May 2026 18:03:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778695427; cv=none; b=qxY5CiYOGrXORoDnjtWyv9CzEr5tDpUsHb3qK5JNnMZa1QDA0TpYKIZS4o3szlId4RbLH3lEncuoeS+1FJZC85MfHoqQu/ApqT5AELccb7jOOspW8oAscOhHRM/S1kylgPAPEbMhutUFtbkqo9k/JVin/FAIBLnDeJooEW3lIWU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778695427; c=relaxed/simple; bh=E1Qno85xQ4a1LPVATc1U74DHXegqIcnYbC3QIApo++s=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=szVQtQmecIuDrzyoP9XNMo6wAsiOCu5l27wCRMOqnbII0O9cu7XpKxw/0tqWCB3qyoWaP3UZnkmDUG/1s61o4CgjLtSwsBpHoiYMmOUSmmyrcZxyIbgUhIwNjMsRvxX9Id++hDTZ45ORhZWC5SCDF6BrLAMIVBaWgOX2fgaPC60= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TXckAa7x; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TXckAa7x" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67386C19425; Wed, 13 May 2026 18:03:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778695427; bh=E1Qno85xQ4a1LPVATc1U74DHXegqIcnYbC3QIApo++s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TXckAa7xYAUzWsuE0QKajSduKfUTlAKR0fSNKyhei6QCzYdfA2MfiMKrrMvqv9C3g 4K/575ZTer67HkpESMPGn+hgCF7uGVDoW7vnkNTsfRUXQN7A1JH7LzUA134d8x0BrT 2gU1h3bUhdkI0rEf7ZWtbnASmp34zB5VxOASJNl+1CBWbjdw6/oOWQvwZAJA//gm7e B06txNkjN96u/vlDgRlEV9XnsLsw8x+EdMvYHjRSjSD0uMNFafXJB7go8n/6kOr0Vn zxHQUi2CW0vH1erI2tVyw59yBGpyLgC4Rrrd6kugM8VepuoicaYO6/drsAt9QJQuWl ljiXQihp3oB8g== Date: Wed, 13 May 2026 11:03:46 -0700 From: Jakub Kicinski To: Daniel Zahka Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 3/3] netdevsim: psp: serialize psp stats writers Message-ID: <20260513110346.35c8accf@kernel.org> In-Reply-To: <20260513-fix-psp-stats-v1-3-cdb3174f252f@gmail.com> References: <20260513-fix-psp-stats-v1-0-cdb3174f252f@gmail.com> <20260513-fix-psp-stats-v1-3-cdb3174f252f@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 13 May 2026 05:59:38 -0700 Daniel Zahka wrote: > The u64_stats_* api requires mutual exclusion on writers. The simplest > way to do this is just to add a spinlock to the writer path, rather > than making the stats per queue. > > Synchronization of the reader and writer paths use the > u64_stats_update_begin() api and does not require any fixes. The spin lock makes the use of u64_stats_t a bit pointless. Let's switch to atomic_long instead? -- pw-bot: cr