From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17C033AA500 for ; Wed, 13 May 2026 18:27:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778696861; cv=none; b=ShOHBsWfvpYiPUVxZmdZp0k3Ua4hAHi0F6gI29V1I2n4iOmncNUmyqo8viweDCcU51NyBsPiVnzSKqYawgkw+JVMrHKK5Wyi4nWB8qkg+Ov6w6dW0XsDU8DXjOqM4qCfsp9NIbMf0Mwi9wJjr5fthmwDfl3gqe9x9sdfIBsP3aM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778696861; c=relaxed/simple; bh=pmjkMioukLW5g1txgrEEVf7hs/e4o+qCrWbxN4mexf0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=epyviWdqWfB3nXsGofAaSJpDxNX+yC5O9UIPEiM2Fl7y7zFTT+kW4syHlzfNNVA5GOd7995vrhgQbV9LHvn5Er8vxIM1Pw4BhsFxGn1WzvdoGKL0Pj/aA4hzSB6GEfqC0NW25FFHWuJWCPNnshCAsCyEq9HkPR3uY2Jd1oOF7JM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=rDK00f9k; arc=none smtp.client-ip=91.218.175.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="rDK00f9k" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1778696858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f2nx21UCgkelQfmsgGrpgYKaWUBt9g94q5n1ek11K60=; b=rDK00f9kgn/XkdbYChNRnvvrKW9ajzsfvLmyg61vkCI/Rp5JwODQ4wqDe4usFeFHBmJHwA 3YMiMHkqxKa2vOtyaZMlyJnGebg3U0QFxZ6Iw0rTez5CXtOpvgwyOkLzvO9IhIcLYkMul7 QgESNXnqleq4jk+jQaA8s0H6aqMLDIk= From: luka.gejak@linux.dev To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, fmaurer@redhat.com, luka.gejak@linux.dev Subject: [PATCH net-next v6 2/2] net: hsr: reject unresolved interlink ifindex Date: Wed, 13 May 2026 20:26:57 +0200 Message-ID: <20260513182657.20346-3-luka.gejak@linux.dev> In-Reply-To: <20260513182657.20346-1-luka.gejak@linux.dev> References: <20260513182657.20346-1-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT From: Luka Gejak In hsr_newlink(), a provided but invalid IFLA_HSR_INTERLINK attribute was silently ignored if __dev_get_by_index() returned NULL. This leads to incorrect RedBox topology creation without notifying the user. Fix this by returning -EINVAL and an extack message when the interlink attribute is present but cannot be resolved. Assisted-by: Gemini:Gemini-3.1-flash Reviewed-by: Felix Maurer Signed-off-by: Luka Gejak --- net/hsr/hsr_netlink.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/net/hsr/hsr_netlink.c b/net/hsr/hsr_netlink.c index db0b0af7a692..f0ca23da3ab9 100644 --- a/net/hsr/hsr_netlink.c +++ b/net/hsr/hsr_netlink.c @@ -76,9 +76,14 @@ static int hsr_newlink(struct net_device *dev, return -EINVAL; } - if (data[IFLA_HSR_INTERLINK]) + if (data[IFLA_HSR_INTERLINK]) { interlink = __dev_get_by_index(link_net, nla_get_u32(data[IFLA_HSR_INTERLINK])); + if (!interlink) { + NL_SET_ERR_MSG_MOD(extack, "Interlink does not exist"); + return -EINVAL; + } + } if (interlink && interlink == link[0]) { NL_SET_ERR_MSG_MOD(extack, "Interlink and Slave1 are the same"); -- 2.53.0