From: Ilya Maximets <i.maximets@ovn.org>
To: netdev@vger.kernel.org
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Aaron Conole <aconole@redhat.com>,
Eelco Chaudron <echaudro@redhat.com>,
David Ahern <dsahern@kernel.org>,
Ido Schimmel <idosch@nvidia.com>, Shuah Khan <shuah@kernel.org>,
Nikolay Aleksandrov <razor@blackwall.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
Petr Machata <petrm@nvidia.com>,
Fernando Fernandez Mancera <fmancera@suse.de>,
Antoine Tenart <atenart@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>,
linux-kernel@vger.kernel.org, dev@openvswitch.org,
linux-kselftest@vger.kernel.org,
Ilya Maximets <i.maximets@ovn.org>
Subject: [RFC net-next 5/6] net: gre: remove unused gretap_fb_dev_create
Date: Wed, 13 May 2026 20:35:25 +0200 [thread overview]
Message-ID: <20260513183559.2141010-6-i.maximets@ovn.org> (raw)
In-Reply-To: <20260513183559.2141010-1-i.maximets@ovn.org>
The only user was vport-gre in openvswitch and now it is gone.
Note: since it's an exported symbol, there is a possibility that some
out-of-tree module is using it. So, alternative is to deprecate it
instead by adding a warning if it is ever called.
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
---
include/net/gre.h | 2 --
net/ipv4/ip_gre.c | 47 -----------------------------------------------
2 files changed, 49 deletions(-)
diff --git a/include/net/gre.h b/include/net/gre.h
index ccd2932032844..b55f67ecd2fc4 100644
--- a/include/net/gre.h
+++ b/include/net/gre.h
@@ -32,8 +32,6 @@ struct gre_protocol {
int gre_add_protocol(const struct gre_protocol *proto, u8 version);
int gre_del_protocol(const struct gre_protocol *proto, u8 version);
-struct net_device *gretap_fb_dev_create(struct net *net, const char *name,
- u8 name_assign_type);
int gre_parse_header(struct sk_buff *skb, struct tnl_ptk_info *tpi,
bool *csum_err, __be16 proto, int nhs);
diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
index 169e2921a851d..a1dd833ea1cad 100644
--- a/net/ipv4/ip_gre.c
+++ b/net/ipv4/ip_gre.c
@@ -1710,53 +1710,6 @@ static struct rtnl_link_ops erspan_link_ops __read_mostly = {
.get_link_net = ip_tunnel_get_link_net,
};
-struct net_device *gretap_fb_dev_create(struct net *net, const char *name,
- u8 name_assign_type)
-{
- struct rtnl_newlink_params params = { .src_net = net };
- struct nlattr *tb[IFLA_MAX + 1];
- struct net_device *dev;
- LIST_HEAD(list_kill);
- struct ip_tunnel *t;
- int err;
-
- memset(&tb, 0, sizeof(tb));
- params.tb = tb;
-
- dev = rtnl_create_link(net, name, name_assign_type,
- &ipgre_tap_ops, tb, NULL);
- if (IS_ERR(dev))
- return dev;
-
- /* Configure flow based GRE device. */
- t = netdev_priv(dev);
- t->collect_md = true;
-
- err = ipgre_newlink(dev, ¶ms, NULL);
- if (err < 0) {
- free_netdev(dev);
- return ERR_PTR(err);
- }
-
- /* openvswitch users expect packet sizes to be unrestricted,
- * so set the largest MTU we can.
- */
- err = __ip_tunnel_change_mtu(dev, IP_MAX_MTU, false);
- if (err)
- goto out;
-
- err = rtnl_configure_link(dev, NULL, 0, NULL);
- if (err < 0)
- goto out;
-
- return dev;
-out:
- ip_tunnel_dellink(dev, &list_kill);
- unregister_netdevice_many(&list_kill);
- return ERR_PTR(err);
-}
-EXPORT_SYMBOL_GPL(gretap_fb_dev_create);
-
static int __net_init ipgre_tap_init_net(struct net *net)
{
return ip_tunnel_init_net(net, gre_tap_net_id, &ipgre_tap_ops, "gretap0");
--
2.53.0
next prev parent reply other threads:[~2026-05-13 18:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 18:35 [RFC net-next 0/6] openvswitch: remove support for legacy tunnel ports Ilya Maximets
2026-05-13 18:35 ` [RFC net-next 1/6] openvswitch: remove support for legacy tunnel types Ilya Maximets
2026-05-13 18:35 ` [RFC net-next 2/6] openvswitch: vport: remove infrastructure for vport options Ilya Maximets
2026-05-13 18:35 ` [RFC net-next 3/6] openvswitch: vport: remove infrastructure for separate modules Ilya Maximets
2026-05-13 18:35 ` [RFC net-next 4/6] net: geneve: remove unused geneve_dev_create_fb Ilya Maximets
2026-05-13 18:35 ` Ilya Maximets [this message]
2026-05-13 18:35 ` [RFC net-next 6/6] net: vxlan: remove unused vxlan_dev_create Ilya Maximets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260513183559.2141010-6-i.maximets@ovn.org \
--to=i.maximets@ovn.org \
--cc=aconole@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=dsahern@kernel.org \
--cc=echaudro@redhat.com \
--cc=edumazet@google.com \
--cc=fmancera@suse.de \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox