From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7DA81E8826; Thu, 14 May 2026 02:21:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778725296; cv=none; b=pTg4fCuRM4RtCq/U6ug3+g1JP7mDszvu7P0dvY0wggf4uqFxonm79Ph80dhxP/dV0uXbzKZerM/Q2+cUibGOWAPLodLdHe35osQxNYccxrym7WUzuFgRYS978jFTp4E9dbPAWc1SiwTl7w9NI4JgHH0Nue6Sf9+uJtdNKiW63xY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778725296; c=relaxed/simple; bh=hx+tymloAIZP4K3mSk6uylZJeFOgFon7qjf1v0Tiguk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=j9xJ+cpT6lNE6qg2cQ95vSQ/Kn97zAwlyu0IYzhnW18WXGgGRI59VYzdyuu8wkDjPEgNibc5LkiJMQOTUTKR81CS7saYMCm3S7FuktL8AH5JuQT8ZzV6O58XNjS3VcDKlARoXUuqTEnHbNuA89fCJibeWqIAr57d0GKiWkwcz7U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LpdT/4sY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LpdT/4sY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2099EC19425; Thu, 14 May 2026 02:21:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778725296; bh=hx+tymloAIZP4K3mSk6uylZJeFOgFon7qjf1v0Tiguk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LpdT/4sYf4W5sJwtPHPsmS1gYgte/QoafDoR9rthPNQ0qfGDxUaqDC7gqbDYlTsSs HLDVybZtXf4HM59aE5+pAed+O4XjPavi/2XremwM/XukiFH1AiO2qNrWkcsrbfxpkq aYkuo+JXRhS7seBZQBaMSlQc5U1Aghl2zhIlA4oOUCDwH/xryfZQbHi87d9KN6scLO pYhtGYoeGqVKk45s9coTfeBIU4b5ptBjqAbUNniEiqmsZPPRolVNoYg25jrATRjvfE ZxixagliJqw1Jvoaag2tqHPQzrQhq8A32g68Ws/Q0rm8QCyDtvnmsfutt8uJa7WVD1 66+88xEsUI/GA== Date: Wed, 13 May 2026 19:21:33 -0700 From: Jakub Kicinski To: Bobby Eshleman Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan , Alex Shi , Yanteng Si , Dongliang Mu , Michael Chan , Pavan Chebbi , Joshua Washington , Harshitha Ramamurthy , Saeed Mahameed , Tariq Toukan , Mark Bloch , Leon Romanovsky , Alexander Duyck , kernel-team@meta.com, Daniel Borkmann , Nikolay Aleksandrov , Shuah Khan , dw@davidwei.uk, sdf.kernel@gmail.com, mohsin.bashr@gmail.com, willemb@google.com, jiang.kun2@zte.com.cn, xu.xin16@zte.com.cn, wang.yaxin@zte.com.cn, netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, Stanislav Fomichev , Mina Almasry , Bobby Eshleman Subject: Re: [PATCH net-next v4 6/8] selftests: drv-net: refactor devmem command builders into lib module Message-ID: <20260513192133.60a82598@kernel.org> In-Reply-To: <20260511-tcp-dm-netkit-v4-6-841b78b99d74@meta.com> References: <20260511-tcp-dm-netkit-v4-0-841b78b99d74@meta.com> <20260511-tcp-dm-netkit-v4-6-841b78b99d74@meta.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 11 May 2026 18:18:00 -0700 Bobby Eshleman wrote: > tools/testing/selftests/drivers/net/hw/devmem.py | 77 ++------ > .../selftests/drivers/net/hw/lib/py/devmem.py | 218 +++++++++++++++++++++ If the reuse is in the same dir I think you can create tools/testing/selftests/drivers/net/hw/devmem_lib.py and import: from devmem_lib import bla I _think_ that should "just work" ? The lib/ is meant for things shared between targets. Also I think you missed adding the new file to Makefiles ? It needs to be under TEST_FILES for building tarballs