From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C57461459FA; Thu, 14 May 2026 02:35:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778726146; cv=none; b=lbDy1uTyocoXqDgWa6cI2jFbZ9kCvcw6/J+1mOwpp36znmQVCet4A6sf+/irSsH4otfJlviyCotuLMvthYerIAxwknUcn+a0833dHqnC0jMc7wxg4PqRPsnAnYvEgbzZQcsRyNCPKcKbRcR6l+0++LWJp+JXcanXsPt4aD0Pd5I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778726146; c=relaxed/simple; bh=FAxIPJuCdBfxFLr7b5SZBZadKglB80+7msXC94z0AZk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZrBJbJ0oyYOuVH8W36oU6KDDvxphebSDmoAg6czMpY1ljrdCj3IgV+YusUqMJrSnFZczUVnZ7goCWHkwJw2SbCpTkbwMx0gVlemRgyn4Ag1BBulNDEgE1jJY/TwFQU/WGY5PPxxBYkuUU07kr4Xdk71Fc8YAoquBbkggPHAxNQM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=h1+kWQdg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="h1+kWQdg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCED5C19425; Thu, 14 May 2026 02:35:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778726146; bh=FAxIPJuCdBfxFLr7b5SZBZadKglB80+7msXC94z0AZk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=h1+kWQdgmHwUxvSaWxu6ZIzdcu4n9pbUvRW8UR37uj9WjzwqsgtXmjkAIAkdQ+1LI A4z3ba7QfllMdu4idZJlVKWiaDhU5iq5rfkqf2xL6VMmQBcJDyHhDuO4B1Y+WFoz6K l3ent/5w/bqWXlu67zKrRdX2h9mCcYgjQxQ0oMyJnerGO9SN+i/CrfyHxLXdAOUx9m A7ksmaEIV7+Q2rQBh6hCBEpu/7wKG4p7q5RvkoMZXnFoYqaN+EEaBcSa3SQttLwLNx qeVgMo+VD5SIjgjhTjxBMcl+WP/WQniNSNPRYsgsr36TXG0ttkFvgpNZtGmk6DClYw gdczdOoMx6nyA== Date: Wed, 13 May 2026 19:35:44 -0700 From: Jakub Kicinski To: Fernando Fernandez Mancera Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, horms@kernel.org, pabeni@redhat.com, edumazet@google.com, dsahern@kernel.org, davem@davemloft.net Subject: Re: [PATCH 3/3 net-next v4] selftests: net: add test for IPv4 devconf netlink notifications Message-ID: <20260513193544.47970cb8@kernel.org> In-Reply-To: <20260510081528.5257-3-fmancera@suse.de> References: <20260510081528.5257-1-fmancera@suse.de> <20260510081528.5257-3-fmancera@suse.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 10 May 2026 10:15:28 +0200 Fernando Fernandez Mancera wrote: > Introduce a new test, `ipv4_devconf_notify`, to verify that the kernel > sends the appropriate netlink notifications when IPv4 devconf parameters > are modified. > > Since YNL currently has a bug where it declares an array of u32 values > instead of the nested attributes expected by the kernel for devconf set > operations, a temporary hack (`patched_add_attr`) is included to > pack the netlink attributes correctly. Right, YNL doesn't really support the level or weirdness that netconf requires. Why use YNL? Can't we test this with iproute2? nit: sashiko found a typo in "notificiation" -- pw-bot: cr